Previsualisation broken

[KevinH]

Argh!

Will fix asap.

Thanks ...

Originally Posted by eschwartz

For starters, it's typoed.

/home/eschwartz/git/Sigil/src/main.cpp:549:39: error: ‘class QWebEngineProfile’ has no member named ‘setURLRequestInterceptor’; did you mean ‘setUrlRequestInterceptor’?
  549 |  QWebEngineProfile::defaultProfile()->setURLRequestInterceptor(urlint);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                       setUrlRequestInterceptor

[KevinH]

Just pushed typo fix (impacts Qt 5.13.x and later). Sorry about that. We do not have a travis or appveyor ci build for that version of Qt (yet!).

[BeckyEbook]

Windows 10 1909 + Qt 5.12.7
* Works OK.

Linux Arch + Qt 5.15.0
* No images in Preview
* No stylesheets in Preview
[errors in console: Failed to load resource: net::ERR_UNKNOWN_URL_SCHEME]
* No dark theme on most interface.

[KevinH]

Wow not good! For Linux can you run it with gdb and report the qDebug() output here.

Thanks,

Kevin

[KevinH]

We do not create any requests or schemes in the RequestInterceptor. We just block them.

Please verify that in your build, MainWindow.cpp has LocalFileCanAccessFileUrls set to true here:

https://github.com/Sigil-Ebook/Sigil...ndow.cpp#L4292

Or perhaps try a clean checkout and build on Linux as new files were added so the CMakeLists.txt has changed.

[DiapDealer]

Originally Posted by BeckyEbook

Windows 10 1909 + Qt 5.12.7
* Works OK.

Linux Arch + Qt 5.15.0
* No images in Preview
* No stylesheets in Preview
[errors in console: Failed to load resource: net::ERR_UNKNOWN_URL_SCHEME]
* No dark theme on most interface.

That's pretty much what I was experiencing originally.

I've got a fix for the hardcoded sigil dark theme. I'll push it after we get the functional problems fixed. In the meantime, Sigil will honor any desktop dark theme (qt5ct- or kvantum- enablex) if you unset FORCE_SIGIL_DARKMODE_PALETTE.

[DiapDealer]

Everything seems to be working fine for me on Arch with Qt5.15.0 and Kevin's latest changes, at first glance. Images load (in both ImageTabs and Preview), css is applied, mathml javascript is injected/loaded. Tons of new debug output. The above mentioned dark them issue is still present, but that's expected for now. I'll fix that cosmetic issue later.

@KevinH do you have a way for me to test whether the interceptor is blocking stuff it should?

Becky may not have built from the same source where she pulled the new commits to?? Not sure.

[BeckyEbook]

Totally clean fresh clone from github.
I will repeat the build in a moment.
LocalFileCanAccessFileUrls is true

[KevinH]

Thanks, that is good to know.

The debug output includes the url that generated the request (party), the url requested (destination url), nav type or resource type info, method (GET or POST), etc.

It should also correctly show the path (normally in tmp) to the current epub, the mathjax folder and the user css folder. We can use that to verify if the file: url is allowed or not.

Did they debug output seem to be okay?

Originally Posted by DiapDealer

Everything seems to be working fine for me on Arch with Qt5.15.0 and Kevin's latest changes at first glance. Images load (in both ImageTabs and Preview), css is applied, mathml javascript is injected/loaded. Tons of new debug output. The above mentioned dark them issue is still present, but that's expected for now. I'll fix that cosmetic issue later.

Becky may not have built from the same source where she pulled the new commits to?? Not sure.

[KevinH]

I will try to create an epub with a src link to try to access a file (img) in my local directory and it should fail.

Perhaps I can try something in javascript as well.

[KevinH]

Okay, here is one easy test...

1. Did a screen capture and renamed it to test.png and put it on my Desktop
2. Fired up Sigil and got the empty epub
3. added this line to the xhtml
< img src="file:///Users/kbhend/Desktop/test.png" />

in the debug log, I can see the request to load it but it will not load.

[DiapDealer]

Originally Posted by KevinH

Perhaps I can try something in javascript as well.

That's what I was wondering, too.

The debug output looks appropriate to me on Arch with 5.15.0 when loading fonts, images, css, mathjax, etc...

No errors/warnings in the inspector console about unknown url schemes.

[eschwartz]

FWIW my sigil-git development package is available on the Arch Linux AUR and trivializes the process of building sigil from the latest github code. I've even rebuilt it just now for the latest changes, and uploaded the results to https://wiki.archlinux.org/index.php...ries#eschwartz

Debug symbols are included if you install sigil-git-debug in addition to sigil-git.

[KevinH]

Then I edited main.cpp to disable adding the URLInterceptor and tried the test case again. Without the interceptor, the Desktop test.png was successfully loaded.

So it does appear to provide some protection!

[KevinH]

I think javascript has a hard time accessing local files without an api, but it could easily create a hidden tag with a src field pointed at something and take the data and upload it.

With this Interceptor in place, this should not happen as easily anymore.