Sigil-2.0.0 Released - Page 12

Vanguard3000 · 09-06-2023, 05:03 PM

Quote:

Originally Posted by KevinH

Not sure if there is anyway around it as classes with a space after certainly are "unused" by definition.

It's funny, in my decade + of editing ebooks, I can't recall ever running into this; but then again, I don't think I've ever seen a trailing space like that. It's not consistent throughout so I imagine there was a second class there at some point that was removed, rather than an odd stylistic choice.

Are spaces even allowed in a css class name? Would it not be as easy as just trimming leading and trailing spaces when checking used classes (ditto for the Mend & Prettify function)?

Quote:

Originally Posted by KevinH

Hopefully before deleting unused anythings you made a Checkpoint since it is very fast and easy that you could revert to.

I haven't actually experimented with checkpoints yet, though I should. I saved beforehand, and had the original, un-tampered-with version in a separate folder so it wasn't catastrophic.

Quote:

Originally Posted by KevinH

And thanks for testing the qt fix and reporting back.

Glad I could help! Thanks for everything!

KevinH · 09-06-2023, 05:09 PM

Okay, I just added code to harden the "delete unused styles" by removing trailing whitespace from class names. And pushed it to master.
It appears to now do the "right" thing.

As for mend or prettify handling that, it is hard because whitespace is generally allowed in attribute values, just not in class attribute values when only one class is present.

democrite · 09-06-2023, 06:02 PM

Quote:

Originally Posted by KevinH

@democrite

I needed a new testbuild to test a different accessibility fix so if you want you could try the following build and report back on if it fixes the focus issues you are seeing.

https://www.mobileread.com/forums/sh...7&postcount=16

Thank you very much Kevin. I was just using Restructure to Sigil norm and that's now ok. I'd guess elsewhere too.

KevinH · 09-08-2023, 12:21 PM

@DNSB,

Were you ever able to catch a crash and get a backtrace from it? Or figure out a sequence of events that can make the crash reproducible?

Thanks,

Kevin

Quote:

Originally Posted by DNSB

I've only made notes for the last 3 times and basically, I was replacing bits of the stylesheet using Regex when it happened. But then that is about 80-90% of what I do when editing epubs.

I don't have any Windows accessibility tools enabled.

I had a similar issue with 1.9.3.0 but those were a lot rarer. Once 6-8 weeks and mostly on the first pass at fixing a garbaged epub.

I did have gpu acceleration disabled from an issue with calibre a month or so back but I think that is unlikely to contribute to the errors.

I do have WinDbg installed and will enable it to see if I get any useful results.

DNSB · 09-08-2023, 02:40 PM

Quote:

Originally Posted by KevinH

@DNSB,

Were you ever able to catch a crash and get a backtrace from it? Or figure out a sequence of events that can make the crash reproducible?

Thanks,

Kevin

So far I've been starting Sigil from WinDbg and it's behaved itself. I even went back to the original copies of the last couple of books I was editing when the crash occurred and re-edited them. Still no crashes. Very annoying. I hate intermittent issues.

KevinH · 09-08-2023, 02:57 PM

If it operates successfully under WindDBG (or under any debugger) and not when used without that debugger, the underlying problem is typically related to a "race" between two events being processed by the code at the same time. One typically finishes before the other and therefore no bug generated. But sometimes the other one wins the race and causes a crash.

The debugger probably slows down the "bad" event of the two racing enough so that race no longer exists and so the bug is never recorded.

Of course that doesn't really help us much as we still have no idea what event is racing against what.

Please let us know if you ever get anything as I hate crashes and really want to remove all of them from Sigil as soon as they can be tracked down.

DNSB · 09-08-2023, 03:29 PM

I will do so.

DiapDealer · 09-09-2023, 01:46 PM

You also might want to consider updating your VC++ 2015-2022 redistributable. Anything after VS2015 is supposed to be compatible, but perhaps something in an older one can trigger issues.

Sigil only attempts to install the redistributable if it's missing, or really, really old. Otherwise we leave that up to the user.

Permalinks for the latest: https://learn.microsoft.com/en-us/cp...-2019-and-2022

DNSB · 09-09-2023, 04:25 PM

Quote:

Originally Posted by DiapDealer

Permalinks for the latest: https://learn.microsoft.com/en-us/cp...-2019-and-2022

I checked and my install was 14.32.31332. I've updated to 14.36.32532 from the link you posted. I'll try launching Sigil directly for the next while and see what happens.

DiapDealer · 09-09-2023, 05:31 PM

Yours was still pretty new. I doubt it was the issue, but the upgrade can't hurt either.

RbnJrg · 09-21-2023, 01:09 AM

Sigil now compiled with Qt 6.5.2 from the Arch repo! Better late than never

DiapDealer · 09-21-2023, 07:05 AM

Quote:

Originally Posted by RbnJrg

Sigil now compiled with Qt 6.5.2 from the Arch repo! Better late than never

Make sure you install the pyside6 package for plugin support. Sigil with Qt6 uses PySide6 rather than PyQt5/6 for plugins (and of course most Linux repos consider plugin support "optional").

Actually, with Linux using the system python rather than a bundled python, you might be able to get away with using PyQt5 for plugins. But plugin devs have been notified about the change to PySide6 being the default moving forward with Sigil 2.0. Almost all (known) gui plugins that use Qt for Python have been modified to work with PyQ5 or PySide6, but there's always the possibility that some plugin devs could make Sigil 2.0 and PySide6 the minimums for new plugins.

Capricorn · 09-22-2023, 03:05 AM

Quote:

Originally Posted by DiapDealer

You also might want to consider updating your VC++ 2015-2022 redistributable. Anything after VS2015 is supposed to be compatible, but perhaps something in an older one can trigger issues.

Sigil only attempts to install the redistributable if it's missing, or really, really old. Otherwise we leave that up to the user.

Permalinks for the latest: https://learn.microsoft.com/en-us/cp...-2019-and-2022

After download of the runtime exe, do you just run the executable or is this exe simply placed somewhere in the windows dir? I have never done this before. Hence my question. Trying to learn more.

DiapDealer · 09-22-2023, 07:26 AM

Quote:

Originally Posted by Capricorn

After download of the runtime exe, do you just run the executable or is this exe simply placed somewhere in the windows dir? I have never done this before. Hence my question. Trying to learn more.

The download is an installer. You need to run it.

Vanguard3000 · 09-28-2023, 01:12 PM

Found a new bug for you, which is pretty minor but hopefully also a quick fix.

Basically, if you go to the Metadata Editor and remove all Properties and hit OK you'll get a hard crash. It doesn't seem to be an issue with removing any specific Property; it's only if you try and commit with no Properties. This is pretty easily reproduceable and happens every time you follow the steps provided.

At the moment, I'm using the "2.0.1" test build KevinH provided to address the dual monitor issues I had been having with 2.0.0.

I would imagine the fix would involve a null check and/or ensuring there's some basic info in the metadata (i.e. last modified date), or at the very least the OK button should be disabled (or trigger an error) if the metadata is empty.

09-06-2023, 05:09 PM	#167
KevinH Sigil Developer Posts: 7,322 Karma: 4622344 Join Date: Nov 2009 Device: many	Okay, I just added code to harden the "delete unused styles" by removing trailing whitespace from class names. And pushed it to master. It appears to now do the "right" thing. As for mend or prettify handling that, it is hard because whitespace is generally allowed in attribute values, just not in class attribute values when only one class is present. Last edited by KevinH; 09-06-2023 at 06:18 PM.

09-09-2023, 01:46 PM	#173
DiapDealer Grand Sorcerer Posts: 27,203 Karma: 191422320 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	You also might want to consider updating your VC++ 2015-2022 redistributable. Anything after VS2015 is supposed to be compatible, but perhaps something in an older one can trigger issues. Sigil only attempts to install the redistributable if it's missing, or really, really old. Otherwise we leave that up to the user. Permalinks for the latest: https://learn.microsoft.com/en-us/cp...-2019-and-2022 Last edited by DiapDealer; 09-09-2023 at 01:48 PM.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Sigil-1.9.20 Released	DiapDealer	Sigil	12	01-28-2023 10:41 AM
Sigil-0.9.12 Released	DiapDealer	Sigil	194	03-15-2019 04:51 PM
Sigil-0.9.11 Released	DiapDealer	Sigil	37	02-18-2019 07:56 PM
Sigil-0.8.900 released for testing - Wait for Sigil-0.8.901	KevinH	Sigil	106	10-04-2015 11:41 AM
Sigil 0.6.0 Released	user_none	Sigil	93	11-24-2012 07:50 PM

09-08-2023, 02:57 PM	#171
KevinH Sigil Developer Posts: 7,322 Karma: 4622344 Join Date: Nov 2009 Device: many	If it operates successfully under WindDBG (or under any debugger) and not when used without that debugger, the underlying problem is typically related to a "race" between two events being processed by the code at the same time. One typically finishes before the other and therefore no bug generated. But sometimes the other one wins the race and causes a crash. The debugger probably slows down the "bad" event of the two racing enough so that race no longer exists and so the bug is never recorded. Of course that doesn't really help us much as we still have no idea what event is racing against what. Please let us know if you ever get anything as I hate crashes and really want to remove all of them from Sigil as soon as they can be tracked down.

09-08-2023, 03:29 PM	#172
DNSB Bibliophagist Posts: 31,139 Karma: 136000011 Join Date: Jul 2010 Location: Vancouver Device: Kobo Sage, Forma, Clara HD, Lenovo M8 FHD, Paperwhite 4, Tolino epos	I will do so.

09-09-2023, 05:31 PM	#175
DiapDealer Grand Sorcerer Posts: 27,203 Karma: 191422320 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Yours was still pretty new. I doubt it was the issue, but the upgrade can't hurt either.

09-21-2023, 01:09 AM	#176
RbnJrg Wizard Posts: 1,481 Karma: 6095013 Join Date: Mar 2013 Location: Rosario - Santa Fe - Argentina Device: Kindle 4 NT	Sigil now compiled with Qt 6.5.2 from the Arch repo! Better late than never

09-28-2023, 01:12 PM	#180
Vanguard3000 Zealot Posts: 148 Karma: 474196 Join Date: Jan 2011 Location: Ottawa Device: Kobo Aura H2O	Found a new bug for you, which is pretty minor but hopefully also a quick fix. Basically, if you go to the Metadata Editor and remove all Properties and hit OK you'll get a hard crash. It doesn't seem to be an issue with removing any specific Property; it's only if you try and commit with no Properties. This is pretty easily reproduceable and happens every time you follow the steps provided. At the moment, I'm using the "2.0.1" test build KevinH provided to address the dual monitor issues I had been having with 2.0.0. I would imagine the fix would involve a null check and/or ensuring there's some basic info in the metadata (i.e. last modified date), or at the very least the OK button should be disabled (or trigger an error) if the metadata is empty.