Possible bug in autocompletion tags

arspr · 12-10-2014, 02:59 PM

Hi, an issue I've found that I think it's a bug but it also could be a design decision for any reason...

Just suppose you have:

Code:

<p>A simple example text</p>

Then you type :

Code:

<p>A simple <em>example text</p>

And then you try to type the ending :

Code:

<p>A simple <em>example </text</p>

What you get is:

Code:

<p>A simple <em>example </text>text</p>

A bug?

eschwartz · 12-10-2014, 03:39 PM

Maybe calibre doesn't check the opening tag name.
It probably isn't usually a problem, since a user bug is that you started closing the tag after the space...

Terisa de morgan · 12-10-2014, 03:50 PM

Quote:

Originally Posted by eschwartz

Maybe calibre doesn't check the opening tag name.
It probably isn't usually a problem, since a user bug is that you started closing the tag after the space...

How is it an user bug? Because you should have begun previous to the space?

eschwartz · 12-10-2014, 04:11 PM

Quote:

Originally Posted by Terisa de morgan

How is it an user bug? Because you should have begun previous to the space?

I'll give that a... yes.

It is certainly valid code (it passes W3C validation), but that doesn't mean it isn't a mistake to tag the spaces like that. It is not in the intent of the writer, thus it is wrong.

Minor niggle. Because I think code should be written neatly and structurally sound, not just "whatever works" visually.

Why yes, I DO do the same with posted BBCode.

Terisa de morgan · 12-10-2014, 04:17 PM

Well, we must agree to disagree

In this case I go with autocompletion bug, up and front. Cyan sighed gives Cyan sighed or <p>Cyan </sighed>sighed, depending on where you put </. That's a mistake.

eschwartz · 12-10-2014, 04:44 PM

You mistake me.

It is a mutual bug, both parties are culpable.

But fat chance of fixing people

so calibre should be fixed instead.

I wouldn't say no to fixing both...

Terisa de morgan · 12-10-2014, 04:45 PM

Quote:

Originally Posted by eschwartz

You mistake me.

It is a mutual bug, both parties are culpable.

But fat chance of fixing people

so calibre should be fixed instead.

That, I totally agree

(from the point of view of a former SW developer

)

kovidgoyal · 12-10-2014, 10:27 PM

https://github.com/kovidgoyal/calibr...f88a5efe620097

Terisa de morgan · 12-10-2014, 11:35 PM

Thank you, Kovid.

12-10-2014, 02:59 PM	#1
arspr Dead account. Bye Posts: 587 Karma: 668244 Join Date: Mar 2011 Device: none	Possible bug in autocompletion tags Hi, an issue I've found that I think it's a bug but it also could be a design decision for any reason... Just suppose you have: Code: <p>A simple example text</p> Then you type <em>: Code: <p>A simple <em>example text</p> And then you try to type the ending </em>: Code: <p>A simple <em>example </text</p> What you get is: Code: <p>A simple <em>example </text>text</p> A bug?

12-10-2014, 04:17 PM	#5
Terisa de morgan Grand Sorcerer Posts: 6,233 Karma: 11768331 Join Date: Jun 2009 Location: Madrid, Spain Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2	Well, we must agree to disagree In this case I go with autocompletion bug, up and front. <p>Cyan sighed gives <p>Cyan</p> sighed or <p>Cyan </sighed>sighed, depending on where you put </. That's a mistake. Last edited by Terisa de morgan; 12-10-2014 at 04:23 PM.

12-10-2014, 04:44 PM	#6
eschwartz Ex-Helpdesk Junkie Posts: 19,422 Karma: 85397180 Join Date: Nov 2012 Location: The Beaten Path, USA, Roundworld, This Side of Infinity Device: Kindle Touch fw5.3.7 (Wifi only)	You mistake me. It is a mutual bug, both parties are culpable. But fat chance of fixing people so calibre should be fixed instead. I wouldn't say no to fixing both... Last edited by eschwartz; 12-10-2014 at 04:46 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
2.x UI bug: How to dismiss dropdown menu in Tags field?	MelBr	Calibre	10	10-19-2014 04:18 PM
Searching tags to show tags I want even when it has a tag I do not	Jade Aislin	Library Management	2	04-25-2012 01:01 PM
Amazon Tags - Popular tags vs Unique tags.	chrisanthropic	Writers' Corner	6	09-19-2011 11:18 PM
Small bug? Case-insensitive tags.	Arrghus	Calibre	9	07-12-2011 01:03 AM

12-10-2014, 03:39 PM	#2
eschwartz Ex-Helpdesk Junkie Posts: 19,422 Karma: 85397180 Join Date: Nov 2012 Location: The Beaten Path, USA, Roundworld, This Side of Infinity Device: Kindle Touch fw5.3.7 (Wifi only)	Maybe calibre doesn't check the opening tag name. It probably isn't usually a problem, since a user bug is that you started closing the tag after the space...

12-10-2014, 10:27 PM	#8
kovidgoyal creator of calibre Posts: 43,851 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	https://github.com/kovidgoyal/calibr...f88a5efe620097

12-10-2014, 11:35 PM	#9
Terisa de morgan Grand Sorcerer Posts: 6,233 Karma: 11768331 Join Date: Jun 2009 Location: Madrid, Spain Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2	Thank you, Kovid.

Advert

Advert