Writing an interface action plugin - Page 2

SirBC · 11-11-2010, 09:32 AM

Very cool!

kovidgoyal · 11-11-2010, 11:19 AM

I'd suggest posting the patch, you can generate it with

bzr send -o mypatch

or if you prefer a normal patch

bzr diff > mypatch

kiwidude · 11-11-2010, 12:32 PM

Hi Kovid,

Happy to generate the patch file and (presumably) add it to the tracker with a feature request.

However I think I need a slightly different command line since I did all this against revision 6785 (the tag of 2.7.6)?
So to get the code I had done:

bzr branch lp:calibre
bzr revert -r 6785

If it is all too hard I can get the latest code and reapply changes to that. It's only a few files that were changed - feel free to tell me the recommended way to get the latest too

kovidgoyal · 11-11-2010, 01:49 PM

bzr diff should still work against a reverted checkout

kiwidude · 11-11-2010, 01:55 PM

Quote:

Originally Posted by kovidgoyal

bzr diff should still work against a reverted checkout

Well the diff file that "bzr diff > xxx.txt" produces is 46600 lines! and is listing an awful lot more than just my changes?

For instance the file starts with changes to Changelog.yaml with version information for 0.7.27. So I think it might be comparing against the latest on the trunk or something?

kovidgoyal · 11-11-2010, 03:07 PM

Ah you didn't commit the reversion before making your changes, my fault, I forgot to tell you to do that.

The simplest way to generate the diff would be

bzr commit

and then

bzr diff -r number

where number is the same as the number you used for revert.

kiwidude · 11-11-2010, 04:11 PM

Thanks Kovid. There was one more step I had to do, and that was "bzr add" to ensure the new files got committed.

Generated the patch file and put in a zip along with the image binaries, attached to ticket #7502. Hope it is of use to someone as a starting point at least.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
New Plugin Type Idea: Library Plugin	cgranade	Plugins	3	09-15-2010 12:11 PM
Device interface plugin - nook	badmadbug	Plugins	2	09-06-2010 11:03 AM
Manybooks new interface	mtravellerh	Upload Help	0	11-30-2008 08:26 AM
OS X Interface	irulan	Calibre	5	09-13-2008 01:18 PM
iLiad Interface Design	nathany	iRex Developer's Corner	6	09-17-2007 02:05 PM

11-11-2010, 09:32 AM	#16
SirBC Connoisseur Posts: 56 Karma: 64 Join Date: Nov 2007 Device: Kindle	Very cool!

11-11-2010, 11:19 AM	#17
kovidgoyal creator of calibre Posts: 43,857 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	I'd suggest posting the patch, you can generate it with bzr send -o mypatch or if you prefer a normal patch bzr diff > mypatch

11-11-2010, 12:32 PM	#18
kiwidude Calibre Plugins Developer Posts: 4,637 Karma: 2162064 Join Date: Oct 2010 Location: Australia Device: Kindle Oasis	Hi Kovid, Happy to generate the patch file and (presumably) add it to the tracker with a feature request. However I think I need a slightly different command line since I did all this against revision 6785 (the tag of 2.7.6)? So to get the code I had done: bzr branch lp:calibre bzr revert -r 6785 If it is all too hard I can get the latest code and reapply changes to that. It's only a few files that were changed - feel free to tell me the recommended way to get the latest too

11-11-2010, 01:49 PM	#19
kovidgoyal creator of calibre Posts: 43,857 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	bzr diff should still work against a reverted checkout

11-11-2010, 03:07 PM	#21
kovidgoyal creator of calibre Posts: 43,857 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Ah you didn't commit the reversion before making your changes, my fault, I forgot to tell you to do that. The simplest way to generate the diff would be bzr commit and then bzr diff -r number where number is the same as the number you used for revert.

11-11-2010, 04:11 PM	#22
kiwidude Calibre Plugins Developer Posts: 4,637 Karma: 2162064 Join Date: Oct 2010 Location: Australia Device: Kindle Oasis	Thanks Kovid. There was one more step I had to do, and that was "bzr add" to ensure the new files got committed. Generated the patch file and put in a zip along with the image binaries, attached to ticket #7502. Hope it is of use to someone as a starting point at least.