CalibreDB not adding covers

[XrXca]

With one of the latest versions (I'm not sure which as I don't update every cycle, but the first time I saw it was with 3.38) calibredb has stopped adding covers specified in .opf files when you add using --one-book-per-directory.

I have a routine that places a PDF in a directory, creates an .opf file for it, creates a .jpg cover then calls calibredb, and the cover is no longer set, instead you get the blue default cover, in previous versions the cover was added correctly.

When I add from the front end interface using the the One book per directory option, the cover gets added correctly, but not when using calibredb.

To make sure it wasn't something in my .opf file, I just created a new blank library, manually added a pdf, set the author/title and cover for the pdf and saved that book to disk from calibre (S) and moved the resulting book directory to d:\cdbtest. Then removed that book from the library and tried re-adding it using calibredb.

C:>"c:\Program Files\Calibre2\calibredb.exe" --with-library=http://localhost:8080/#Testing add  --one-book-per-directory "d:\cdbtest"
Added book ids: 2

The book adds with the correct Author/Title, but with No Cover.

I ran this test with version 3.39.1 [64bit]

[kovidgoyal]

Works for me. Zip up this test folder of yours and attach it and I will try to reproduce with that.

[XrXca]

I've done a bit more testing using clean systems, the change happened between version 3.36 and 3.37.
Two screen captures are included in the zip that show the results.

For each version, a clean Windows 10 virtual machine was used, a C:\Calibre\Testing was created, Calibre 64bit was installed using the defaults (except for the library path)
The only setting changes was to turn on the "Allow un-authenticated local connections to make changes" option, and start the server.
Then the command line was run:

"\Program Files\Calibre2\calibredb.exe" --with-library=http://localhost:8080/#Testing add --one-book-per-directory "c:\Calibre\cdbtest"

Version 3.36 and earlier add the cover correctly, version 3.37 and on do not.

Interestingly if I do a set_metadata call with the id returned by the add call followed by the opf filename, the cover then gets set correctly, so the issue is just in the add portion.

[kovidgoyal]

https://github.com/kovidgoyal/calibr...ce4bf71ef18f18

[XrXca]

That fixed it, Thank You.

And an odd suggestion, not that it would make much difference to me as the server is always running with the GUI, but would it be useful to show (maybe in the statusbar) an indicator to show that the server is running?

And an odd question so I know for the future, I just made a donation, but since I'm not coming from the Rupee or US dollar, which I use makes no difference to me, I used US$ as I know that exchange rate without having to look it up, but do you have a preference of one currency over the other?

[kovidgoyal]

The color of the connect/share button in the toolbar serves as a visual indication that the server is running. And thanks fo rthe donation, either currency is fine with me.

[BetterRed]

Originally Posted by kovidgoyal

The color of the connect/share button in the toolbar serves as a visual indication that the server is running. And thanks fo rthe donation, either currency is fine with me.

Because I don't have a toolbar I didn't know that - any chance of putting something in the status bar - maybe make your name blink (joke ) ?

[XrXca]

Originally Posted by kovidgoyal

The color of the connect/share button in the toolbar serves as a visual indication that the server is running.

Huh, I never knew that either. I generally drop a half dozen of the default toolbar buttons to make room for plugins, and that was one of them.