JBPatch - Page 27

veezh · 08-02-2012, 10:41 AM

First of all, thank you and big karma to ixtab!! I nearly shed tears of joy when I first saw my Kindle displaying correct justification and hyphenation.

I have managed to get hyphenation working perfectly in English and Dutch books. Unfortunately, I haven't managed to get it working in French yet.

Has anyone managed to get French hyphenation working?

My books are in mobi6 format (not KF8), and I have double-checked to be sure the language is identified correctly (French - Standard).

In the JBPatch log file, I do see the following lines:

I: Loading Hyphenations for language ID 1036 (fr)
java.lang.NoSuchMethodError: java.lang.Character: method valueOf(C)Ljava/lang/Character; not found

Sorry, my Java skills are non-existent... If anyone has a clue how to get this working, I would be very appreciative!

ixtab · 08-02-2012, 11:04 AM

Quote:

Originally Posted by veezh

First of all, thank you and big karma to ixtab!! I nearly shed tears of joy when I first saw my Kindle displaying correct justification and hyphenation.

I have managed to get hyphenation working perfectly in English and Dutch books. Unfortunately, I haven't managed to get it working in French yet.

Has anyone managed to get French hyphenation working?

My books are in mobi6 format (not KF8), and I have double-checked to be sure the language is identified correctly (French - Standard).

In the JBPatch log file, I do see the following lines:

I: Loading Hyphenations for language ID 1036 (fr)
java.lang.NoSuchMethodError: java.lang.Character: method valueOf(C)Ljava/lang/Character; not found

Sorry, my Java skills are non-existent... If anyone has a clue how to get this working, I would be very appreciative!

Argh... this is a bug in the patch, thanks for pointing it out.

The problem is that the (hyphenation) source is backported from Java 5, and the Character.valueOf() method doesn't exist in Java 1.4.2 (but Eclipse wouldn't tell me so because I had it configured wrong

).

Anyway, this should be fixed with version 2012-08-02. Please re-download the patch and let me know if it fixes the problem.

veezh · 08-02-2012, 11:26 AM

Wow, you're fast, ixtab! Hyphenation now works in French too.

Can't tell you how happy you've made me!

Antoinekamel · 08-02-2012, 02:08 PM

Report: Portuguese is perfectly hyphenized now with the patch correction!

(I thought it not working was some of my fault, because in English it was ok...)

eureka · 08-02-2012, 03:40 PM

There is a duplicated string "This value determines the left margin for PDF files." instead of [correct] "This value determines the right margin for PDF files." in localizable resources of JBPatch (ixtab-patch-margins).

wolftail · 08-02-2012, 04:17 PM

GAAAAAH! I'm trying to create a new translation but I don't understand how Transifex works...
EDIT: Nevermind...

eureka · 08-02-2012, 04:30 PM

Quote:

Originally Posted by wolftail

GAAAAAH! I'm trying to create a new translation but I don't understand how Transifex works...

Training Part 1:

Spoiler:

Training Part 2:

Spoiler:

ixtab · 08-02-2012, 05:26 PM

This version fixes most of the issues that have piled up so far. There have been a few cosmetic changes and a few bugfixes, and I've fixed the localization issue that eureka mentioned, and added 3 additional words to be translated

This version includes the latest version of the hyphenation patch. Note that because of internal changes, the reverse is also true: the latest hyphenation patch requires version 2.1.2!

Download, as always, in the first post. Be sure to read the upgrade notes.

ixtab · 08-02-2012, 05:40 PM

So... this is possible after all... it's even included in the stock firmware, it's just completely disabled.

Click image for larger version

Name: coverview.gif
Views: 814
Size: 84.4 KB
ID: 90075

(No, this is not ready for release yet. There are still quite a few things that need to be figured out...)

eureka · 08-02-2012, 06:10 PM

@ixtab, one patch after another, so you're unstoppable, eh?

Maybe it's worth to take a second look at idea of representing /mnt/us sub-directories as collections in Home screen? It's possible to group cc.db entries located directly at /mnt/us under a "virtual" collection (the same type as Dictionaries or Images collection) and then just filter entries from cc.db by /mnt/us/<currently selected subpath>/ and display found entries.

Yes, I probably could do it by myself. But you've took my POC patch for cover view and evolve it to usable state. So, I hope...

ixtab · 08-02-2012, 06:19 PM

@eureka: It's basically already done, except for the mnt/us/documents/ only, and only for files which are actually recognized by the Kindle in the collections DB. Anything else has too much potential of seriously screwing things up.

See the Collections Manager thread...

eureka · 08-02-2012, 06:52 PM

Quote:

Originally Posted by ixtab

@eureka: It's basically already done, except for the mnt/us/documents/ only, and only for files which are actually recognized by the Kindle in the collections DB. Anything else has too much potential of seriously screwing things up.

See the Collections Manager thread...

Collections Manager is a bit excessive for the sole purpose of browsing of directory structure and it also requires explicit synchronizing of directory structure into collections structure with updating of cc.db (isn't it?).

I'm talking about dynamic showing of "virtual" collections structure without any changing of cc.db. I.e. File browser collection which is implemented in Java like Dictionaries or Images collection.

(A small correction of myself. When I've talked about /mnt/us, I've meant /mnt/us/documents. Also listing of only files from cc.db is OK.)

Well, I understand that Collections Manager was the answer to similar request, but reviving of cover view patch was for me like "He's out of ideas, maybe I could incept another one"

notimp · 08-02-2012, 07:09 PM

@ixtab: All version numbers (log, ui, device) after the updrade still show 2.1.1. Did the update not work, or did you forget to change them?

ixtab · 08-02-2012, 07:28 PM

Quote:

Originally Posted by notimp

@ixtab: All version numbers (log, ui, device) after the updrade still show 2.1.1. Did the update not work, or did you forget to change them?

Good catch!

The version number is present in 4 different places... and I updated all of them, except for the most important one

You can see that it actually is 2.1.2 by long-clicking on the entry in the home screen to show the details. Anyway, I attached the fixed file now. Thanks for the hint!

notimp · 08-02-2012, 07:45 PM

Installed the fixed version. Had to do that before going to sleep.

Thank you as always.
n.

08-02-2012, 10:41 AM	#391
veezh plus ça change Posts: 101 Karma: 32134 Join Date: Dec 2009 Location: France Device: Kindle PW2, Voyage	Hyphenation in French? First of all, thank you and big karma to ixtab!! I nearly shed tears of joy when I first saw my Kindle displaying correct justification and hyphenation. I have managed to get hyphenation working perfectly in English and Dutch books. Unfortunately, I haven't managed to get it working in French yet. Has anyone managed to get French hyphenation working? My books are in mobi6 format (not KF8), and I have double-checked to be sure the language is identified correctly (French - Standard). In the JBPatch log file, I do see the following lines: I: Loading Hyphenations for language ID 1036 (fr) java.lang.NoSuchMethodError: java.lang.Character: method valueOf(C)Ljava/lang/Character; not found Sorry, my Java skills are non-existent... If anyone has a clue how to get this working, I would be very appreciative!

08-02-2012, 04:17 PM	#396
wolftail Connoisseur Posts: 59 Karma: 57554 Join Date: Jan 2012 Location: Romania Device: Kindle Touch	GAAAAAH! I'm trying to create a new translation but I don't understand how Transifex works... EDIT: Nevermind... Last edited by wolftail; 08-02-2012 at 04:31 PM.

08-02-2012, 05:26 PM	#398
ixtab (offline) Posts: 2,907 Karma: 6736092 Join Date: Dec 2011 Device: K3, K4, K5, KPW, KPW2	Version 2.1.2 This version fixes most of the issues that have piled up so far. There have been a few cosmetic changes and a few bugfixes, and I've fixed the localization issue that eureka mentioned, and added 3 additional words to be translated This version includes the latest version of the hyphenation patch. Note that because of internal changes, the reverse is also true: the latest hyphenation patch requires version 2.1.2! Download, as always, in the first post. Be sure to read the upgrade notes. Last edited by ixtab; 08-02-2012 at 07:39 PM.

08-02-2012, 05:40 PM	#399
ixtab (offline) Posts: 2,907 Karma: 6736092 Join Date: Dec 2011 Device: K3, K4, K5, KPW, KPW2	So... this is possible after all... it's even included in the stock firmware, it's just completely disabled. (No, this is not ready for release yet. There are still quite a few things that need to be figured out...)

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search

08-02-2012, 11:26 AM	#393
veezh plus ça change Posts: 101 Karma: 32134 Join Date: Dec 2009 Location: France Device: Kindle PW2, Voyage	Wow, you're fast, ixtab! Hyphenation now works in French too. Can't tell you how happy you've made me!

08-02-2012, 02:08 PM	#394
Antoinekamel Addict Posts: 278 Karma: 2511467 Join Date: Feb 2012 Device: ABC W p2	Report: Portuguese is perfectly hyphenized now with the patch correction! (I thought it not working was some of my fault, because in English it was ok...)

08-02-2012, 03:40 PM	#395
eureka but forgot what it's like Posts: 741 Karma: 2345678 Join Date: Dec 2011 Location: north (by northwest) Device: Kindle Touch	There is a duplicated string "This value determines the left margin for PDF files." instead of [correct] "This value determines the right margin for PDF files." in localizable resources of JBPatch (ixtab-patch-margins).

08-02-2012, 06:10 PM	#400
eureka but forgot what it's like Posts: 741 Karma: 2345678 Join Date: Dec 2011 Location: north (by northwest) Device: Kindle Touch	@ixtab, one patch after another, so you're unstoppable, eh? Maybe it's worth to take a second look at idea of representing /mnt/us sub-directories as collections in Home screen? It's possible to group cc.db entries located directly at /mnt/us under a "virtual" collection (the same type as Dictionaries or Images collection) and then just filter entries from cc.db by /mnt/us/<currently selected subpath>/ and display found entries. Yes, I probably could do it by myself. But you've took my POC patch for cover view and evolve it to usable state. So, I hope...

08-02-2012, 06:19 PM	#401
ixtab (offline) Posts: 2,907 Karma: 6736092 Join Date: Dec 2011 Device: K3, K4, K5, KPW, KPW2	@eureka: It's basically already done, except for the mnt/us/documents/ only, and only for files which are actually recognized by the Kindle in the collections DB. Anything else has too much potential of seriously screwing things up. See the Collections Manager thread...

08-02-2012, 07:09 PM	#403
notimp Addict Posts: 248 Karma: 892441 Join Date: Jul 2010 Device: K2i	@ixtab: All version numbers (log, ui, device) after the updrade still show 2.1.1. Did the update not work, or did you forget to change them?

08-02-2012, 07:45 PM	#405
notimp Addict Posts: 248 Karma: 892441 Join Date: Jul 2010 Device: K2i	Installed the fixed version. Had to do that before going to sleep. Thank you as always. n.