[Feature request] Confirmation or warning when deleting file

max-min · 11-25-2020, 05:46 AM

Hi,

It happens me quite a few times that I think I'm editing the text and I delete some letters, but, if the focus is on the file-selector, I'm in fact deleting one or even several files without even noticing it.

If I realize my mystaket before to exit, I can reverse it with Ctrl-left, at the cost of loosing all changed made after this accident. But if I save and exit, I end up with an amputated epub.

Would it be a good idea to ask confirmation when deleting a file in the file-selector, since it is a rather destructive action ? Or at least to pop-up a warning for some seconds so it won't go unnoticed ?

Thank you !

kovidgoyal · 11-25-2020, 06:30 AM

Well, one of the major reasons for the whole checkpointing ability (the left arrow) in the editor is that if you accidentally do something, you can undo it, including delete files. This allows the editor to dispense with the whole rigmarole of confirmation popups.

max-min · 11-25-2020, 07:18 AM

Thank you for the answer, Kovid.

Well, you're right in the way we can undo the action, but what if we don't noticed we've just deleted a file? (it really happened to me). So, maybe a short warning box ("File deleted") ? Just half a second, so the action is acknowledged ? And only when just one file is selected in the file-selector, this accident is unlikely when more than one file is selected,

kovidgoyal · 11-25-2020, 09:57 AM

Some kind of non-modal warning is fine, but not a priority for me to implement. I'll get to it when I have time, or patches are welcome.

kovidgoyal · 11-25-2020, 11:03 AM

There you go, now the editor beeps when deleting a file. https://github.com/kovidgoyal/calibr...df1de8f218b924

JSWolf · 11-25-2020, 11:04 AM

Quote:

Originally Posted by kovidgoyal

There you go, now the editor beeps when deleting a file. https://github.com/kovidgoyal/calibr...df1de8f218b924

Can this be turned off?

kovidgoyal · 11-25-2020, 11:06 AM

no, it cant.

JSWolf · 11-25-2020, 11:10 AM

Quote:

Originally Posted by kovidgoyal

no, it cant.

Please then delete this feature. I do delete a lot of files and do not want the beeping or to have to turn off the sound. Again this is a change to benefit one that doesn't benefit others like the preview window color change in 4.22. And that fuzzy search that was for the benefit of one.

kovidgoyal · 11-25-2020, 11:12 AM

You delete a lot of files in a go, you get one beep. You will survive one beep.

JSWolf · 11-25-2020, 11:25 AM

Quote:

Originally Posted by kovidgoyal

You delete a lot of files in a go, you get one beep. You will survive one beep.

But I don't delete in one go. I delete useless HTML files and then any orphaned graphics and fonts I don't want. Having to delete in on go is not a workable solution.

kovidgoyal · 11-25-2020, 11:38 AM

Right, so you have to live with two beeps, the horror.

max-min · 11-25-2020, 12:08 PM

Thank you Kovid, and sorry JSWolf, I couldn't imagine that one deletes a lot of individual files. If it is better to reverse this, I certainly will understand it.

Terisa de morgan · 11-25-2020, 01:08 PM

Quote:

Originally Posted by max-min

Thank you Kovid, and sorry JSWolf, I couldn't imagine that one deletes a lot of individual files. If it is better to reverse this, I certainly will understand it.

I agree with JSWolf too, as I check file to file, and remove as I check, not in a batch. But, anyway, if it's a beep, I'll disable the sound and that's all.

max-min · 11-25-2020, 02:04 PM

What about a short, tiny an non-blocking msg-box ?
Or a confirm-box with the standard check-box "Show this confirmation again" ?

JSWolf · 11-25-2020, 03:18 PM

Quote:

Originally Posted by Terisa de morgan

I agree with JSWolf too, as I check file to file, and remove as I check, not in a batch. Buy, anyway, if it's a beep, I'll disable the sound and that's all.

I do the same thing when I delete unneeded files.

11-25-2020, 05:46 AM	#1
max-min Member Posts: 13 Karma: 280 Join Date: Aug 2017 Device: touch lux	[Feature request] Confirmation or warning when deleting file Hi, It happens me quite a few times that I think I'm editing the text and I delete some letters, but, if the focus is on the file-selector, I'm in fact deleting one or even several files without even noticing it. If I realize my mystaket before to exit, I can reverse it with Ctrl-left, at the cost of loosing all changed made after this accident. But if I save and exit, I end up with an amputated epub. Would it be a good idea to ask confirmation when deleting a file in the file-selector, since it is a rather destructive action ? Or at least to pop-up a warning for some seconds so it won't go unnoticed ? Thank you !

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Feature request : using a custom css file	Bertrand	Writer2ePub	8	12-28-2019 11:46 AM
images import "bulk confirmation" feature request	Olivier_Rebiere	Sigil	4	03-23-2017 08:42 AM
Feature Request - Edit File Option	fcoulter	Calibre	10	07-22-2010 12:56 AM
Feature request: make two or more files into one big file	spikebrennan	Calibre	4	07-19-2010 09:24 PM
Confirmation before deleting files	mrgoodkat	Calibre	2	02-06-2010 11:24 PM

11-25-2020, 06:30 AM	#2
kovidgoyal creator of calibre Posts: 43,896 Karma: 22666668 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Well, one of the major reasons for the whole checkpointing ability (the left arrow) in the editor is that if you accidentally do something, you can undo it, including delete files. This allows the editor to dispense with the whole rigmarole of confirmation popups.

11-25-2020, 07:18 AM	#3
max-min Member Posts: 13 Karma: 280 Join Date: Aug 2017 Device: touch lux	Thank you for the answer, Kovid. Well, you're right in the way we can undo the action, but what if we don't noticed we've just deleted a file? (it really happened to me). So, maybe a short warning box ("File deleted") ? Just half a second, so the action is acknowledged ? And only when just one file is selected in the file-selector, this accident is unlikely when more than one file is selected,

11-25-2020, 09:57 AM	#4
kovidgoyal creator of calibre Posts: 43,896 Karma: 22666668 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Some kind of non-modal warning is fine, but not a priority for me to implement. I'll get to it when I have time, or patches are welcome.

11-25-2020, 11:03 AM	#5
kovidgoyal creator of calibre Posts: 43,896 Karma: 22666668 Join Date: Oct 2006 Location: Mumbai, India Device: Various	There you go, now the editor beeps when deleting a file. https://github.com/kovidgoyal/calibr...df1de8f218b924

11-25-2020, 11:06 AM	#7
kovidgoyal creator of calibre Posts: 43,896 Karma: 22666668 Join Date: Oct 2006 Location: Mumbai, India Device: Various	no, it cant.

11-25-2020, 11:12 AM	#9
kovidgoyal creator of calibre Posts: 43,896 Karma: 22666668 Join Date: Oct 2006 Location: Mumbai, India Device: Various	You delete a lot of files in a go, you get one beep. You will survive one beep.

11-25-2020, 11:38 AM	#11
kovidgoyal creator of calibre Posts: 43,896 Karma: 22666668 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Right, so you have to live with two beeps, the horror.

11-25-2020, 12:08 PM	#12
max-min Member Posts: 13 Karma: 280 Join Date: Aug 2017 Device: touch lux	Thank you Kovid, and sorry JSWolf, I couldn't imagine that one deletes a lot of individual files. If it is better to reverse this, I certainly will understand it.

11-25-2020, 02:04 PM	#14
max-min Member Posts: 13 Karma: 280 Join Date: Aug 2017 Device: touch lux	What about a short, tiny an non-blocking msg-box ? Or a confirm-box with the standard check-box "Show this confirmation again" ?

Advert

Advert