bugs in book browser

[Reinhard]

The following 2 bugs appear both in sigil from Debian sid and in a selfcompiled sigil from git.
1.) I can't select multiple files with ctrl and mouse or with shift and mouse. sigil seems to ignore the keys. Select all from local menu (right click) is working.
2.) Trying to reorder files crashes sigil when I try to drop the file to a new location.

Reinhard

[DiapDealer]

Can't say as I've ever experienced either of those issues with Arch Linux or Ubuntu. Selecting multiple files and re-ordering them is a fairly common task, and this is the very first I've heard of any issues with them.

I'll double-check when I get home, but we are literally in the final hours of a new release.

[st_albert]

FWIW, here's what I've experienced. (I'm currently using Sigil 0.9.9, built from source, on Kubuntu 16.04, but it's been like this since "forever".)

To select multiple consecutive chapters in the book browser, I click on the first one, then shift-click on the last one. For a moment, all are highlited, but the highlight disappears for all but the last one. If I shift-click again on the last one, all the highlighting re-appears, and stays.

I don't seem to be able to ctrl-click multiple files at all, consecutive or otherwise.

Albert

[DiapDealer]

Originally Posted by st_albert

FWIW, here's what I've experienced. (I'm currently using Sigil 0.9.9, built from source, on Kubuntu 16.04, but it's been like this since "forever".)

To select multiple consecutive chapters in the book browser, I click on the first one, then shift-click on the last one. For a moment, all are highlited, but the highlight disappears for all but the last one. If I shift-click again on the last one, all the highlighting re-appears, and stays.

I don't seem to be able to ctrl-click multiple files at all, consecutive or otherwise.

Albert

Hmmm. That's disappointing. I don't ever remember anyone mentioning anything about such a long-standing issue. Perhaps it was reported before my time?

Does reordering the files (drag and drop) in Book Browser cause any crashes for you? If not, I think we'll move forward with this release and make taking a look at this issue a priority for the next.

[st_albert]

Originally Posted by DiapDealer

Hmmm. That's disappointing. I don't ever remember anyone mentioning anything about such a long-standing issue. Perhaps it was reported before my time?

I could be wrong, but I think I mentioned it a long time ago when I first encountered it. However, since I found the workaround (I usually only select consecutive groups of files for chapter renaming -- never use ctrl-click) it wasn't / isn't a burning issue for me.

Originally Posted by DiapDealer

Does reordering the files (drag and drop) in Book Browser cause any crashes for you? If not, I think we'll move forward with this release and make taking a look at this issue a priority for the next.

Nope, I regularly drag and drop individual files, such as creating an HTML TOC and dragging it where I want it, or when adding a file to an existing epub, without any problems.

Albert

[KevinH]

FWIW, I tested with with stock Sigil 0.9.9 on Mac OS X, I can NOT recreate any of this.

I can click on a chapter in the BookBrowser and then shift click a bunch of contiguous files and it highlights just fine and I can drag and drop them to a new location with no problems.

I can also click on a file and then Command click (apple key) on another file (not contiguous) and happily drag and drop those as well.

So whatever issue this is, does not exist on a Mac so that kind of points to a Qt issue of some sort.

That said, there are many programs that look and and remap keys (control and otherwise) that could be interfering including a user's own key settings in Sigil's Preferences.

[st_albert]

I can't reproduce any of it on Win-10 with Sigil 0.9.7 either.

Back on Kubuntu, shift-click works as expected in code view, and ctl-click works in the clip editor, for example, and I haven't knowingly re-assigned the ctl key in preferences (if in fact you could).

I think it's been happening on kubuntu with various Qt 5.x versions, and maybe even 4.x as well, but I won't swear to it now.

Not much help, eh?

Albert

[Reinhard]

I attached a backtrace from the crash.

Reinhard

[KevinH]

The only linux specific thing I see in that backtrace is this:

QWindowSystemInterface::sendWindowSystemEvents(QFl ags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
#32 0x00007fffe769a2cb in () at /usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5

libQt5XcbQpa.so is a front for a platform specific plugin (libqxcb.so)

Do you have multiple versions of Qt installed?
Do you have environment variables set that might point to incorrect Qt library plugins?

What script are you using to actually launch Sigil and does it properly set the QT_PLUGIN_PATH?

[DiapDealer]

It's probably the distro's own Qt5 platform plugin for that Desktop. They use them to try and force a consistent theme across all apps.

I've never had any problems with the platform plugins on Gnome or Cinnamon desktops, but I've run into KDE/Qt5 issues in the past that we've had to try and come up with workarounds for. Injecting the keyboard shortcut ampersands into Menu items' name properties was the last one I remember. It prevented plugins from being run from the menus on certain KDE desktops, if I recall.

[Doitsu]

I wasn't able to reproduce this issue on my OpenBox Arch Linux machine either.

@Reinhard: What's your desktop environment?

[Reinhard]

My desktop environment is KDE, QT revison 5.10. is the only QT version.
QT_PLUGIN_PATH is not set.
I'm waiting for QT 5.11.1, which I hope will arrive soon.

Reinhard

[DiapDealer]

KDE has that odd single-click for everything that always messes me up. I think it messes up Qt at times, too. For instance: single-clicking on a file in Sigil's Book Browser immediately opens the file in a new tab (or switches focus to it if it's tab is already open) with KDE. On my Linux DE, I have to double-click on a file in Book Browser to open the tab. One click just highlights it. I think that's part of the issue, here.

[DiapDealer]

Yep.

Changing the system mouse behavior on Kubuntu to "Double-click to open files and folders (select icons of first click)" makes file selection work "normally" for me in Sigil's Book Browser. Multiple selections work with either Ctrl or Shift.

Whereas I experience the exact same behavior described by st_albert when the setting is set to "Single-click to open files and folders" (including his workaround)

Originally Posted by st_albert

To select multiple consecutive chapters in the book browser, I click on the first one, then shift-click on the last one. For a moment, all are highlited, but the highlight disappears for all but the last one. If I shift-click again on the last one, all the highlighting re-appears, and stays.

I don't seem to be able to ctrl-click multiple files at all, consecutive or otherwise.

Will need to dig into that after this release. Has to be something that can be done to get Qt TreeView to play nice with KDE's Single-click/Double-click settings. I'm assuming other Qt apps do.

[DiapDealer]

For what it's worth, the single-click-to-open nature of KDE means that when a new tab is opened (or takes focus) because of single-clicking on a file in Book Browser, the cursor is immediately going to the BV/CV editor and the TreeView items are losing focus as a result.

The only reason I've never noticed this behavior before whenever testing in KDE, is because turning off single-click-to-open is almost always the first thing I do on a KDE system. It's the only way I can keep my sanity.