07-17-2018, 12:37 PM | #136 |
Grand Sorcerer
Posts: 6,212
Karma: 16534894
Join Date: Sep 2009
Location: UK
Device: Kobo: KA1, ClaraHD, Forma, Libra2, Clara2E. PocketBook: TouchHD3
|
|
07-17-2018, 01:15 PM | #137 | |
absolute beginner
Posts: 323
Karma: 1750999
Join Date: May 2017
Location: Go with the wind (43°19'17.7"N 2°00'19.4"W)
Device: ka1
|
Quote:
It depends on the patch and/or the value of parameter/variable. If you pass a number of devices as parameter the patch will made for those devices. If you don't pass a parameter (or var is null) the program acts as now. This could be a comparative Spoiler:
In the first case (now) the user must go patch by patch changing the value he/she wants. In the second one he/she only must say the device once. I think it's pretty simple for the common user. Good luck. |
|
Advert | |
|
07-17-2018, 01:43 PM | #138 |
Grand Sorcerer
Posts: 6,233
Karma: 11768331
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
Nobody should write after a nap....
Last edited by Terisa de morgan; 07-17-2018 at 02:40 PM. |
07-17-2018, 02:20 PM | #139 |
Evangelist
Posts: 407
Karma: 314204
Join Date: Jan 2015
Device: bq Avant XL, Kobo Aura H2O, Onyx Boox M96C Plus
|
Like I see, I think is better the second option. With the first you still must modify the patch whenever you use for a different device going through the patch file to comment and uncomment options. With the second you must change only the name of device at the beginning.
But @geek1011, why not to pass the name for device like a parameter? |
07-17-2018, 11:51 PM | #140 | |
Zealot
Posts: 140
Karma: 82382
Join Date: Jan 2013
Device: Kindle Paperwhite, Kobo Glo, Kobo GloHD
|
Quote:
Adding some command line parsing I would switch to specifying the config yaml via an extra cmd line flag instead of a normal argument? E.g. Code:
kobopatch [--config SomeConfig.yaml] [--firmware PathToFirmware.zip] |
|
Advert | |
|
07-18-2018, 09:48 AM | #141 | |
Wizard
Posts: 2,735
Karma: 6987557
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
|
Quote:
I'd keep the config as a positional argument so Windows users can drag and drop a config file. |
|
07-18-2018, 09:52 AM | #142 | |
Wizard
Posts: 2,735
Karma: 6987557
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
|
Quote:
Also, did you get the quotes working properly? |
|
07-19-2018, 03:39 AM | #143 | |
absolute beginner
Posts: 323
Karma: 1750999
Join Date: May 2017
Location: Go with the wind (43°19'17.7"N 2°00'19.4"W)
Device: ka1
|
Quote:
I think so. Thanks. There was an extra " ' " hidden. If you aren't convinced, then you shouldn't do. Don't worry about. Your decision on the parameter/variable will be the best. You had fill the main goal (zlib support). Just in case this helps (I hope so): I think is a question of choosing between an universal solution and optimized one. In the first case final user must choose (one by one) all his/her devices need. And very important: you have spare time, because you are done. In the second one, user gets what his/her device needs in exchange of a device id, but must run once per device. You must think on and code. This reminds me... the code is not optimized at all (there is an entire css four times repeated) and we overload it with more (four or six options for one only device is a lot of dead code). So, as a final user, what do you want? Do you prefer simplicity or universality? And you developer? Yours is the last word. Thanks. Good luck. |
|
07-21-2018, 03:45 AM | #144 |
absolute beginner
Posts: 323
Karma: 1750999
Join Date: May 2017
Location: Go with the wind (43°19'17.7"N 2°00'19.4"W)
Device: ka1
|
Two typo on nickel 4.9.11311.
Spoiler:
Good luck. |
07-21-2018, 01:38 PM | #145 |
Wizard
Posts: 2,735
Karma: 6987557
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
|
What patch is that? I don't remember converting a patch that looked like that.
Also, I'll be away for the next 2 weeks. I'll be unable to respond to any posts. If a new firmware version happens to come out during that time, GeoffR should be able to update and release a new version. If not, I'll do it as soon as I am back. |
07-21-2018, 01:54 PM | #146 | |
absolute beginner
Posts: 323
Karma: 1750999
Join Date: May 2017
Location: Go with the wind (43°19'17.7"N 2°00'19.4"W)
Device: ka1
|
Quote:
Don't worry, be happy! Good luck. |
|
07-21-2018, 09:14 PM | #147 |
Grand Sorcerer
Posts: 24,907
Karma: 47303748
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
|
|
07-22-2018, 10:46 AM | #148 | |
absolute beginner
Posts: 323
Karma: 1750999
Join Date: May 2017
Location: Go with the wind (43°19'17.7"N 2°00'19.4"W)
Device: ka1
|
Quote:
I'm not totally sure because it doesn't happen to my A1. #48 involves only A1 but margin-right => no way, and #138 involves only Aura and bottomVerticalSpacer min-height -> it is a good candidate but it must be tried on it. Anyway, if it makes work a little bit better... it can't be bad. Ref. Good luck. Last edited by jcn363; 07-22-2018 at 10:59 AM. |
|
07-23-2018, 09:44 AM | #149 |
absolute beginner
Posts: 323
Karma: 1750999
Join Date: May 2017
Location: Go with the wind (43°19'17.7"N 2°00'19.4"W)
Device: ka1
|
This kind of zlib optimization per device it's not very big (about 12% better in my A1), but, at least, it's not less than zero.
I must say I don't really noted any improve while I was reading but... numbers are numbers. I've though this can be a kind of placebo, and that's because I'm uploading here, just in case someone wants to prove... Thanks. Good luck. Edit: Here we go again. Now with Dragon (AuraHD, H2O) version too. If you try, please share your impressions. Edit²: Nova (ClaraHD) added. I can't test on the device, therefore the risk is all yours (as always). Edit³: Added clean file. Even better (at least, if you don't own several devices or use locale ). Without locale and device seems more responsive. Note: is for A1. Good luck. Last edited by jcn363; 08-03-2018 at 04:03 AM. Reason: A little bit more clean, structured and optimized. |
08-03-2018, 04:12 AM | #150 |
absolute beginner
Posts: 323
Karma: 1750999
Join Date: May 2017
Location: Go with the wind (43°19'17.7"N 2°00'19.4"W)
Device: ka1
|
I've added a new file, a clean one, in the previous post. Now yes, I can say I really noticed an improvement while I was reading.
Good luck. |
Tags |
kobo, kobopatch, patch, patch32lsb |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
kobopatch - A new (WIP) patching system | geek1011 | Kobo Developer's Corner | 93 | 05-27-2018 03:04 PM |
Patching H2O | Maillemom | Kobo Developer's Corner | 8 | 10-19-2016 09:58 AM |
Instructions for patching firmware 3.17.3 | GeoffR | Kobo Developer's Corner | 60 | 09-17-2015 05:35 PM |
Instructions for patching firmware 3.8.0 | GeoffR | Kobo Developer's Corner | 92 | 10-22-2014 07:22 AM |
how to clean more disk space in root file system to upgrade system | chinaet | iRex | 1 | 12-18-2006 03:54 PM |