[Bug] Image Reports Crash

Tex2002ans · 06-26-2018, 02:34 AM

This is Sigil 0.9.9 on Windows 10 (1803).

Steps to Reproduce

Open the sample EPUB.

1. Tools > Reports > Image Files.

2. Go back to the Book Browser and delete one of the images:

Click image for larger version

Name: Step2.png
Views: 207
Size: 35.6 KB
ID: 164666

3. Go back to the Report and try to sort one of the columns:

Click image for larger version

Name: Step3.png
Views: 201
Size: 19.7 KB
ID: 164667

Instant crash. No error or anything.

KevinH · 06-26-2018, 07:53 AM

Yes it is a bug. I will look into it.

FWIW, if you delete the file from within the Reports pane, it gets told about the delete and the old report is invalidated. By doing the delete in the BookBrowser instead, Qt must use signals to tell the Reports pane and sometimes that signal is not immediate. In general, deleting a file referenced in any report, the best practice is to rebuild the report as it will contain bad file references.

KevinH · 06-26-2018, 11:24 AM

Okay, I have a fix for this that I will push tonight once I am out of work.

Thanks for the bug report!

KevinH

KevinH · 06-26-2018, 06:55 PM

Fix was just pushed to master.

BeckyEbook · 06-27-2018, 03:11 AM

This problem is wider.
Also applies to files: AllFilesWidget.cpp (after removing the xhtml file, css or image), HTMLFilesWidget.cpp (after removing the xhtml file), CSSFilesWidget.cpp (css file) and maybe others.

KevinH · 06-27-2018, 07:10 AM

Yes, The Reports should have all been modal dialogs to prevent anything from being done behind the back of Reports. But people protested when I suggested that back in 2016. People should not be deleting files outside of Reports without rebuilding the reports themselves with the rebuild button.

I will try to fix things in a manner similar to my last fix.

Kevin

KevinH · 06-27-2018, 12:05 PM

Push additional fixes to master to handle AllFiles, CSSFiles, HTMLFiles, and ImageFiles Reports when deletes are made outside the report frameworks

DiapDealer · 06-27-2018, 12:05 PM

Quote:

Originally Posted by KevinH

Yes, The Reports should have all been modal dialogs to prevent anything from being done behind the back of Reports. But people protested when I suggested that back in 2016. People should not be deleting files outside of Reports without rebuilding the reports themselves with the rebuild button.

I agree. It never occurred to me that people would delete stuff with Reports open. I've always assumed people would rebuild new Reports after changes. If only Reports had been modal all along!

BetterRed · 06-27-2018, 08:51 PM

Can 'rebuilding the reports' be achieved by hitting the Refresh button?

KevinH · 06-27-2018, 10:28 PM

yes, that was the original reason for it as far as I can tell. My latest changes basically force the refresh with almost every interaction/sort in the Reports to prevent cashes

BetterRed · 06-27-2018, 11:02 PM

That 'splains why I never seen the problem. I always have the Reports window on top, and when I want to give it focus after editing, renaming etc, I usually do it by hitting Refresh.

I think I was one of those who didn't want Reports to go modal.

BR

theducks · 06-28-2018, 09:48 AM

Quote:

Originally Posted by BetterRed

I think I was one of those who didn't want Reports to go modal.

BR

Me too. (I also never tripped that bug)
Reports is a major part my working Fix it (cleanup) list.

I want to keep it open while I adjust the book.

Turtle91 · 06-28-2018, 06:14 PM

^^^^ +10

I like having the list of CSS in HTML to help find where there are classes that I'm not using. I double click on the offensive class - it opens the correct HTML file and I take corrective action. Then I go back to the still-open reports and click on the next one. PLEASE don't make it modal.

I have also had the problem with deleting images and not having the report updated causing crashes. I'm pretty sure there is a fairly recent thread about that around here. But knowing what the problem is, allows me to avoid the steps which cause the crash. If you use the reports window to do the deleting it should be fine.

06-27-2018, 03:11 AM	#5
BeckyEbook Guru Posts: 692 Karma: 2180740 Join Date: Jan 2017 Location: Poland Device: Misc	This problem is wider. Also applies to files: AllFilesWidget.cpp (after removing the xhtml file, css or image), HTMLFilesWidget.cpp (after removing the xhtml file), CSSFilesWidget.cpp (css file) and maybe others. Last edited by BeckyEbook; 06-27-2018 at 04:51 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Bug reports, and suchlike	ebooks-forum	Sigil	22	10-27-2017 02:41 PM
Writer2ePub bug reports	eBookLuke	Writer2ePub	102	07-28-2016 01:58 PM
Submitting bug reports	kguil	Marvin	6	07-09-2016 03:37 PM
Possible bug in editor (reports)	ratanplan	Editor	2	02-18-2015 06:22 AM
Firmware 3.5 Bug Reports	jackastor	Kobo Reader	18	08-12-2014 06:05 PM

06-26-2018, 07:53 AM	#2
KevinH Sigil Developer Posts: 7,644 Karma: 5433388 Join Date: Nov 2009 Device: many	Yes it is a bug. I will look into it. FWIW, if you delete the file from within the Reports pane, it gets told about the delete and the old report is invalidated. By doing the delete in the BookBrowser instead, Qt must use signals to tell the Reports pane and sometimes that signal is not immediate. In general, deleting a file referenced in any report, the best practice is to rebuild the report as it will contain bad file references.

06-26-2018, 11:24 AM	#3
KevinH Sigil Developer Posts: 7,644 Karma: 5433388 Join Date: Nov 2009 Device: many	Okay, I have a fix for this that I will push tonight once I am out of work. Thanks for the bug report! KevinH

06-26-2018, 06:55 PM	#4
KevinH Sigil Developer Posts: 7,644 Karma: 5433388 Join Date: Nov 2009 Device: many	Fix was just pushed to master.

06-27-2018, 07:10 AM	#6
KevinH Sigil Developer Posts: 7,644 Karma: 5433388 Join Date: Nov 2009 Device: many	Yes, The Reports should have all been modal dialogs to prevent anything from being done behind the back of Reports. But people protested when I suggested that back in 2016. People should not be deleting files outside of Reports without rebuilding the reports themselves with the rebuild button. I will try to fix things in a manner similar to my last fix. Kevin

06-27-2018, 12:05 PM	#7
KevinH Sigil Developer Posts: 7,644 Karma: 5433388 Join Date: Nov 2009 Device: many	Push additional fixes to master to handle AllFiles, CSSFiles, HTMLFiles, and ImageFiles Reports when deletes are made outside the report frameworks

06-27-2018, 08:51 PM	#9
BetterRed null operator (he/him) Posts: 20,567 Karma: 26954694 Join Date: Mar 2012 Location: Sydney Australia Device: none	Can 'rebuilding the reports' be achieved by hitting the Refresh button?

06-27-2018, 10:28 PM	#10
KevinH Sigil Developer Posts: 7,644 Karma: 5433388 Join Date: Nov 2009 Device: many	yes, that was the original reason for it as far as I can tell. My latest changes basically force the refresh with almost every interaction/sort in the Reports to prevent cashes

06-27-2018, 11:02 PM	#11
BetterRed null operator (he/him) Posts: 20,567 Karma: 26954694 Join Date: Mar 2012 Location: Sydney Australia Device: none	That 'splains why I never seen the problem. I always have the Reports window on top, and when I want to give it focus after editing, renaming etc, I usually do it by hitting Refresh. I think I was one of those who didn't want Reports to go modal. BR

06-28-2018, 06:14 PM	#13
Turtle91 A Hairy Wizard Posts: 3,094 Karma: 18727053 Join Date: Dec 2012 Location: Charleston, SC today Device: iPhone 11/X/6/iPad 1,2,Air & Air Pro/Surface Pro/Kindle PW & Fire	^^^^ +10 I like having the list of CSS in HTML to help find where there are classes that I'm not using. I double click on the offensive class - it opens the correct HTML file and I take corrective action. Then I go back to the still-open reports and click on the next one. PLEASE don't make it modal. I have also had the problem with deleting images and not having the report updated causing crashes. I'm pretty sure there is a fairly recent thread about that around here. But knowing what the problem is, allows me to avoid the steps which cause the crash. If you use the reports window to do the deleting it should be fine.