[FileType Plugin] GetFileName

[Terisa de morgan]

Originally Posted by Giuseppe Chillem

Hi Terisa,
there is a bug in your code.

Consider the following filename:

2008 - Handbook of Motivation Science - Shah, James & Gardner, Wendy L. (eds)-[Guilford].pdf

It is imported as:

filename: 2008 - Handbook of Motivation Science - Shah, James & Gardner, Wendy L
Extension: (eds)-[Guilford]

This other filename:

2009 - Building Motivational Interviewing Skills - David B. Rosengren.pdf

It is imported as:

filename: 2009 - Building Motivational Interviewing Skills - David B
extension: Rosengren

You are probably searching for the first DOT from the start of the filename, while you should search for the first DOT from the end of filename... or you are using a wrong regular expression.

Also, I see that the original extension as been truncated, so you are using some kind of code were you drop everything there is in the filename after the second dot and the second dot too...

I suppose today I have lost a lot of information while importing +3000 books
(261 book with wrong/partial information which I already have deleted )

Yes, you're right about the mistake, sorry.

[Terisa de morgan]

Originally Posted by Giuseppe Chillem

Hi,
a last problem:

Some books have the temp path as extracted path:

An example:
"C:\Users\Familia\AppData\Local\Temp\calibre_omm2o x\rsdo8k_add_books\482"

I'm afraid that it happens because all the books go through other file plugin (DeDrm?). That is something that cannot be avoided, sorry. I thought it was included in the initial notes but it isn't. I'll include it now.

[davidfor]

Originally Posted by Terisa de morgan

I'm afraid that it happens because all the books go through other file plugin (DeDrm?). That is something that cannot be avoided, sorry. I thought it was included in the initial notes but it isn't. I'll include it now.

Is there anyway to affect the order the plugins are called? If the GetFileName plugin could be called before the DRM stripping, it should get original file name. I have no idea what order is currently used. Installation or name order are the two obvious ones, but the might be something else.

[kovidgoyal]

https://github.com/kovidgoyal/calibr...f25f7b0e27f683

[Terisa de morgan]

Thank you, I'll make it available with this change after the next release (I hope).

[Giuseppe Chillem]

Originally Posted by Terisa de morgan

Yes, you're right about the mistake, sorry.

You have already been pardoned. Things like this happen when programming and now it was my turn to discover the bug !

[cgrapski]

For the life of me - I have never been able to figure out HOW to configure this. Nowhere is there any instructions on exactly WHAT kind of column to create or how it connects to the plugin.

I gave up - after the first week when it was first released. Figured I'd give it another try - and yet - still absolutely NO clue.

How do I configure the column?

[BetterRed]

@cgrapski - you need to add a custom column for each of the fields you want to use, the tooltips for each field tell you that - if you haven't added any suitable custom columns (text) then the drop downs will be empty.

Use Preferences->Add your own columns to add custom columns

Added : Heavens du Betzee - did you ever bother read through the thread, apparently not otherwise you would have tripped over post [27]

BR

[Terisa de morgan]

Originally Posted by kovidgoyal

https://github.com/kovidgoyal/calibr...f25f7b0e27f683

I'm having a problem with this code, but I don't know if it is related to the commit or I'm making a mistake in my plugin (the most probable situation). If I run my plugin "on import", so the method run is called and I can store "original_path_to_file", I'm losing the result of the previous plugin so, in my case, the book is not getting the DRM removed. I don't know if there is any mistake in the plugin, as it only returns the input path).

[kovidgoyal]

I dont see how that commit could cause an issue unless for some reason the DRM removal plugin uses the original_file_path property itself without first initializing it. Run calibre in debug mode and see what errors you get

calibre-debug -g

[Terisa de morgan]

Sorry, I'll try to explain myself better.

For getting original_path_to_file, I need the run method in my plugin to be called. So, because of this, now I have two file type plugins running on my file.

The first one makes its own process and returns a new file (with a new path). Now, the second one (my own) is called and it only stores the original path and returns the same path which has received.

In this situation, the book which is stored in calibre is not the modified one by the first plugin but the original one, as the second plugin does not receive as input the modified file but the original one, so each step loses the file returned by the previous plugin (or that is the effect I'm seeing).

[kovidgoyal]

Ah, this should take casre fo that: https://github.com/kovidgoyal/calibr...fedd81f4878a8c

[Terisa de morgan]

Thank you very much!

[Giuseppe Chillem]

Hi Terisa, hope you'll release a new version soon. My directories are waiting for you !

[Terisa de morgan]

I've to check a think this night and, according to that, I'll release it tomorrow... or after the next calibre release (because there was a bug that I detected testing the plugin).