[GUI Plugin] FanFicFare

[dakswiggin]

Hi

Today encountered download problem for single story on RR (using 3.25.8 version now):
For https://www.royalroad.com/fiction/26675 attempt to download story fails with

Spoiler:

FFF: INFO: 2020-11-23 14:34:21,172: calibre_plugins.fanficfare_plugin.jobs(53): FanFicFare v3.25.8

	FFF: INFO: 2020-11-23 14:34:21,173: calibre_plugins.fanficfare_plugin.jobs(57): Adding jobs for URLs:

	FFF: INFO: 2020-11-23 14:34:21,173: calibre_plugins.fanficfare_plugin.jobs(59): https://www.royalroad.com/fiction/26675

	FFF: INFO: 2020-11-23 14:34:23,933: calibre_plugins.fanficfare_plugin.jobs(95): Logfile for book ID 720 (A Journey of Black and Red)

	FFF: INFO: 2020-11-23 14:34:23,934: calibre_plugins.fanficfare_plugin.jobs(96): url:(https://www.royalroad.com/fiction/26675) id:(720)
	

	FFF: DEBUG: 2020-11-23 14:34:22,080: calibre_plugins.fanficfare_plugin.fanficfare.adapters.adapter_royalroadcom(151): URL: https://www.royalroad.com/fiction/26675
	

	FFF: DEBUG: 2020-11-23 14:34:22,080: calibre_plugins.fanficfare_plugin.fanficfare.configurable(1144): #####################################
	

	pagecache(GET) HIT: https://www.royalroad.com/fiction/26675
	

	FFF: DEBUG: 2020-11-23 14:34:22,081: calibre_plugins.fanficfare_plugin.fanficfare.configurable(1012): Encoding:utf8
	

	FFF: DEBUG: 2020-11-23 14:34:22,570: calibre_plugins.fanficfare_plugin.fanficfare.adapters.adapter_royalroadcom(223): stars:(4.72815)
	

	FFF: INFO: 2020-11-23 14:34:23,703: calibre_plugins.fanficfare_plugin.jobs(350): Exception: {'title': 'A Journey of Black and Red', 'author_sort': ['Mecanimus'], 'author': ['Mecanimus'], 'comments': '<div class="hidden-content">\n                <p>Where am I? What is this! I... I don\'t remember anything. I am in chains? Why am I in chains?! And why am I so very...</p>\n<p>Thirsty.</p>\n<p>\xa0</p>\n<p>\xa0</p>\n<p>This is a story of vampires as I believe they should be, with their strengths and weaknesses, with their remnants of humanity and the beast inside. Updates every Friday. Mind the tags.\xa0</p>\n<p>Cover by Antti Hakosaari:\xa0<a href="https://www.artstation.com/haco">https://www.artstation.com/haco</a></p>\n<p>Special thanks to Svensonsen for getting me started, as well as Omi Nya, Jemima, my patrons and you dear readers, for the support.</p>\n            </div>', 'good': False, 'status': 'Error', 'showerror': True, 'calibre_id': 720, 'begin': None, 'end': None, 'comment': "'src'", 'url': 'https://www.royalroad.com/fiction/26675', 'site': 'www.royalroad.com', 'series': '', 'added': False, 'pubdate': datetime.datetime(2019, 8, 16, 12, 34, 22, 558672, tzinfo=SafeLocalTimeZone()), 'publisher': 'www.royalroad.com', 'listorder': 0, 'collision': 'Update EPUB if New Chapters', 'uniqueurl': 'https://www.royalroad.com/fiction/26675[None-None]', 'is_adult': False, 'username': 'NoneGiven', 'password': '', 'icon': 'dialog_error.png', 'all_metadata': {'category': 'Original', 'genre': 'Action, Adventure, Fantasy, Female Lead, Historical, Urban Fantasy, Villainous Lead', 'characters': '', 'ships': '', 'warnings': 'Gore, Profanity, Sexual Content, Traumatising content', 'extratags': '', 'author': 'Mecanimus', 'authorId': '105290', 'authorUrl': 'https://www.royalroad.com/user/profile/105290', 'lastupdate': 'Last Update Year/Month: 2020/11, Last Update: 2020/11/23', 'series': '', 'seriesUrl': '', 'language': '', 'status': 'In-Progress', 'datePublished': '2019-08-16', 'dateUpdated': '2020-11-23', 'dateCreated': '2020-11-23 14:34:17', 'rating': '', 'numChapters': '90', 'numWords': '', 'words_added': '', 'site': 'www.royalroad.com', 'publisher': 'www.royalroad.com', 'storyId': '26675', 'title': 'A Journey of Black and Red', 'titleHTML': "<a class='titlelink' href='https://www.royalroad.com/fiction/26675'>A Journey of Black and Red</a>", 'storyUrl': 'https://www.royalroad.com/fiction/26675', 'sectionUrl': 'https://www.royalroad.com/fiction/26675', 'description': '<div class="hidden-content">\n                <p>Where am I? What is this! I... I don\'t remember anything. I am in chains? Why am I in chains?! And why am I so very...</p>\n<p>Thirsty.</p>\n<p>\xa0</p>\n<p>\xa0</p>\n<p>This is a story of vampires as I believe they should be, with their strengths and weaknesses, with their remnants of humanity and the beast inside. Updates every Friday. Mind the tags.\xa0</p>\n<p>Cover by Antti Hakosaari:\xa0<a href="https://www.artstation.com/haco">https://www.artstation.com/haco</a></p>\n<p>Special thanks to Svensonsen for getting me started, as well as Omi Nya, Jemima, my patrons and you dear readers, for the support.</p>\n            </div>', 'formatname': '', 'formatext': '', 'siteabbrev': 'rylrdl', 'version': 'FanFicFare v3.25.8', 'authorHTML': "<a class='authorlink' href='https://www.royalroad.com/user/profile/105290'>Mecanimus</a>", 'seriesHTML': '', 'langcode': '', 'output_css': '', 'cover_image': 'specific', 'stars': '4.72815'}, 'tags': ['Fantasy', 'Urban Fantasy', 'Original', 'In-Progress', 'Villainous Lead', 'Adventure', 'Historical', 'Female Lead', 'Action'], 'updatedate': datetime.datetime(2020, 11, 23, 5, 34, 22, 557671, tzinfo=SafeLocalTimeZone()), 'timestamp': datetime.datetime(2020, 11, 23, 14, 34, 22, 75626, tzinfo=SafeLocalTimeZone()), 'epub_for_update': 'C:\\Users\\Daks\\AppData\\Local\\Temp\\calibre_k77jn_fw\\fanficfare_p3qvc1k8\\old-720-8n7c2b8l.epub', 'calibre_columns': {}, 'outfile': 'C:\\Users\\Daks\\AppData\\Local\\Temp\\calibre_k77jn_fw\\fanficfare_p3qvc1k8\\A Journey of Black and Red-Mecanimus-uycg0tgf.epub'}:'src'
	

	Traceback (most recent call last):
	

	  File "calibre_plugins.fanficfare_plugin.jobs", line 271, in do_download_for_worker
	

	  File "calibre_plugins.fanficfare_plugin.fanficfare.epubutils", line 132, in get_update_data
	

	  File "bs4\element.py", line 1401, in __getitem__
	

	KeyError: 'src'
	

	

	FFF: INFO: 2020-11-23 14:34:23,934: calibre_plugins.fanficfare_plugin.jobs(100): 

	Download Results:

	Error https://www.royalroad.com/fiction/26675 'src'

	

	FFF: INFO: 2020-11-23 14:34:23,934: calibre_plugins.fanficfare_plugin.jobs(124): 

	Error

	https://www.royalroad.com/fiction/26675

[JimmXinu]

New Test Version Posted

2020-11-23
- Change convert_inline_images default to false.
- Fix http/https matching in identifiers:url search.
- Allow <img> tags without src attr in epub to update

Originally Posted by dakswiggin

Hi

Today encountered download problem for single story on RR (using 3.25.8 version now):
For https://www.royalroad.com/fiction/26675 attempt to download story fails with

That's caused by an <img> tag in chapter 22 not having a src attr. Which was fine on initial download, but FFF's epub updater didn't like it on update. Test version works for me.

[warkittens]

Upgraded all relevant plugins and now I can't make an anthology, it's not an option at all. Calibre 5.5, count pages 1.11.0, FFF 3.25.0, EPubMerge 2.11.0. Should I downgrade? Didn't notice anything posted where that isn't an option anymore. I'm a frontline healthcare worker and my brain is FRIED at the moment, so if I missed anything, please forgive me. I could miss a train in my living room at the moment.

I just noticed that it is under a submenu now. NEVER MIND. See also, fried brain from COVID work. Sorry to bother. Going to leave this up for anyone who also cannot find this option. I need a year's vacation after all this.

Just want to thank you for all the work you put in to this plugin. It is a lifesaver. Fic is keeping me as sane as possible right now.

[drea]

Originally Posted by JimmXinu

New Test Version Posted

2020-11-23
- Change convert_inline_images default to false.
- Fix http/https matching in identifiers:url search.
- Allow <img> tags without src attr in epub to update



That's caused by an <img> tag in chapter 22 not having a src attr. Which was fine on initial download, but FFF's epub updater didn't like it on update. Test version works for me.

Thank you. It also worked for similar "src" error for AO3

[ownedbycats]

Should dragging and dropping an email from Thunderbird onto the FFF button work? I can drag into the add URL dialog, and dragging from the browser works. Thank you.

[JimmXinu]

In theory, yes. But I have seen cases where TB doesn't work--I think for emails that it doesn't have local copies of?

[ownedbycats]

RSS feed. Before the Thunderbird drag and drop was fixed I did noticed the file path it dropped in was from the temp folder, as it had to copy the EML message out of the MSF files.

[ownedbycats]

Smallish bug:

FFNet fixed its cover images finally. I ran an "update ePub always/update ePub cover" on this.

However, I'm assuming due to the previous fix, it grabbed the smaller thumbnail instead of the full-size one. (URLs will get a 403 if you click directly, copy and paste.)

This is in spite of cover_min_size: 100,100.

I was also able to confirm with a few other fics. I didn't try downloading a new one.

Thank you.

[JimmXinu]

New Version Posted

2020-11-26
- Don't error on <img> w/o class in replace_failed_smilies_with_alt_textreplace_failed _smilies_with_alt_text
- Allow tab to leave edit boxes.
- Revert(ish) 'fix' for ffnet covers--they fixed it.

Yes, FFF stopped using the lazy image because it wasn't there and by the time we could tell, it was too late to switch.

[ownedbycats]

Thank you!

[AndersW]

I ran into a problem downloading a story from scribblehub.com that I can't link here because of the rating. The error I got was "maximum recursion depth exceeded in cmp". Would the title of the story work since I can't link it?

[ownedbycats]

@AndersW - if PMs are enabled for you, you could also PM the link to Jim.

[JimmXinu]

PM'ing me the link is the best option here. You can try posting the author and title here if you don't have PMs enabled yet.

I've had to travel suddenly; no idea how much time I'll have for this for the next week or so.

[ownedbycats]

Originally Posted by JimmXinu

I've had to travel suddenly;

Be careful!

[AndersW]

'The Vampire’s Templar' by TypeAxiom

I will also PM you the link. And stay safe out there.