117 crashes due to output format combo box

[ShellShock]

I really like the new Output format combo box - it is a really useful feature. However I get regular crashes when I focus onto the control. I'm trying to get a good repro but have yet to find a definite pattern.

[kovidgoyal]

Odd, are you running jobs when you do it?

[itimpi]

I am also finding that feature useful.

However I am not experiencing any issues when I select the Combo box whether or not I am running jobs. I am running on XP SP3 in case that matters.

[ShellShock]

I have been running jobs, but I've just tried it again and can't repro it. Is the combo meant to have a tool tip? Because I don't get one and I wonder if it is to do with that?

I'm on XP SP3 too (should have mentioned it before).

[kovidgoyal]

No it doesn't have a tooltip, so to be clear are you seeing crashes when you are running jobs or when you aren't or both? Try running calibre from the commandline with

calibre-debug -c "from calibre.gui2.main import main; main()"

ans see if there is any useful informaion output to the terminal after a crash

[ShellShock]

OK, this is my reliable repro:

Not running any jobs.

From the "Convert E-books" toolbar button, select the "Select defaults for conversion", click OK on the "Set conversion defaults" dialog, go to the Output combo and change the output format.

Repeat all the above. This crashes every time the second time I mouse over the combo box.

With the debug mode I got:

"link hasn't been detected!".

I ran calibre again without debug, and when it crashed I got an unhandled exception:

..\Objects\classobject.c:2230: bad argument to internal function
Detailed traceback:
Traceback (most recent call last):
  File "calibre\gui2\dialogs\jobs.pyo", line 54, in update_running_time
SystemError: ..\Objects\classobject.c:2230: bad argument to internal function

I thought I would attach a crash dump here but Windows has got a lock on the dmp file so I can't copy it!

[ShellShock]

While I have been playing around with the output format, I wonder as an enhancement, if it could be used to determine which format gets sent to the device? At the moment if I have both LRF and EPUB, then the LRF always gets sent to the device. The View button allows you to choose what format to view, but I can see how this is not really sensible for the Send button because all the existing send options would have to be doubled up.

The output combo wouldn't just control the output format, but also the primary format you are targetting, e.g., for viewing, sending etc.

I guess this is getting into re-design territory; at the moment the ebook is the first level item in calibre, whereas with the increasing number of formats and conversions it is supporting, then perhaps the first level item should be a particular format within an ebook. Then we could do things like convert from one arbitrary format to another (assuming the conversion was supported). So things like any2lit would be supported in the UI straight off.

[kovidgoyal]

The output combo does control everything except the preference order for books sent to the device.

[kovidgoyal]

Originally Posted by ShellShock

OK, this is my reliable repro:

Not running any jobs.

From the "Convert E-books" toolbar button, select the "Select defaults for conversion", click OK on the "Set conversion defaults" dialog, go to the Output combo and change the output format.

Repeat all the above. This crashes every time the second time I mouse over the combo box.

With the debug mode I got:

"link hasn't been detected!".

I ran calibre again without debug, and when it crashed I got an unhandled exception:

..\Objects\classobject.c:2230: bad argument to internal function
Detailed traceback:
Traceback (most recent call last):
  File "calibre\gui2\dialogs\jobs.pyo", line 54, in update_running_time
SystemError: ..\Objects\classobject.c:2230: bad argument to internal function

I thought I would attach a crash dump here but Windows has got a lock on the dmp file so I can't copy it!

Works for me on linux, unfortunately, I'm travelling and dont have access to a windows box, so can someone check this on windows

[itimpi]

With the exact sequence given it also crashes for me on XP SP3 the second time around.

It must be something to do with the fact you have gone to the Conversion Defaults dialog, as I had not been using that earlier and had been changing formats via the Combo box without any issues.

[kovidgoyal]

OK can one of you open a ticket, I'll look at it when I return from my travels

[itimpi]

Ticket raised.

Enjoy your travels