[Plugin] CustomCleanerPlus

[KevinH]

And I just noticed you had a similar error with this plugin earlier and DiapDealer gave you the solution then:

see https://www.mobileread.com/forums/sh...3&postcount=81
and the next post is your reply.

Same issue I think. Perhaps look for the latest version of that C runtime.

[DNSB]

I ran into an error trying to use CustomCleanerPlus on an epub 2.0 that has an .svg image file in the images directory:

Spoiler:

Status: failed

Python version:  3.9.9 (tags/v3.9.9:ccb0e6a, Nov 15 2021, 18:08:50) [MSC v.1929 64 bit (AMD64)] 

Running CustomCleanerPlus...

 -- Copy to work dir...cover.xhtml
 -- Copy to work dir...part0000.html
 -- Copy to work dir...part0001.html
 -- Copy to work dir...part0002.html
 -- Copy to work dir...part0003.html
 -- Copy to work dir...part0004.html
 -- Copy to work dir...part0005.html
 -- Copy to work dir...part0006.html
 -- Copy to work dir...part0007.html
 -- Copy to work dir...part0008.html
 -- Copy to work dir...part0009.html
 -- Copy to work dir...part0010.html
 -- Copy to work dir...part0011.html
 -- Copy to work dir...part0012.html
 -- Copy to work dir...part0013.html
 -- Copy to work dir...part0014.html
 -- Copy to work dir...part0015.html
 -- Copy to work dir...part0016.html
 -- Copy to work dir...part0017.html
 -- Copy to work dir...part0018.html
 -- Copy to work dir...part0019.html
 -- Copy to work dir...part0020.html
 
 -- Copy images to work dir...C:\Users\David\AppData\Local\Temp\tmpkt1j49b8\cover.jpeg
 -- Copy images to work dir...C:\Users\David\AppData\Local\Temp\tmpkt1j49b8\svgimg0003.svg
Traceback (most recent call last):
  File "C:\Program Files\Sigil\plugin_launchers\python\launcher.py", line 142, in launch
    self.exitcode = target_script.run(container)
  File "C:\Users\David\AppData\Local\sigil-ebook\sigil\plugins\CustomCleanerPlus\plugin.py", line 141, in run
    i_ids, i_fnames = copyImageFiles2Dir(bk, WDIR)          # copy epub images
  File "C:\Users\David\AppData\Local\sigil-ebook\sigil\plugins\CustomCleanerPlus\cutils2.py", line 163, in copyImageFiles2Dir
    outfp.write(data)
TypeError: a bytes-like object is required, not 'str'
Error: a bytes-like object is required, not 'str'

Deleting the svg image file allowed CustomCleanerPlus to run. However despite setting the Remove all hyphen class properties from the CSS, the webkit-hyphenate-limit-whatever lines survived.

[slowsmile]

@KevinH...Much thanks for that. I knew about the earlier occurrence of this same fault but I completely missed the solution by DiapDealer!

[slowsmile]

@DNSB...I think that you are probably using that svg image as a compound image saved in Sigil's Images dir. That's also probably why it needs to be read as bytes whereas jpg images are read in binary. I'll look into that problem now.

Regarding the failure of the Remove all hyphen class properties from the CSS option to remove all your hyphen properties -- could you please give me a list of all the hyphen class property names that you wish to remove so I can add them for removal in the plugin code? TIA.

[Leonatus]

@KevinH: Thanks for your investigative suggestions! My former problem had occurred on my old 32bit computer, but this time it's on my new 64bit. However, I installed the latest version of Visual C++, but the error message is still the same.
And: The python version is (and has always been) 32bit. Should I replace that by a 64bit version?

[KevinH]

The versions of Windows, Sigil, and Python (64 vs 32 bits) should always match when trying to make calls across dlls. Other setups are just more error prone trying to link the correct dll.

And did you try adding the exact version that DiapDealer recommended? The problem is that it is an old runtime library that newer computers do not have installed by default anymore.

[Leonatus]

I downloaded and installed the latest 64bit version, following DiapDealer's hints.

[slowsmile]

@Leonatus...In order to fix your problem using the Remove all hyphen class properties from the CSS option from my plugin, could you please send me a list of the hyphen class property names that were not removed when you ran my plugin? I can't fix that problem without that information.

[DNSB]

Originally Posted by slowsmile

@DNSB...I think that you are probably using that svg image as a compound image saved in Sigil's Images dir. That's also probably why it needs to be read as bytes whereas jpg images are read in binary. I'll look into that problem now.

Thanks for that.

Originally Posted by slowsmile

Regarding the failure of the Remove all hyphen class properties from the CSS option to remove all your hyphen properties -- could you please give me a list of all the hyphen class property names that you wish to remove so I can add them for removal in the plugin code? TIA.

Looking at 6 books, the only hypenate properties that survived were:

-webkit-hyphenate-limit-after: 4;
-webkit-hyphenate-limit-before: 4;
-webkit-hyphenate-limit-lines: 2;
-webkit-hyphenate-character:"\2010";

[slowsmile]

Update(v0.5.1):

• Fixed a copy SVG image file problem(thanks to @DNSB).
• Fixed a remove hyphen class properties problem(thanks to @DNSB).

Also added a warning in the plugin Release Notes to ensure that plugin users have the Microsoft Visual C++ Service Pack 1 already installed on their computer system before they run this plugin. Doing that will help to avoid any tidy.dll access errors in the future. At some point, I will also be looking at removing Tidy altogether from this plugin.

[DNSB]

Tested v0.5.1 on several epubs and the only issue I ran into was after using calibre's ModifyePub plugin to add a cover image. This adds a line in the cover xhtml file reading:

<meta content="true" name="calibre:cover"/>

When Remove all iss and associated links is checked, CustomCleanerPlus removes the 'name="calibre:cover"' which caused epubcheck to flag that line as an error.

[Leonatus]

@slowsmile: I don't know if it still matters, but in the epubs I tested there were no hyphen classes in the css at all that would have been an object for removal..

[Leonatus]

And I downloaded V. 0.5.1, but the issue remains.

[KevinH]

Are you using 64 bit version of python, 64 bit version of windows, and 64 bit version of tidy?

Are you sure you have all the runtime files and dlls that tidy needs on your new computer?

[Leonatus]

Well, as I said in #110, the python version is 32bit; that has worked without issues generally, although the OS being 64bit. And how to check the 64 or 32bit version of tidy, I ignore, and do not know if I have all the runtime files and dlls needed by tidy; I can only say that I installed the latest 64bit version of Visual C++.