Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Sigil

Notices

Reply
 
Thread Tools Search this Thread
Old 12-02-2015, 10:42 AM   #1
r2d256
Junior Member
r2d256 began at the beginning.
 
Posts: 8
Karma: 10
Join Date: Sep 2014
Device: none
Comparison Sigil 0.8.7 & Sigil 0.9.1

Comparison after adding existing files
Sigil 0.8.7
http://y27i.imgup.net/sigil_0_8_449c.jpg
Sigil 0.9.1
http://f58i.imgup.net/sigil0_9_1eb42.jpg
r2d256 is offline   Reply With Quote
Old 12-02-2015, 11:22 AM   #2
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 22,751
Karma: 127882912
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
A sample is worth a thousand pictures.

It's entirely possible that 0.8.7 was better at converting html5 input to xhtml than 0.9.1. Especially since 0.9.1 doesn't really try to.
DiapDealer is online now   Reply With Quote
Advert
Old 12-02-2015, 11:45 AM   #3
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,523
Karma: 2707438
Join Date: Nov 2009
Device: many
This is all caused by the html tag being wrong for epub.

In Sigil 0.8.7, since it has no epub3 support and it knew how to fix missing doctypes and missing attributes on the html header line ... in other words **always** set it for epub2.

Sigil 0.9.1 has started the process of epub3 support and can not guess when importing a single html page what doctype you truly wanted and what to add for the html tag attributes if the original you import do not specify them.

If you just pull in raw html that does not have the correct doctype and html attributes, this is what you will get. If you simply edit the doctype and html tag in Sigil-0.9.1, you will see the exact same output.

Sigil has no way of knowing if you are going to import html5 vs html4 vs html3.2, nor what target you are looking for epub3 vs epub2 if what you import does not provide a doctype and the required attributes on the html tags to tell it.

If this bothers enough people, we could always add a default to epub2 Preference setting so that the doctype and html attributes can always be fixed, or alternatively a plugin to fix and set this as epub2 for all xhtml files.

Exactly what DOCTYPE and html tag was provided on the original html file imported (or original epub imported)?

KevinH

Last edited by KevinH; 12-02-2015 at 12:36 PM.
KevinH is online now   Reply With Quote
Old 12-02-2015, 12:35 PM   #4
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,523
Karma: 2707438
Join Date: Nov 2009
Device: many
That DOCTYPE is okay for html5 in Sigil-0.9.1 and so the html tag is simply missing the xml namespace attribute to tell it how to interpret the xml. This is needed for Preview/BookView to interpret the file as xhtml not some dialect of html.

So edit the <html> tag and add the attribute:

xmlns="http://www.w3.org/1999/xhtml"

And you will see all appears as normal.

KevinH
KevinH is online now   Reply With Quote
Old 12-03-2015, 03:15 AM   #5
Doitsu
Wizard
Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.
 
Doitsu's Avatar
 
Posts: 4,996
Karma: 17038365
Join Date: Dec 2010
Device: Kindle PW2
It appears that there's folder normalization bug in Sigil 0.9.1: stylesheet links are no longer prefixed by ../Styles/.

I've attached a test case.

Steps to reproduce this issue:

1. Unpack the files and add blue.xhtml via Add existing file...

Result in 0.8.7:

Code:
<head>
<title/>
<link href="../Styles/Style0001.css" rel="stylesheet" type="text/css"/>
</head>
Result in 0.9.1:

Code:
<head>
<title/>
<link href="Style0001.css" rel="stylesheet" type="text/css"/>
</head>
Attached Files
File Type: zip blue.zip (1.1 KB, 47 views)

Last edited by Doitsu; 12-03-2015 at 03:17 AM.
Doitsu is offline   Reply With Quote
Advert
Old 12-03-2015, 03:59 AM   #6
rubeus
Banned
rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.rubeus ought to be getting tired of karma fortunes by now.
 
Posts: 272
Karma: 1224588
Join Date: Sep 2014
Device: Sony PRS 650
Hmmm i do not have an 0.8.7 any more, buit i would have expected that the link to the stylesheet is NOT updated as it is exactly already in blue.xhtml

What i didnt know that importing blue.xhtml will automatically add stylesheet.css as well... in that case as stylesheet.css is stored under styles i should have been corrected in blue.xhtml.
rubeus is offline   Reply With Quote
Old 12-03-2015, 05:48 AM   #7
Notjohn
mostly an observer
Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.Notjohn ought to be getting tired of karma fortunes by now.
 
Posts: 1,402
Karma: 987654
Join Date: Dec 2012
Device: Kindle
Quote:
Originally Posted by KevinH View Post
If this bothers enough people, we could always add a default to epub2 Preference setting so that the doctype and html attributes can always be fixed, or alternatively a plugin to fix and set this as epub2 for all xhtml files.

KevinH
I would like that, because opening raw html is exactly what I do, most of the time.

(They are usually *.HTM files, because I use a Dos text editor, but I seem to recall that it doesn't matter what the file is actually named.)
Notjohn is offline   Reply With Quote
Old 12-03-2015, 07:49 AM   #8
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 22,751
Karma: 127882912
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by Doitsu View Post
It appears that there's folder normalization bug in Sigil 0.9.1: stylesheet links are no longer prefixed by ../Styles/.

I've attached a test case.

Steps to reproduce this issue:

1. Unpack the files and add blue.xhtml via Add existing file...

Result in 0.8.7:

Code:
<head>
<title/>
<link href="../Styles/Style0001.css" rel="stylesheet" type="text/css"/>
</head>
Result in 0.9.1:

Code:
<head>
<title/>
<link href="Style0001.css" rel="stylesheet" type="text/css"/>
</head>
I see it.
Saving the epub and reopening it shows the txt/css link removed from the header.
DiapDealer is online now   Reply With Quote
Old 12-03-2015, 09:33 AM   #9
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,523
Karma: 2707438
Join Date: Nov 2009
Device: many
And the fix for this bug was just committed to master.

Thanks so much for the nice bug report Doitsu!

KevinH
KevinH is online now   Reply With Quote
Old 12-03-2015, 10:16 AM   #10
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 22,751
Karma: 127882912
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
I was investigating this morning. I'll have to check the commit and see if I was even looking in the right neighborhood.
DiapDealer is online now   Reply With Quote
Old 12-03-2015, 10:29 AM   #11
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,523
Karma: 2707438
Join Date: Nov 2009
Device: many
Hi DiapDealer,

In ImportHTML.cpp since Media file link updating worked, the issue had to be in how we handled stylesheet updating and by comparing the two pieces of code it was clear I simply made the update map key incorrect in the Stylesheet handling code. So the update was never made as it could not find the href to update. Since this was code I had already touched once it was easier for me to find.

Quote:
Originally Posted by DiapDealer View Post
I was investigating this morning. I'll have to check the commit and see if I was even looking in the right neighborhood.
KevinH is online now   Reply With Quote
Old 12-03-2015, 10:42 AM   #12
Doitsu
Wizard
Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.
 
Doitsu's Avatar
 
Posts: 4,996
Karma: 17038365
Join Date: Dec 2010
Device: Kindle PW2
Quote:
Originally Posted by KevinH View Post
And the fix for this bug was just committed to master.
I've just re-tested the issue with the latest files from master and the problem no longer occurs.



Will Windows users have to wait for Sigil 0.9.2 or are you planning on releasing a minor bug fix release?

Last edited by Doitsu; 12-03-2015 at 10:44 AM.
Doitsu is offline   Reply With Quote
Old 12-03-2015, 11:24 AM   #13
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,523
Karma: 2707438
Join Date: Nov 2009
Device: many
Doitsu - if you are building your own, there are a few other fixes you might want just committed.
KevinH is online now   Reply With Quote
Old 12-03-2015, 11:25 AM   #14
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,523
Karma: 2707438
Join Date: Nov 2009
Device: many
From the looks of things, we probably have enough bugs fixed to wait a week or to and then do a quick Sigil-0.9.2 bug fix only release (assuming DiapDealer has the free time to make the builds).
KevinH is online now   Reply With Quote
Old 12-03-2015, 01:00 PM   #15
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 22,751
Karma: 127882912
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
I shouldn't be pressed for time until closer to Christmas.
DiapDealer is online now   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Sigil-0.8.900 released for testing - Wait for Sigil-0.8.901 KevinH Sigil 106 10-04-2015 10:41 AM
Sigil on Nook vs Sigil on Kobo vs Sigil on iBook rosshalde Sigil 12 11-13-2014 09:34 AM
Comparison Sigil/ Indesign GraciousMe Sigil 13 11-15-2012 10:17 PM
Sigil 0.3.4 / Sigil 0.4.0 RC1 / Cover in Nook Color Bertrand Sigil 13 08-06-2011 04:06 AM
Sigil 0.3.4 / Problème CSS entre Sigil et iPad Grivels Software 10 07-03-2011 09:06 AM


All times are GMT -4. The time now is 10:15 AM.


MobileRead.com is a privately owned, operated and funded community.