Advice needed for plugin running background thread

[Phssthpok]

Originally Posted by kovidgoyal

The list of file types calibre adds is based on a user preference, the logic for getting that list is

        if gprefs['auto_add_everything']:
            self.allowed = AllAllowed()
        else:
            self.allowed = AUTO_ADDED - frozenset(gprefs['blocked_auto_formats'])

OK. That's somewhat less obvious than either I or eschwartz figured.

[Phssthpok]

Originally Posted by eschwartz

With the extra (wasted?) stat calls, you might actually lose time. I'm not sure if os.stat is faster than os.chmod, if not then you always lose.

My off-the-cuff guess would be that there won't be much difference since each disk block of a directory will contain several entries, so several directory updates will typically translate into a single disk write later on, which will be the main efficiency consideration. So yes, it sounds to me like an "always-lose" situation.

[Phssthpok]

Originally Posted by kovidgoyal

The list of file types calibre adds is based on a user preference, the logic for getting that list is

        if gprefs['auto_add_everything']:
            self.allowed = AllAllowed()
        else:
            self.allowed = AUTO_ADDED - frozenset(gprefs['blocked_auto_formats'])

And here we go again:

[eschwartz]

Originally Posted by Phssthpok

OK. That's somewhat less obvious than either I or eschwartz figured.

In self-defense I wrote all that from the hacked browser on my 6" Kindle Touch.
I figured there was probably an even better way, but without memorizing it beforehand... meh, it's enough to get the juice flowing.

(Yes, it is cramping my style a bit. )

[Phssthpok]

Originally Posted by kovidgoyal

The list of file types calibre adds is based on a user preference, the logic for getting that list is

        if gprefs['auto_add_everything']:
            self.allowed = AllAllowed()
        else:
            self.allowed = AUTO_ADDED - frozenset(gprefs['blocked_auto_formats'])

Kovid,
Perhaps if you have a spare minute you could encapsulate this in a method that I (or anyone else who might need it) can use, to avoid having to duplicate your code?

Thanks!

[kovidgoyal]

https://github.com/kovidgoyal/calibr...58e07734260c83

[Phssthpok]

Originally Posted by kovidgoyal

https://github.com/kovidgoyal/calibr...58e07734260c83

Thanks, as usual!

For anyone who cares: