Calibre 2.10, Plugins, Shortcuts and Dynamic Menus - Page 2

DiapDealer · 12-16-2014, 12:52 PM

OK. So it appears my editor plugin may be causing issues that this thread seems to touch upon (keyboard shortcuts). I'd like to fix it, but after some quick perusing of the various relevant threads linked to in this one, I feel I'm ill-equipped to tackle the problem. Most of what I'm seeing is "this plugin has the problem," and "that plugin has now been updated to fix/workaround the problem." But I still have no clear understanding of what the problem actually IS -- and could use a little help.

1) How does the problem manifest itself? What can I do to definitively confirm (by myself) that; "Yep. My code is silly buggers and needs work." ?

2) Where are the offensive lines of code in these plugins that "have it?" I'd rather not have to diff fixed versions of plugins whose codebase I'm entirely unfamiliar with against old broken versions to find what everyone else seems to already inherently "know" about this issue.

3) In words: what is the general goal that is causing problems and what was the general approach toward that goal that needs changing. What is the new preferred strategy (in words--or better yet--in line numbers of file X in plugin Y) of getting around the problem?

Have I mentioned that I hate keyboard shortcuts (other than ctrl-c|x|p)? Is there a way that I could fix the problem by just making it so my plugin can never have shortcuts assigned to it? That seems easier to me in the long run.

kovidgoyal · 12-16-2014, 09:43 PM

@DiapDealer: There is no problem with your editor plugin. Your editor plugin is currently preventing customization of keyboard shortcuts in the editor, but that is because of a bug in calibre code, which will be fixed in the next release.

This thread is relevant only to calibre plugins (that is plugins for the main program)

DiapDealer · 12-16-2014, 10:16 PM

Ah... I see. Thank you muchly, sir!

JimmXinu · 01-03-2015, 05:58 PM

I suggest that we can unstick this thread now.

theducks · 01-03-2015, 07:10 PM

Quote:

Originally Posted by JimmXinu

I suggest that we can unstick this thread now.

done

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Calibre keyboard shortcuts?	Clytie	Calibre	29	08-25-2019 03:51 AM
Certain keyboard shortcuts no longer working in Calibre 2.0 (OS X)	holymadness	Calibre	18	08-29-2014 01:33 PM
Keyboard shortcuts change for 0.8.14 - impact on plugins?	kiwidude	Development	37	09-24-2011 12:25 PM
Calibre server on DSL with dynamic IP	Hamlet53	Library Management	13	06-01-2011 10:23 AM
calibre internal reader - more keyboard shortcuts ?	cybmole	Calibre	1	01-06-2011 08:47 AM

12-16-2014, 12:52 PM	#16
DiapDealer Grand Sorcerer Posts: 27,552 Karma: 193191846 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	OK. So it appears my editor plugin may be causing issues that this thread seems to touch upon (keyboard shortcuts). I'd like to fix it, but after some quick perusing of the various relevant threads linked to in this one, I feel I'm ill-equipped to tackle the problem. Most of what I'm seeing is "this plugin has the problem," and "that plugin has now been updated to fix/workaround the problem." But I still have no clear understanding of what the problem actually IS -- and could use a little help. 1) How does the problem manifest itself? What can I do to definitively confirm (by myself) that; "Yep. My code is silly buggers and needs work." ? 2) Where are the offensive lines of code in these plugins that "have it?" I'd rather not have to diff fixed versions of plugins whose codebase I'm entirely unfamiliar with against old broken versions to find what everyone else seems to already inherently "know" about this issue. 3) In words: what is the general goal that is causing problems and what was the general approach toward that goal that needs changing. What is the new preferred strategy (in words--or better yet--in line numbers of file X in plugin Y) of getting around the problem? Have I mentioned that I hate keyboard shortcuts (other than ctrl-c\|x\|p)? Is there a way that I could fix the problem by just making it so my plugin can never have shortcuts assigned to it? That seems easier to me in the long run.

12-16-2014, 09:43 PM	#17
kovidgoyal creator of calibre Posts: 43,860 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	@DiapDealer: There is no problem with your editor plugin. Your editor plugin is currently preventing customization of keyboard shortcuts in the editor, but that is because of a bug in calibre code, which will be fixed in the next release. This thread is relevant only to calibre plugins (that is plugins for the main program)

12-16-2014, 10:16 PM	#18
DiapDealer Grand Sorcerer Posts: 27,552 Karma: 193191846 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Ah... I see. Thank you muchly, sir!

01-03-2015, 05:58 PM	#19
JimmXinu Plugin Developer Posts: 6,329 Karma: 3966249 Join Date: Dec 2011 Location: Midwest USA Device: Kindle Paperwhite(10th)	I suggest that we can unstick this thread now.

Advert

Advert