[Issue] Pretty Printing <mark>

[Tex2002ans]

<mark> is a new HTML5 element used for highlighting:

https://developer.mozilla.org/en-US/...L/Element/mark
https://www.w3.org/TR/html5/textleve...e-mark-element

<mark> is mostly used in-line. For example:

Spoiler:

<p>This is an example of <mark class="match">marked text</mark>.</p>

<p>And a “quote that is <mark>important</mark>.”</p>

After Pretty Printing in Sigil, each <mark> gets extra whitespace + placed on their own lines:

Spoiler:

  <p>This is an example of 

  <mark class="match">marked text</mark>

.</p>

  <p>And a “quote that is 

  <mark>important</mark>

.”</p>

In many cases, this extra whitespace can completely botch the spacing (especially around punctuation).

The actual display before Pretty Print:

This is an example of marked text.

And a “quote that is important.”

After Pretty Print:

This is an example of marked text .

And a “quote that is important .”

For Pretty Printing, <mark> should probably be treated just like a <b> or <i> tag.

[KevinH]

I will look into it.
Thanks.

[KevinH]

This should now be fixed in master. And yes handling mark like other inline tags was the answer.

Thank you for your bug report with explanatory links and testcase! It made things much easier to handle.

[Tex2002ans]

Originally Posted by KevinH

This should now be fixed in master. And yes handling mark like other inline tags was the answer.

Thank you for your bug report with explanatory links and testcase! It made things much easier to handle.

Also, this one is purely for aesthetics, but would it be possible to do a similar thing with Prettifying <td> + <th>?

Older versions of Sigil (forget which version) used to keep them "condensed":

2x6 Simple Table (Old Method):

This method was easily readable.

Note: I recreated the spacing off the top of my head. It was similar to this.

Spoiler:

  <table border="1">
    <tbody>
      <tr>
        <th colspan="2"><i>Proportion of age groups attending school</i></th>
      </tr>

      <tr>
        <th>Ages (years)</th>

        <th>Per cent attending</th>
      </tr>

      <tr>
        <td>10–14</td>

        <td>96</td>
      </tr>

      <tr>
        <td>15–17</td>

        <td>56</td>
      </tr>

      <tr>
        <td>18–20</td>

        <td>17</td>
      </tr>

      <tr>
        <td>21</td>

        <td>5</td>
      </tr>
    </tbody>
  </table>

2x6 Simple Table (New Method):

Spoiler:

  <table border="1">
    <tbody>
      <tr>
        <th colspan="2">
          <i>Proportion of age groups attending school</i>
        </th>
      </tr>

      <tr>
        <th>
          Ages (years)
        </th>

        <th>
          Per cent attending
        </th>
      </tr>

      <tr>
        <td>
          10–14
        </td>

        <td>
          96
        </td>
      </tr>

      <tr>
        <td>
          15–17
        </td>

        <td>
          56
        </td>
      </tr>

      <tr>
        <td>
          18–20
        </td>

        <td>
          17
        </td>
      </tr>

      <tr>
        <td>
          21
        </td>

        <td>
          5
        </td>
      </tr>
    </tbody>
  </table>

Even the most simple of tables explodes beyond a full screen length. And the way it is indented is much harder to figure out the values + what a table is doing just from the code.

[KevinH]

Pretty printing tables is hard to do and not easy to change in this case. As td and tr are not inline tags and are more like block tags and are currently treated that way, ie whitespace immediately before and after is ignored. I will look into this when I get more free time but no promises, as technically what is currently done is correct and a search and replace using regular expressions should be possible to change it to what you prefer.

[Turtle91]

Originally Posted by KevinH

Pretty printing tables is hard to do and not easy to change in this case. As td and tr are not inline tags and are more like block tags and are currently treated that way, ie whitespace immediately before and after is ignored. I will look into this when I get more free time but no promises, as technically what is currently done is correct and a search and replace using regular expressions should be possible to change it to what you prefer.

This^^. I have a saved search that condenses a table after I am done making sure it's good. Although I condense MUCH more than what you have.

Spoiler:

<table>
<tbody>
<tr><td>Yadda</td><td>Yadda</td><td>Yadda</td></tr>
<tr><td>Yadda</td><td>Yadda</td><td>Yadda</td></tr>
<tr><td>Yadda</td><td>Yadda</td><td>Yadda</td></tr>
</tbody>
</table>

I've attached the .ini if anyone wants to import it.