Korean text input issue

[BeckyEbook]

Originally Posted by KevinH

Problem B is strange too. Why is it rendered so faintly? Is it because it is rendering an incomplete "composing string"? Is the colour meant to indicate it is incomplete?

This is exactly what I believe.
It's greyed out because it's in composing mode. The same situation occurs when you use the ‘soft keyboard’, which is a virtual keyboard for typing Hangul characters.


But since Kovid somehow got around this, maybe it's worth asking him?

[DiapDealer]

Originally Posted by KevinH

@DiapDealer,
Can you recreate both problems A and B with your current setup?

I'm fairly confused on the particulars of the problem(s) actually. I don't really see what I would describe as characters being "composed". I press a key with the Korean IME active and a glyph shows up in Code View. The last character typed is always more difficult to see, but not what I would call terribly distracting. So I'm guessing that's what most are complaining about. But then I'm currently using Qt6.7.3, so I may be seeing something different. I'll try going back to the official Sigil 2.3.1 and see what it looks like.

[KevinH]

I just checked his code view equivalent python code and I can see nothing specific to IME use in any way. He does strongly set the entire colour pallet for the editor unlike us, as we follow Windows colours. Perhaps there is a Qt pallet colour set aside for this.

Update:
There really only is QPalette::Text, QPalette::BrightText and QPalette::WindowText. But there are InActive, and Disabled roles for them.

I wonder which role is being used to indicate an incomplete composing string exists?

[KevinH]

Okay I found the place in the Qt Windows specific code that sets the forground and background of the QInputMethodEvents:

It is here:

qtbase/src/plugins/platforms/windows
/qwindowsinputcontext.cpp

The code in question is this routine:

enum StandardFormat {
    PreeditFormat,
    SelectionFormat
};

static inline QTextFormat standardFormat(StandardFormat format)
{
    QTextCharFormat result;
    switch (format) {
    case PreeditFormat:
        result.setUnderlineStyle(QTextCharFormat::DashUnderline);
        break;
    case SelectionFormat: {
        // TODO: Should be that of the widget?
        const QPalette palette = QGuiApplication::palette();
        const QColor background = palette.text().color();
        result.setBackground(QBrush(background));
        result.setForeground(palette.window());
        break;
    }
    }
    return result;
}

But it makes no sense as it inverts the foreground and background colors and even adds an underline style.

What bothers me most is the ToDo comment ...

[KevinH]

If anyone can recreate this, I could add an InputMethodEvent handler to CodeView and I could dump the QInputMethodEvent event parameters including the final commit string, the preeditString, and all the QTextFormat values passed in for each so we can understand what format is being specified for each. This may help us understand why the oreeditString is being greyed out for Korean.

BTW, this problem (both A and B) can not happen on Mac OS or even Linux as far as I can tell as they never set a preeditString. So this is specific to Windows and the Qt Windows specific code.

Just let me know if anyine has time and I will throw something together.