Midori 0.5.5 - kindle RELEASE CANDIDATE 0.x

[twobob]

hmm.. not a raging success. I see one label :P

back to gtk2 - will investigate gtk3 "later"

[knc1]

Originally Posted by twobob

sed -i 's/O:R/O:U/g' ./midori/midori-view.c
sed -i 's/O:R/O:U/g' ./midori/main.c
sed -i 's/O:R/O:U/g' ./midori/midori-browser.c

let's try an upright build...

Well, seems like progress to me.

All of these have been only small skirmishes in the over-all war.

It seems you haven't yet met your:

[Aeris]

Originally Posted by twobob

hmm.. not a raging success. I see one label :P

back to gtk2 - will investigate gtk3 "later"

Don't hurry... is only a feature request above all, not a bug PS remember panic-screensaver for 0.4 so we can test without hesitations!

[twobob]

yah. I dug up the cause of the speed-dial death (thanks again <pfor>) basically in the /mnt/us/extensions/midori/usr/share/midori/res/speeddial-head.html it calls a javascript dialog box

which are by their very nature NON-TITLE aware...
sigh.

Think the speeddial will have to go for now, dug around for the last hour and found a few solutions. probably reworking to a modal-dialog would be a cheap solution.

for another day.

Hacking the defaults now to remove the speed-dial.

[Aeris]

Great work for today Twobob Thank you!

[twobob]

about:dial has been elided from /most/ places that I could find it now.

Will look to bundle after a clean rebuild.

Expect 0.4 RSN

[twobob]

Can I find where it invokes the file chooser with the name "Upload File"?
I can not.

it's not in the source code
http://svn.webkit.org/repository/web...serrequest.cpp

I have added a title adjustment after every file_chooser I could find.
still didnt fix it.

0x140015d "Upload File": ("midori_kindle" "Midori") 1740x1305+-491+-140 +-491+-140 MapState=IsViewable

scratches head

[baf]

Originally Posted by twobob

it calls a javascript dialog box

which are by their very nature NON-TITLE aware...

See how I solved it in SkipStone. You can connect to "script-alert" signal which is emitted by webkit when javascript calls window.alert. Same applies to prompt and confirm boxes.

[twobob]

Originally Posted by baf

See how I solved it in SkipStone. You can connect to "script-alert" signal which is emitted by webkit when javascript calls window.alert. Same applies to prompt and confirm boxes.

You really are very awesome.
I thank you for that.

Will check that out...

One thing I learned.
Debian DO post their build logs...
https://buildd.debian.org/status/fet...amp=1382044207 who knew?

[baf]

Originally Posted by twobob

Can I find where it invokes the file chooser with the name "Upload File"?
I can not.

it's not in the source code
http://svn.webkit.org/repository/web...serrequest.cpp

I have added a title adjustment after every file_chooser I could find.
still didnt fix it.

0x140015d "Upload File": ("midori_kindle" "Midori") 1740x1305+-491+-140 +-491+-140 MapState=IsViewable

scratches head

Are you using latest svn webkit? Similar gtk_file_chooser_dialog_new is in older versions, for example here.

[twobob]

Thanks baf. I have a very lot to learn.

Going to try rebuilding that from source I think then. Get us a few more HTML5 nice to haves (and try for the fast-mobile-scrolling thingy)

may be a complete disaster :P

CFLAGS="-march=armv7-a -mtune=cortex-a8 -mfpu=neon -ftree-vectorize -static-libstdc++ -O2 -pipe -fstack-protector -Wall -Wl,--as-needed -gstabs -ffast-math" CXXFLAGS="${CFLAGS}" CPPFLAGS="-D_FORTIFY_SOURCE=2" LDFLAGS="-Wl,-rpath,/mnt/us/extensions/midori/usr/lib -static-libstdc++ -Wl,-O1 -Wl,--no-keep-memory" ./configure --prefix=/mnt/us/extensions/midori/usr --disable-jit --disable-silent-rules --disable-schemas-compile --with-gtk=2.0 --disable-gtk-doc --enable-introspection --enable-fast-mobile-scrolling --enable-web-audio --enable-mhtml --disable-geolocation --enable-video-track --enable-image-resizer --with-target=x11 --disable-glibtest

[twobob]

Originally Posted by baf

See how I solved it in SkipStone. You can connect to "script-alert" signal which is emitted by webkit when javascript calls window.alert. Same applies to prompt and confirm boxes.

gboolean handle_script_alert(WebKitWebView *web_view, WebKitWebFrame *frame, gchar *message, SkipStone *skipstone)
{

   g_signal_connect(G_OBJECT(skipstone->embed), "script-alert", G_CALLBACK(handle_script_alert), skipstone);
   g_signal_connect(G_OBJECT(skipstone->embed), "script-confirm", G_CALLBACK(handle_script_confirm), skipstone);
   g_signal_connect(G_OBJECT(skipstone->embed), "script-prompt", G_CALLBACK(handle_script_prompt), skipstone);


  GtkWidget *dialog;
  D_ENTER;
  dialog = gtk_message_dialog_new(GTK_WINDOW(skipstone->window),
            GTK_DIALOG_DESTROY_WITH_PARENT,
            GTK_MESSAGE_INFO,
            GTK_BUTTONS_OK,
            message);
  gtk_window_set_title(GTK_WINDOW(dialog), KTITLE);
  gtk_window_set_position(GTK_WINDOW(dialog), GTK_WIN_POS_CENTER);
  gtk_dialog_run(GTK_DIALOG(dialog));
  gtk_widget_destroy(dialog);
  D_RETURN_(TRUE);
}

+gboolean handle_script_confirm(WebKitWebView *web_view, WebKitWebFrame *frame, gchar *message, gboolean **confirmed, SkipStone *skipstone)
{
  GtkWidget *dialog;
  D_ENTER;
  *confirmed = FALSE;
  dialog = gtk_message_dialog_new(GTK_WINDOW(skipstone->window),
            GTK_DIALOG_DESTROY_WITH_PARENT,
            GTK_MESSAGE_QUESTION,
            GTK_BUTTONS_OK_CANCEL,
            message);
  gtk_window_set_title(GTK_WINDOW(dialog), KTITLE);
  gtk_window_set_position(GTK_WINDOW(dialog), GTK_WIN_POS_CENTER);
  gint result = gtk_dialog_run(GTK_DIALOG(dialog));
  if(result == GTK_RESPONSE_OK)
    *confirmed = TRUE;
  gtk_widget_destroy(dialog);
  D_RETURN_(TRUE);
}

gboolean handle_script_prompt(WebKitWebView *web_view, WebKitWebFrame *frame, gchar *message, gchar *default_text, gchar **text, SkipStone *skipstone)
{
  GtkWidget *dialog;
  GtkWidget *entry, *message_area;
  D_ENTER;
  dialog = gtk_message_dialog_new(GTK_WINDOW(skipstone->window),
            GTK_DIALOG_DESTROY_WITH_PARENT,
            GTK_MESSAGE_QUESTION,
            GTK_BUTTONS_OK,
            message);
  gtk_window_set_title(GTK_WINDOW(dialog), KTITLE);
  gtk_window_set_position(GTK_WINDOW(dialog), GTK_WIN_POS_CENTER);
  message_area = gtk_dialog_get_content_area(GTK_DIALOG(dialog));
  entry = gtk_entry_new();
  gtk_entry_set_text(GTK_ENTRY(entry), default_text);
  gtk_widget_show(entry);
  gtk_container_add (GTK_CONTAINER (message_area), entry);
  gtk_dialog_run(GTK_DIALOG(dialog));
  *text = g_strdup(gtk_entry_get_text(GTK_ENTRY(entry)));
  gtk_widget_destroy(dialog);
  D_RETURN_(TRUE);
}

brilliant.

[twobob]

having difficulty with the libwebkitgtk build sadly.

perhaps we should

https://people.gnome.org/~federico/d...extensioniface

it's that, or figure out EXACTLY in midori where it is invoking the "unreferenced" call to the filechooser. Happy to take advice on how best to achieve that...

[brianinmaine]

why not lock down to /mnt/us ? thats all we need is that possible? or set HOME first to there then set lock to home?

[baf]

Originally Posted by twobob

it's that, or figure out EXACTLY in midori where it is invoking the "unreferenced" call to the filechooser. Happy to take advice on how best to achieve that...

It is invoked automatically when user clicks input button. You will not find reference to it in midori.
What you can do is to handle "run-file-chooser" signal in a custom function. See here.

BTW, I should also implement it in SkipStone

Regarding webkit build I only built Amazon version. Didn't try a modern one.