Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Calibre > Plugins

Notices

Reply
 
Thread Tools Search this Thread
Old 07-05-2018, 07:40 AM   #406
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 15,298
Karma: 24761108
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo: Touch, Glo, Aura H2O, Glo HD, Aura ONE, Clara HD
The problem is the title:

Quote:
The Admiral's Mark (Cotton Malone 0.5)
The plugin is expecting a hash character before the series index. It is expecting it to look like:

Quote:
The Admiral's Mark (Cotton Malone #0.5)
I'll have a look to fix it, but it will probably be sometime next week.
davidfor is offline   Reply With Quote
Old 07-07-2018, 04:42 AM   #407
Tijntje
Member
Tijntje began at the beginning.
 
Posts: 23
Karma: 10
Join Date: Nov 2012
Device: Kindle 3G
Quote:
Originally Posted by davidfor View Post
The problem is the title:



The plugin is expecting a hash character before the series index. It is expecting it to look like:



I'll have a look to fix it, but it will probably be sometime next week.
The weird thing is when I edit the title in Goodreads it does show the #
Tijntje is offline   Reply With Quote
Advert
Old 08-08-2018, 05:08 AM   #408
Iceybones
Junior Member
Iceybones began at the beginning.
 
Posts: 8
Karma: 10
Join Date: Aug 2018
Device: Kindle PW3
davidfor: Ok, so I fixed the issue where the ISBN doesn't get retrieved when Goodreads doesn't have an "Original Title" listed on line one of the book details. Also, now if the Goodreads id points to a kindle edition it retrieves the ASIN. Here is the code. For the worker:
https://hastebin.com/kiyukuzuxu.rb
And the config that adds the option to turn it on or off:
https://hastebin.com/kozabovoxu.rb

Last edited by Iceybones; 08-09-2018 at 09:52 AM.
Iceybones is offline   Reply With Quote
Old 08-18-2018, 10:59 AM   #409
saitoh183
Junior Member
saitoh183 began at the beginning.
 
Posts: 5
Karma: 10
Join Date: Aug 2018
Device: Kobo Glo
Fetch metadata via CLI

I wanted to know if it is possible to use this plugin via CLI. So far everything i have tried has no result. Im using a docker container that has calibre in it and i have no GUI. When i do the command here is what i get

Code:
./fetch-ebook-metadata -p Goodreads -o -v -t "The 12th Planet" -a "Zecharia Sitchin"
<calibre.utils.logging.ThreadSafeLog object at 0x7f38dc1e6950>
No results found
i Also tried dropping the json file i found on this thread into my plugin folder along side the Goodreads.zip but still no dice.
saitoh183 is offline   Reply With Quote
Old 08-19-2018, 02:15 AM   #410
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 15,298
Karma: 24761108
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo: Touch, Glo, Aura H2O, Glo HD, Aura ONE, Clara HD
Quote:
Originally Posted by saitoh183 View Post
I wanted to know if it is possible to use this plugin via CLI. So far everything i have tried has no result. Im using a docker container that has calibre in it and i have no GUI. When i do the command here is what i get

Code:
./fetch-ebook-metadata -p Goodreads -o -v -t "The 12th Planet" -a "Zecharia Sitchin"
<calibre.utils.logging.ThreadSafeLog object at 0x7f38dc1e6950>
No results found
i Also tried dropping the json file i found on this thread into my plugin folder along side the Goodreads.zip but still no dice.
It works here from the command line. But, that search doesn't work as the first match Goodreads finds is for a book with the title "The 12th Planet by Zecharia Sitchin Summary & Study Guide" by BookRags. The plugin rejects this as not close enough to the title and author that were searched for. The same will happen if you do the search using the calibre GUI.
davidfor is offline   Reply With Quote
Advert
Old 08-19-2018, 10:37 AM   #411
saitoh183
Junior Member
saitoh183 began at the beginning.
 
Posts: 5
Karma: 10
Join Date: Aug 2018
Device: Kobo Glo
Quote:
Originally Posted by davidfor View Post
It works here from the command line. But, that search doesn't work as the first match Goodreads finds is for a book with the title "The 12th Planet by Zecharia Sitchin Summary & Study Guide" by BookRags. The plugin rejects this as not close enough to the title and author that were searched for. The same will happen if you do the search using the calibre GUI.
ah ok so it is the string that is wrong
saitoh183 is offline   Reply With Quote
Old 08-19-2018, 08:09 PM   #412
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 15,298
Karma: 24761108
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo: Touch, Glo, Aura H2O, Glo HD, Aura ONE, Clara HD
Quote:
Originally Posted by saitoh183 View Post
ah ok so it is the string that is wrong
Yes. Unfortunately, the way the Goodreads search works is to use everything supplied as a single argument. That means it doesn't separate the author and title when searching. So, what it is finding in this case is probably the best match for the search. But, obviously not the correct book.

The plugin is only looking at the first result from the search. If I have time, I'll see if I can change it to look at the first few results. This should make it match the book in this case.
davidfor is offline   Reply With Quote
Old 08-19-2018, 10:11 PM   #413
saitoh183
Junior Member
saitoh183 began at the beginning.
 
Posts: 5
Karma: 10
Join Date: Aug 2018
Device: Kobo Glo
Cool looking forward to it. Thanks for the heads up about the search string because I'm in the process of creating a python post processing script for lazylibrarian and need to search for metadata from within the script.

Sent from my SM-G950W using Tapatalk
saitoh183 is offline   Reply With Quote
Old 08-26-2018, 07:08 PM   #414
jaslerx
Junior Member
jaslerx began at the beginning.
 
Posts: 2
Karma: 10
Join Date: Dec 2017
Device: iPad 4 (use calibre companion & Marvin3)
Not pulling series?

Anyone else having an issue with the scraper not pulling series metadata since Goodreads did a font change for the series on their site?
jaslerx is offline   Reply With Quote
Old 08-26-2018, 08:22 PM   #415
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 15,298
Karma: 24761108
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo: Touch, Glo, Aura H2O, Glo HD, Aura ONE, Clara HD
Quote:
Originally Posted by jaslerx View Post
Anyone else having an issue with the scraper not pulling series metadata since Goodreads did a font change for the series on their site?
No I hadn't, but there does look like a layout change, so it has probably broken the scraping for the series. I'll try and look at it tonight.
davidfor is offline   Reply With Quote
Old 08-27-2018, 09:35 AM   #416
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 15,298
Karma: 24761108
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo: Touch, Glo, Aura H2O, Glo HD, Aura ONE, Clara HD
Beta - Series changes

As @jaslerx reported, the series information has not been retrieved. This is because of a change in the layout of the book page with how the series information is displayed. And, amazingly, this change is for the better. It makes getting the title and the series information easier and less error prone. And it makes it possible to solve the problem @Tijntje reported earlier in the year.

Attached is a beta to fix this problem. Please test and report if there are any problems.

And while posting this, I realised I had completely forgotten about @Iceybones code for fetching the ASIN. I'll try and merge those changes later in the week week.
Attached Files
File Type: zip Goodreads-beta.zip (21.8 KB, 62 views)
davidfor is offline   Reply With Quote
Old 08-27-2018, 12:13 PM   #417
jaslerx
Junior Member
jaslerx began at the beginning.
 
Posts: 2
Karma: 10
Join Date: Dec 2017
Device: iPad 4 (use calibre companion & Marvin3)
The series scraping seems to be working - Thanks!
jaslerx is offline   Reply With Quote
Old 08-27-2018, 01:53 PM   #418
tilia
Evangelist
tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.tilia ought to be getting tired of karma fortunes by now.
 
tilia's Avatar
 
Posts: 432
Karma: 1720909
Join Date: Mar 2011
Device: Voyage, K3
The beta works for me too.
Thank you!
tilia is offline   Reply With Quote
Old 08-27-2018, 02:41 PM   #419
saitoh183
Junior Member
saitoh183 began at the beginning.
 
Posts: 5
Karma: 10
Join Date: Aug 2018
Device: Kobo Glo
Quote:
Originally Posted by davidfor View Post
Yes. Unfortunately, the way the Goodreads search works is to use everything supplied as a single argument. That means it doesn't separate the author and title when searching. So, what it is finding in this case is probably the best match for the search. But, obviously not the correct book.

The plugin is only looking at the first result from the search. If I have time, I'll see if I can change it to look at the first few results. This should make it match the book in this case.
@davidfor
Did this make it into the beta you posted?
saitoh183 is offline   Reply With Quote
Old 08-27-2018, 10:43 PM   #420
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 15,298
Karma: 24761108
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo: Touch, Glo, Aura H2O, Glo HD, Aura ONE, Clara HD
Quote:
Originally Posted by saitoh183 View Post
@davidfor
Did this make it into the beta you posted?
No. The changes in the beta are just "get it working again". I'll look at this with the other change.
davidfor is offline   Reply With Quote
Reply

Tags
goodreads, metadata

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[GUI Plugin] Goodreads Sync kiwidude Plugins 1159 10-02-2018 09:53 PM
[Metadata Download Plugin] Goodreads Metadata **Deprecated** kiwidude Plugins 30 04-23-2011 02:10 PM
[Covers Plugin] Goodreads Covers **Deprecated** kiwidude Plugins 13 04-17-2011 05:09 PM
metadata plugin redneck_momma Plugins 1 05-21-2010 08:41 PM


All times are GMT -4. The time now is 03:17 PM.


MobileRead.com is a privately owned, operated and funded community.