"Trim Image" bug and UNDO doesn't work

[paperback]

Linux Mint 20.1 / Calibre 5.35

Double click on an image file in the file browser. Then click on "Trim Image".

Expected result: A change to the cursor to indicate to the user that s/he is now in "crop" mode; and a message telling the user to select a "crop" region by dragging with the mouse.

Actual result: An error message telling the user s/he has to select the region first. But this is putting the cart before the horse; the user should be prompted instead (as explaine above).

To make things worse, UNDO does not work after this operation.

[JSWolf]

Originally Posted by paperback

Linux Mint 20.1 / Calibre 5.35

Double click on an image file in the file browser. Then click on "Trim Image".

Expected result: A change to the cursor to indicate to the user that s/he is now in "crop" mode; and a message telling the user to select a "crop" region by dragging with the mouse.

Actual result: An error message telling the user s/he has to select the region first. But this is putting the cart before the horse; the user should be prompted instead (as explaine above).

To make things worse, UNDO does not work after this operation.

Are you using Calibre downloaded directly from the Calibre website or did you use the repository? If you used the repository, it could be buggered. Get it from the Calibre website and you'll also get the latest version. Even if you got it from the Calibre website, update it to 5.38.

[paperback]

Unfortunately, it's still a bug in Calibre 5.38.

[lomkiri]

Calibre 5.99.8 (beta for the forthcoming 6.0), debian bullseye :

1) Really, we have to select the area before to click on trim button, but it seems to be a feature (1srt: select the region where the filter ('trim' or another one) will apply to / 2nd: select your filter) more than a bug. It may be surprising at first use, but once we know the process, no pain at all.

I prefer the present way, since when you release the mouse button after selecting, you are still able to redim the selection, and when you're ready, you click on "trim". The way you are proposing, you would have no chance to redim your selection.

2) undo is working okay here with Ctrl-Z, or with undo button on preview window, or with general undo on main toolbar.

[paperback]

1. If you use a crop feature in any graphics program, FIRST you click on the crop button (or use the equivalent keyboard or menu option), THEN you drag the mouse to enclose the selection.

2. After rechecking, I agree UNDO does work.

3. If, during selection, the cursor passes beyond the right-hand edge of the image, the selection can no longer be extended downwards; there needs to be a bit more leeway here.

[JSWolf]

Originally Posted by paperback

1. If you use a crop feature in any graphics program, FIRST you click on the crop button (or use the equivalent keyboard or menu option), THEN you drag the mouse to enclose the selection.

2. After rechecking, I agree UNDO does work.

3. If, during selection, the cursor passes beyond the right-hand edge of the image, the selection can no longer be extended downwards; there needs to be a bit more leeway here.

1. You select the area you want and then you click the trim button.

2. Undo never stopped working.

3. Just move the mouse pointer back on the image, select down as much as you want and then move to the right or left.

4. Trim and undo do work and have worked.

[davidfor]

Originally Posted by paperback

1. If you use a crop feature in any graphics program, FIRST you click on the crop button (or use the equivalent keyboard or menu option), THEN you drag the mouse to enclose the selection.

That isn't my experience. Some let you select the area you want to work on, then choose what you want to do with it. Others, you need to start the tool to make a change and then select what it is you are going to change.

[paperback]

Suggestion 1: To allow for the possibility of an accidental or faulty crop selection, allow the user to use ESC or UNDO to cancel the operation before clicking the "Trim Image" button.

Suggestion 2: Add a section on image editing to the user manual.