Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Sigil

Notices

Reply
 
Thread Tools Search this Thread
Old 01-14-2021, 05:40 PM   #76
Doitsu
Grand Sorcerer
Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.
 
Doitsu's Avatar
 
Posts: 5,127
Karma: 18492793
Join Date: Dec 2010
Device: Kindle PW2
You also might find the Blitz CSS template useful for testing purposes.
Doitsu is offline   Reply With Quote
Old 01-14-2021, 07:19 PM   #77
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,900
Karma: 3265462
Join Date: Nov 2009
Device: many
Interesting ...

FWIW, that stylesheet uses things beyond the css 3.0 spec including @supports like the following:

Code:
@supports (height: 100vh) {
  /* Can be used for containers and images 
     but Should be used in combination with .portrait if used for img */
  .h-100 {
    height: 99vh;
    /* Trying to avoid blank page after */
  }
  .h-90 {
    height: 90vh;
  }
  .h-80 {
    height: 80vh;
  }
  .h-70 {
    height: 70vh;
  }
  .h-60 {
    height: 60vh;
  }
  .h-50 {
    height: 50vh;
  }
  .h-40 {
    height: 40vh;
  }
  .h-30 {
    height: 30vh;
  }
  .h-20 {
    height: 20vh;
  }
  .h-10 {
    height: 10vh;
  }
}
@supports is still considered experimental.

I will have to add support for it to the cssparser as it only supports css 3.0.
KevinH is offline   Reply With Quote
Old 01-14-2021, 11:00 PM   #78
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,900
Karma: 3265462
Join Date: Nov 2009
Device: many
Okay it turned out to be easy to add @supports to qcssparser (and to fix a typo in nestlevels). These changes were pushed to master.
KevinH is offline   Reply With Quote
Old 01-15-2021, 03:42 PM   #79
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,900
Karma: 3265462
Join Date: Nov 2009
Device: many
Okay as of today's master in Sigil/src/Query:

- added a way to catch exceptions and report parser errors in the resulting CSelection so it can be checked by the caller (so hopefully no more aborts or segfaults)

- fixed a bug in the *of-type related selectors

- added support for :root pseudo selector

- added support for :lang() which properly groks inheritance rules.

- filtered out psuedoelements that do not actually help select a node or that require user intervention like :hover, :before, :after, etc

So hopefully Query is now in a much better place than it started.

It passes all my basic tests now but I am going to create a standalone testing app to stress test my version of gumbo query and remove the simple testing added to main.cpp in Sigil.

That will probably take a while but should prove useful in finding bugs and query limitations.

I have added @supports and fixed a few bugs in cssparser2 and qcssparser. If anyone wants me to post these improved versions, just let me know.



Quote:
Originally Posted by wrCisco View Post
I played a little with the Sigil/gumbo-query integration. Seems nice, but I got it to crash with a number of selectors:
Code:
p:nth-of-type(2n-1)
p:lang(it)
p.flush::first-letter
p:focus
I thought it could have a problem with pseudo classes with function-like syntax as
Code:
nth-of-type(2n-1)
but then I tried
Code:
:not(.someclass)
and not only it didn't cause a crash, but it also correctly found a match.
(and since ::first-letter and :focus will never match anything, it will be mostly a problem for the css parser to filter them out).

At the same time, just for the sake of it, I started experimenting with integrating the cssRemoveUnusedSelectors plugin in the Sigil reports tool. I succeeded in report back to the "CSS Classes" widget in the Reports dialog all the usages of the selectors (with the complete list of the number of matches per html file).
I'm not sure how best to proceed about the deletion functionality: I thought maybe keeping around the parsed css rules as PyObjectPtr when the selector usages are reported, and then passing it back to python to perform the deletion, would be a good approach (but how could I pass a PyObjectPtr to a python function through the embeddedpython::runInPython interface?). Or maybe it might be better to execute twice the parsing of the stylesheets - once for the reporting and once for the deletion - and to pass back and forth only the indices of the enumerated rules and selectors?
KevinH is offline   Reply With Quote
Old 01-19-2021, 05:58 PM   #80
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 4,900
Karma: 3265462
Join Date: Nov 2009
Device: many
Hi All,

I have assembled a decent Selector test set and found many bugs and created a number of fixes in the gumbo query code. I also made minor changes to the cssparser code.

To make these more generally available, I have created two new Sigil-Ebook github repos
with both source sets and reverted them to their original licenses so they can more easily exchange bug fixes and changes with their original projects.

cssparser
- Is now available at: https://github.com/Sigil-Ebook/cssparser
- It is now under its original LGPL v2.1 license

and

sigil-query
- It is now available at: https://github.com/Sigil-Ebook/sigil-query
- It is now under its original MIT License

Both are pure C++ that does not need or use Qt.
KevinH is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
alphabetizing stylesheet, check book, and remove unused styles rjwse@aol.com Calibre 9 01-29-2020 07:48 PM
Pseudo classes to be deleted as unused classes Leonatus Sigil 2 09-23-2018 10:12 AM
"unused stylesheet class" is actually used AlanHK Sigil 6 06-20-2017 05:42 PM
Search and Replace; delete "author" name from "serie" roosten Library Management 6 12-17-2015 12:38 PM
Cleaning a stylesheet of unused styles roger64 Sigil 49 06-13-2012 06:23 AM


All times are GMT -4. The time now is 12:10 PM.


MobileRead.com is a privately owned, operated and funded community.