"Delete unused stylesheet classes" problems with overloaded styles

[Doitsu]

You also might find the Blitz CSS template useful for testing purposes.

[KevinH]

Interesting ...

FWIW, that stylesheet uses things beyond the css 3.0 spec including @supports like the following:

@supports (height: 100vh) {
  /* Can be used for containers and images 
     but Should be used in combination with .portrait if used for img */
  .h-100 {
    height: 99vh;
    /* Trying to avoid blank page after */
  }
  .h-90 {
    height: 90vh;
  }
  .h-80 {
    height: 80vh;
  }
  .h-70 {
    height: 70vh;
  }
  .h-60 {
    height: 60vh;
  }
  .h-50 {
    height: 50vh;
  }
  .h-40 {
    height: 40vh;
  }
  .h-30 {
    height: 30vh;
  }
  .h-20 {
    height: 20vh;
  }
  .h-10 {
    height: 10vh;
  }
}

@supports is still considered experimental.

I will have to add support for it to the cssparser as it only supports css 3.0.

[KevinH]

Okay it turned out to be easy to add @supports to qcssparser (and to fix a typo in nestlevels). These changes were pushed to master.

[KevinH]

Okay as of today's master in Sigil/src/Query:

- added a way to catch exceptions and report parser errors in the resulting CSelection so it can be checked by the caller (so hopefully no more aborts or segfaults)

- fixed a bug in the *of-type related selectors

- added support for :root pseudo selector

- added support for :lang() which properly groks inheritance rules.

- filtered out psuedoelements that do not actually help select a node or that require user intervention like :hover, :before, :after, etc

So hopefully Query is now in a much better place than it started.

It passes all my basic tests now but I am going to create a standalone testing app to stress test my version of gumbo query and remove the simple testing added to main.cpp in Sigil.

That will probably take a while but should prove useful in finding bugs and query limitations.

I have added @supports and fixed a few bugs in cssparser2 and qcssparser. If anyone wants me to post these improved versions, just let me know.

Originally Posted by wrCisco

I played a little with the Sigil/gumbo-query integration. Seems nice, but I got it to crash with a number of selectors:

p:nth-of-type(2n-1)
p:lang(it)
p.flush::first-letter
p:focus

I thought it could have a problem with pseudo classes with function-like syntax as

nth-of-type(2n-1)

but then I tried

:not(.someclass)

and not only it didn't cause a crash, but it also correctly found a match.
(and since ::first-letter and :focus will never match anything, it will be mostly a problem for the css parser to filter them out).

At the same time, just for the sake of it, I started experimenting with integrating the cssRemoveUnusedSelectors plugin in the Sigil reports tool. I succeeded in report back to the "CSS Classes" widget in the Reports dialog all the usages of the selectors (with the complete list of the number of matches per html file).
I'm not sure how best to proceed about the deletion functionality: I thought maybe keeping around the parsed css rules as PyObjectPtr when the selector usages are reported, and then passing it back to python to perform the deletion, would be a good approach (but how could I pass a PyObjectPtr to a python function through the embeddedpython::runInPython interface?). Or maybe it might be better to execute twice the parsing of the stylesheets - once for the reporting and once for the deletion - and to pass back and forth only the indices of the enumerated rules and selectors?

[KevinH]

Hi All,

I have assembled a decent Selector test set and found many bugs and created a number of fixes in the gumbo query code. I also made minor changes to the cssparser code.

To make these more generally available, I have created two new Sigil-Ebook github repos
with both source sets and reverted them to their original licenses so they can more easily exchange bug fixes and changes with their original projects.

cssparser
- Is now available at: https://github.com/Sigil-Ebook/cssparser
- It is now under its original LGPL v2.1 license

and

sigil-query
- It is now available at: https://github.com/Sigil-Ebook/sigil-query
- It is now under its original MIT License

Both are pure C++ that does not need or use Qt.