[GUI Plugin] Job Spy

[BetterRed]

Originally Posted by BetterRed

https:// urls with spaces i.e '%20' aren't working in beta 3, or in beta 2

BR

I'm not sure URL encoding ever worked in web links (http and https), very few of the web urls I have in LT columns need any encoding, just happened to stumble on one today.

BR

[DaltonST]

Originally Posted by BetterRed

I'm not sure URL encoding ever worked in web links (http and https), very few of the web urls I have in LT columns need any encoding, just happened to stumble on one today.

BR

Your test data that I used:


#~ url = 'file:///X:%5CMyPluginsPy3%5C_ris_import_dir%5Cabstract.txt '
#~ url = "file:///D:/Calibre/Libraries/Default/!Attachments/book%20%5B30%5D/"
#~ url = "file:///D:/Calibre/Libraries/Default/!Attachments/book%20(30)"
#~ url = "file:///D:/Calibre/Libraries/Default/!Attachments/book%2030/"


example: book%20%5B30%5D decodes as: book [30]


That still works for files. I haven't touched that code since the first test version that had it. I will confirm the same is true for non-files.

NV handles these (the paste messed with the column/header alignment):

       #~ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
        #~ newline ........................    space        "         %         -           .           <         >         \             ^       _             `           {           |           }            ~
        #~ %0A or %0D or %0D%0A     %20     %22     %25     %2D     %2E     %3C     %3E     %5C     %5E     %5F     %60     %7B     %7C     %7D     %7E
        #~ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
        #~ !             #           $           &         '         (                )       *         +           ,           /             :           ;         =           ?         @        [                ]
        #~ %21     %23     %24     %26     %27     %28     %29     %2A     %2B     %2C     %2F     %3A     %3B     %3D     %3F     %40     %5B     %5D
        #~ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

DaltonST

[DaltonST]

Originally Posted by DaltonST

Your test data that I used:


#~ url = 'file:///X:%5CMyPluginsPy3%5C_ris_import_dir%5Cabstract.txt '
#~ url = "file:///D:/Calibre/Libraries/Default/!Attachments/book%20%5B30%5D/"
#~ url = "file:///D:/Calibre/Libraries/Default/!Attachments/book%20(30)"
#~ url = "file:///D:/Calibre/Libraries/Default/!Attachments/book%2030/"


example: book%20%5B30%5D decodes as: book [30]


That still works for files. I haven't touched that code since the first test version that had it. I will confirm the same is true for non-files.

NV handles these (the paste messed with the column/header alignment):

       #~ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
        #~ newline ........................    space        "         %         -           .           <         >         \             ^       _             `           {           |           }            ~
        #~ %0A or %0D or %0D%0A     %20     %22     %25     %2D     %2E     %3C     %3E     %5C     %5E     %5F     %60     %7B     %7C     %7D     %7E
        #~ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
        #~ !             #           $           &         '         (                )       *         +           ,           /             :           ;         =           ?         @        [                ]
        #~ %21     %23     %24     %26     %27     %28     %29     %2A     %2B     %2C     %2F     %3A     %3B     %3D     %3F     %40     %5B     %5D
        #~ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

DaltonST

Okay, for https, there was a bug. Everything possible uses the url decoding logic now.


Beta #4 posted with the others: https://www.mobileread.com/forums/sh...4&postcount=18



DaltonST

[BetterRed]

file:/// links with URL encoding are fine, I just checked a few.

It was an https:// URL with a space in the address, NV fired up Edge with a truncated address, calibre Book Details fired up Edge with the full address.

BR

[DaltonST]

Originally Posted by BetterRed

file:/// links with URL encoding are fine, I just checked a few.

It was an https:// URL with a space in the address, NV fired up Edge with a truncated address, calibre Book Details fired up Edge with the full address.

BR

Yep. see: https://www.mobileread.com/forums/sh...4&postcount=18

[BetterRed]

We x-posted.

Originally Posted by DaltonST

Okay, for https, there was a bug. Everything possible uses the url decoding logic now.

Yep, all good

Another advantage of having two NV windows open is to copy and paste between them to achieve consistent styling.

BR

[DaltonST]

Version 1.0.235 -2023-04-21 Notes Viewer: decode url encoding; multiple instances of Notes Viewer as a new option; Minimum Calibre Version 6.15.

Refer to the attached image that explains the new NV option for multiple instances.


DaltonST

[BetterRed]

file:\\\ links to a folder aren't working:

calibre, version 6.16.0
Notes Viewer: File or Directory in url does not exist in stated path: D:/Calibre/Libraries/Test/Anat Admati/The Bankers' New Clothes (159)/data/")

This is the HTML code:

<p><a href="file:///D:/Calibre/Libraries/Test/Anat%20Admati/The%20Bankers'%20New%20Clothes%20(159)/data/"><span style="color: #9e7852">Attachments</span></a></p></div>

I'm sure they were working in a prior release.

BR

[DaltonST]

Originally Posted by BetterRed

file:\\\ links to a folder aren't working:


This is the HTML code:

<p><a href="file:///D:/Calibre/Libraries/Test/Anat%20Admati/The%20Bankers'%20New%20Clothes%20(159)/data/"><span style="color: #9e7852">Attachments</span></a></p></div>

I'm sure they were working in a prior release.

BR

You never gave me any test data with not only double-quotes, but also a lone single quote: Bankers' . If it had been url encoded as Bankers%27, it would have worked.

I really need you to run that example in calibre-debug -g and post the log. I cannot do it because I don't have any file paths even remotely like that. Using your log, I can determine exactly how to do what needs to be done. I get Python syntax errors even trying to hardcode a test url with that value without doing crazy things, and that isn't 'real-life' testing.

Thanks.

DaltonST

[BetterRed]

The HTML comes from NV Edit->Create Link->Browse tool.

The link works on the Book Details panel



I'll post the log in a few minutes.

BR

[BetterRed]

Here you go.

My prior usage would have had simple path names: e.g.

D:\Calibre\Libraries\Test\!Attachments\[159] something simple

BR

[BetterRed]

Change of topic : request for additional per-library tweak:

The Clicking on author names should: setting in Preferences->Look & Feel->Book Details.

BR

[DaltonST]

Originally Posted by BetterRed

Here you go.

My prior usage would have had simple path names: e.g.

D:\Calibre\Libraries\Test\!Attachments\[159] something simple

BR

I was just about to release the next version (without these last tweaks) when you posted your error.

Your file url error was caused by Qt creating QUrls differently based on whether there is a grammatical ' or not. If there is, it surrounds the url with double quotes. If there is not, which is what I had previously tested ad nauseam, it surrounds the url with single quotes. NV handled the latter case, but not the former, causing a bad path error in Windows. As I mentioned earlier, it was the Banker's single quote that broke it, because Qt used double quotes instead of single quotes.

Maybe you will find some really good new combinations that will be tested.


DaltonST

[BetterRed]

Originally Posted by DaltonST

Okay. See the testing .zip attached.

I was just about to release it (without these last tweaks) when you posted your error. The release notes were:
Notes Viewer: Search Results are converted from HTML and Markdown to Plain text before being "snipped" to less than 100 characters, including spaces. The removal of the markup tags makes sorting by Snippets useful.

Your file url error was caused by Qt creating QUrls differently based on whether there is a grammatical ' or not. If there is, it surrounds the url with double quotes. If there is not, which is what I had previously tested ad nauseam, it surrounds the url with single quotes. NV handled the latter case, but not the former, causing a bad path error in Windows. As I mentioned earlier, it was the Banker's single quote that broke it, because Qt used double quotes instead of single quotes.

Maybe you will find some really good new combinations that will be tested.

All good

I won't be looking for any new combinations, good or bad

BR

[DaltonST]

Version 1.0.236 -2023-04-22 Notes Viewer: Search Results are converted from HTML and Markdown to Plain text before being "snipped" to less than 100 characters, including spaces. The removal of the markup tags makes sorting by Snippets useful.

Job Spy has certain other GUI Tools that now require minimum Calibre version 6.15.


DaltonST