Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Calibre > Plugins

Notices

Reply
 
Thread Tools Search this Thread
Old 09-03-2017, 06:56 PM   #766
BetterRed
null operator
BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.
 
Posts: 9,194
Karma: 7797387
Join Date: Mar 2012
Location: Sydney Australia
Device: none
Quote:
Originally Posted by davidfor View Post
BR, I'd say you are right. The RL plugin shows the books in a list by marking them and then showing the marked books. The marks stay on the books until something removes them. It's a little untidy, but I haven't seen that it cause any problems. It's been like that for as long as the plugin existed. I'd say it will stay like that until someone demonstrates it breaks something, or they fix the code themselves.
It looks like RL establishes the Marks (pins) when an RL is listed, which makes sense, because you can have multiple RLs. They're easily cleared with Mark books->Clear marked books.

Maybe the Marks (pins) could be cleared when the RL search. e.g. marked:reading_list_books2Edit, is 'dismissed'; can a plugin get a callback from the Clear current search event?

FD is different, it establishes the Marks (pins) for exempted books when a library is opened. And it uses the the "marked" column dynamically to create the duplicate book groups. When Kovid implemented Mark books as a User feature, I looked at FD to see if I could move the marking of exemptions from library open to some other event, but I discovered FD uses the "marked" column for various (nefarious ) purposes, so I gave it a miss.

BR
BetterRed is offline   Reply With Quote
Advert
Old 09-03-2017, 09:29 PM   #767
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 13,299
Karma: 21339822
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo: Touch, Glo, Aura H2O, Glo HD, Aura ONE
Quote:
Originally Posted by BetterRed View Post
It looks like RL establishes the Marks (pins) when an RL is listed, which makes sense, because you can have multiple RLs. They're easily cleared with Mark books->Clear marked books.

Maybe the Marks (pins) could be cleared when the RL search. e.g. marked:reading_list_books2Edit, is 'dismissed'; can a plugin get a callback from the Clear current search event?
I'm pretty sure there isn't a way to do this. And it is such a harmless side-affect, and the work around is simple enough that I don't see any point in doing anything about it.
davidfor is offline   Reply With Quote
Old 09-03-2017, 09:54 PM   #768
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 13,299
Karma: 21339822
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo: Touch, Glo, Aura H2O, Glo HD, Aura ONE
Quote:
Originally Posted by JSWolf View Post
It's the same issue as the Count Pages plugin not updating the book details after a count was done/updated. Nothing was causing an error. It was just a slight annoyance. Same thing here.
Except that if anyone did the count and it wasn't updated, then they would think something was wrong and possibly redo the count before realising what had happened. And I fixed it when I was in that area of the code doing something else.

For the RL, not unmarking the books is a small visual problem that doesn't harm anything. And if there is a bug, it is that when moving away from the RL view, the marks aren't cleared, not that they aren't cleared when the books are removed from the list. If it really bugs you, I suggest that you do the fix yourself.
davidfor is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[GUI Plugin] Extract ISBN kiwidude Plugins 323 10-20-2017 06:27 AM
[GUI Plugin] Open With kiwidude Plugins 328 08-21-2017 12:34 AM
[GUI Plugin] Manage Sony x50 Reader Book List kpw Plugins 170 10-02-2014 09:23 PM
[GUI Plugin] Temp Marker kiwidude Plugins 41 10-14-2013 01:25 AM
[GUI Plugin] Plugin Updater **Deprecated** kiwidude Plugins 159 06-19-2011 01:27 PM


All times are GMT -4. The time now is 10:59 PM.


MobileRead.com is a privately owned, operated and funded community.