11-17-2017, 10:20 AM | #16 |
Grand Sorcerer
Posts: 11,741
Karma: 6997045
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
Damn. I just ran with the new commit and I *can't* remove the new shortcut. If it stays like this then I will do the tweak to get rid of it.
|
11-17-2017, 10:53 AM | #17 | |
creator of calibre
Posts: 43,858
Karma: 22666666
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
Quote:
And I agree, there are no consistent standards for the usage of Enter or pretty much for anything at all in the UI world. But since Enter does nothing currently (and cannot be uused as a normal shortcut), having it launch the viewer instead is relatively harmless. |
|
Advert | |
|
11-17-2017, 12:18 PM | #18 |
Grand Sorcerer
Posts: 11,741
Karma: 6997045
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
I pushed code for the tweak. The choices are
Code:
'viewer': open the book in the viewer, 'down_arrow': perform a down arrow, 'edit_metadata': open the edit metadata (single) dialog, 'do_nothing': makes the key do nothing. I tested it on windows 10 in both the grid and list views. Last edited by chaley; 11-17-2017 at 12:23 PM. |
11-17-2017, 02:47 PM | #19 |
null operator (he/him)
Posts: 20,569
Karma: 26954694
Join Date: Mar 2012
Location: Sydney Australia
Device: none
|
BR |
11-17-2017, 04:32 PM | #20 | ||
Grand Sorcerer
Posts: 11,741
Karma: 6997045
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
Quote:
Quote:
Your "behavior" is one reason that I would prefer the default behavior is to do nothing, which is what calibre does today. I have similar cases where I hit return by accident (or by muscle memory). Opening a viewer is a large price to pay for the mistake. On the other hand, as long as we can turn it off then we pay the price only once or twice. |
||
Advert | |
|
11-17-2017, 04:37 PM | #21 | |
Grand Sorcerer
Posts: 6,233
Karma: 11768331
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
Quote:
|
|
11-17-2017, 04:39 PM | #22 |
Grand Sorcerer
Posts: 11,741
Karma: 6997045
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
|
11-17-2017, 04:49 PM | #23 |
Grand Sorcerer
Posts: 6,233
Karma: 11768331
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
|
11-17-2017, 05:20 PM | #24 | |
null operator (he/him)
Posts: 20,569
Karma: 26954694
Join Date: Mar 2012
Location: Sydney Australia
Device: none
|
Quote:
IMO any changes to keyboard or mouse click behaviour, should try to avoid changing current behaviours. And, if there's any tweaking to be done, it should be done by the users who want the change, not the users who happy with the status quo. One reasons I use View format, is that it makes easy for me to select (via the keyboard) something other than the OS default program to open a format file. Some of my default programs are video editors, which are often busy for long periods. I rarely edit the videos stored a calibre library, I normally do it before they are added to the library, or I copy them into a editing project folder and work on them there. BR |
|
11-17-2017, 06:37 PM | #25 | |
....
Posts: 1,547
Karma: 18068960
Join Date: May 2012
Device: ....
|
Quote:
Besides, despite the OP's claims that users do not understand, I don't recall any significant number of requests for clarification on how to view books in these forums (I cannot recall any). If the OP was to be believed it would seem to me these forums would be full of people asking how to open a book. So is it not a problem and the only problem around being how to turn it into a problem? |
|
11-17-2017, 08:20 PM | #26 | |
Grand Sorcerer
Posts: 24,907
Karma: 47303748
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
|
Quote:
In any case, thanks to you and Kovid for the update. |
|
11-18-2017, 04:55 AM | #27 | ||
Grand Sorcerer
Posts: 11,741
Karma: 6997045
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
The (modified) changes I submitted are now in the official source. Kovid accepted 3 of the possibilities: 'open_viewer', 'edit_metadata', and 'do_nothing', removed 'down_arrow', and added 'edit_cell'.
The tweak documentation is: Quote:
Quote:
|
||
11-18-2017, 05:28 AM | #28 |
Grand Sorcerer
Posts: 6,233
Karma: 11768331
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
Thank your very much, I'll check them with the new calibre release.
|
11-18-2017, 05:39 AM | #29 |
null operator (he/him)
Posts: 20,569
Karma: 26954694
Join Date: Mar 2012
Location: Sydney Australia
Device: none
|
Will F2 continue to function as 'open current cell for editing', and will Tab/BackTab continue to function as 'end current cell edit, and open next/previous cell for edit'.
It's not clear to me why F2 works as it does, its not a regular shortcut, nor as far as I can determine, a tweak of any kind. But I'd hate for it (and Tab/Backtab) to stop working as they do now. I've tweaked other programs to be consistent with calibre's use of F2. It's probably too late and maybe not possible anyway, but in IMO the upgrade should set the 'enter_key_behaviour' to current value of 'doubleclick_on_library_view' - for me that's 'do_nothing'. BR Last edited by BetterRed; 11-18-2017 at 05:44 AM. |
11-18-2017, 06:04 AM | #30 | |||
Grand Sorcerer
Posts: 11,741
Karma: 6997045
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
Quote:
Quote:
Quote:
FWIW: making the default value of tweak A be the current value of tweak B probably would never happen. The structure for such a thing is not currently built into the tweak system. FWIW**2: edit_metadata works both with single and multiple. If you select multiple lines then hit enter, edit bulk starts. If you select one line (the default), edit single starts. |
|||
Tags |
library, open book |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Feature request: Previous/Next Book | Katsunami | Editor | 5 | 11-11-2014 10:22 PM |
Feature Request: Book #s for Book Sets Within a Series | dclewis | Marvin | 0 | 09-23-2014 11:22 PM |
Indesign 8.0.1 Update (Do not translate carriage return to nbsp in EPUB export) WHY?? | ebookn00b | ePub | 7 | 12-17-2012 07:54 AM |
Feature request: Different language = Different book | enriquep | Calibre | 0 | 03-24-2012 01:43 PM |
Search and replace - carriage return | ayjay3 | Sigil | 1 | 11-22-2011 02:32 PM |