Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Calibre > Plugins

Notices

Reply
 
Thread Tools Search this Thread
Old 02-11-2020, 12:36 PM   #1336
shadowdance
Junior Member
shadowdance began at the beginning.
 
Posts: 3
Karma: 10
Join Date: Feb 2020
Device: kindle PW Gen10
i have actually no idea if that is a "good" or "proper" way, but after digging, i found a fix for me:

Code:
diff core.py core_orig.py 
219d218
<         request_token = {key.decode('utf-8'): value.decode('utf-8') for (key, value) in request_token.items()}
230d228
<         access_token= {key.decode('utf-8'): value.decode('utf-8') for (key, value) in access_token.items()}
shadowdance is offline   Reply With Quote
Old 02-11-2020, 08:09 PM   #1337
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 18,597
Karma: 30757200
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by shadowdance View Post
hi,
new user of the plugin here..

When i try to authorize the plugin, I get above error...


Code:
calibre, version 4.99.4
ERROR: Unhandled exception: <b>KeyError</b>:'oauth_token'

calibre 4.99.4  embedded-python: False is64bit: True
Linux-5.4.17-towo.1-siduction-amd64-x86_64-with-debian-bullseye-sid Linux ('64bit', 'ELF')
('Linux', '5.4.17-towo.1-siduction-amd64', '#1 SMP PREEMPT siduction 5.4-17 (2020-02-03)')
Python 3.7.6
Linux: ('debian', 'bullseye/sid', '')
Interface language: None
Successfully initialized third party plugins: BOL_DE (0, 9, 0) && Goodreads Sync (1, 14, 1)
Traceback (most recent call last):
  File "calibre_plugins.goodreads_sync.config", line 1118, in authorize_plugin
  File "calibre_plugins.goodreads_sync.core", line 219, in get_request_token_secret
KeyError: 'oauth_token'
Any ideas on what i can do to fix that (apart learning python)?
I have to admit I haven't tried that with the Python 3 version of calibre. I will tonight.

But, did the GR page get displayed? And did you allow access from plugin? Not doing the latter would give an error, though it should get caught. Could you run calibre in debug mode and post or PM me the log? The logs will show details of the communications with GR and I should be able to see the issue.
davidfor is online now   Reply With Quote
Old 02-11-2020, 08:20 PM   #1338
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 18,597
Karma: 30757200
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by shadowdance View Post
i have actually no idea if that is a "good" or "proper" way, but after digging, i found a fix for me:

Code:
diff core.py core_orig.py 
219d218
<         request_token = {key.decode('utf-8'): value.decode('utf-8') for (key, value) in request_token.items()}
230d228
<         access_token= {key.decode('utf-8'): value.decode('utf-8') for (key, value) in access_token.items()}
Woops, didn't see the extra post on the next page.

That looks like another difference in how the different Python versions handle strings. I'll look at whether that is the right way to handle it.
davidfor is online now   Reply With Quote
Old 02-12-2020, 07:59 AM   #1339
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 18,597
Karma: 30757200
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by shadowdance View Post
i have actually no idea if that is a "good" or "proper" way, but after digging, i found a fix for me:

Code:
diff core.py core_orig.py 
219d218
<         request_token = {key.decode('utf-8'): value.decode('utf-8') for (key, value) in request_token.items()}
230d228
<         access_token= {key.decode('utf-8'): value.decode('utf-8') for (key, value) in access_token.items()}
I have implemented a fix based on this. I have asked for the release version to be updated with this.
davidfor is online now   Reply With Quote
Old 02-12-2020, 06:43 PM   #1340
shadowdance
Junior Member
shadowdance began at the beginning.
 
Posts: 3
Karma: 10
Join Date: Feb 2020
Device: kindle PW Gen10
Quote:
Originally Posted by davidfor View Post
I have implemented a fix based on this. I have asked for the release version to be updated with this.
wow - that was quick!
thank you!

it does work with the new version 1.14.2
shadowdance is offline   Reply With Quote
Old 03-01-2020, 09:34 AM   #1341
Orz
Junior Member
Orz began at the beginning.
 
Posts: 1
Karma: 10
Join Date: Mar 2020
Location: Canada
Device: Kindle Oasis 3
Lightbulb Amazon ASIN support?

My primary source for books is Amazon. Kindle books from Amazon do not have ISBNs, and Goodreads can work much better with Amazon's ASIN when searching and matching, etc.

When performing a batch search, I find that the plugin never matches anything automatically. I had to manually search and select for thousands of books. Is it possible to support or default to using ASIN as the relational database primary key?

Also, it would be really helpful to support "fuzzy search" when matching Goodreads books to Calibre books, then just present a table of fuzzy searched results for confirmation if it can have secondary options in a dropdown menu, that would be even better.

Orz is offline   Reply With Quote
Old 03-01-2020, 07:03 PM   #1342
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 18,597
Karma: 30757200
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by Orz View Post
My primary source for books is Amazon. Kindle books from Amazon do not have ISBNs, and Goodreads can work much better with Amazon's ASIN when searching and matching, etc.

When performing a batch search, I find that the plugin never matches anything automatically. I had to manually search and select for thousands of books. Is it possible to support or default to using ASIN as the relational database primary key?

Also, it would be really helpful to support "fuzzy search" when matching Goodreads books to Calibre books, then just present a table of fuzzy searched results for confirmation if it can have secondary options in a dropdown menu, that would be even better.
For most book matching, I recommend using the metadata download, and the Goodreads metadata source plugin. That can match on ASIN as well as ISBN and author/title.

Adding ASIN matching here would be possible. But, it would mean duplicating code from the metadata source plugin. And that means maintaining it in two places. I don't really see an advantage in doing it this way, so I don't really think it is worth the extra work.
davidfor is online now   Reply With Quote
Reply

Tags
calibre, goodreads

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[GUI Plugin] Clipboard Search kiwidude Plugins 17 Today 03:07 AM
[GUI Plugin] Search the Internet kiwidude Plugins 319 12-18-2019 03:20 PM
[GUI Plugin] Open With kiwidude Plugins 336 09-11-2019 08:54 PM
[GUI Plugin] Quick Preferences kiwidude Plugins 33 06-20-2018 03:00 AM
[GUI Plugin] Book Sync **Deprecated** kiwidude Plugins 111 06-07-2011 07:47 PM


All times are GMT -4. The time now is 05:18 AM.


MobileRead.com is a privately owned, operated and funded community.