PocketBook-KOReader: a document reader for PDF, DJVU, EPUB, FB2, CBZ, ... (AGPLv3)

[kaznelson]

Originally Posted by NiLuJe

Are we talking the angle at which point horizontal becomes a diagonal? I would assume 45°
In any case, hope you like trig: https://github.com/koreader/koreader....lua#L307-L337

I made these sectors: 15°*2 for vertical swipe, 15° for diagonal swipe, and 60°*2 for horizontal swipe.
Please tell me, is it possible to do this with user patch?

Spoiler:

--[[--
Compares `current_tev` with `initial_tev`.

The first boolean argument `simple` results in only four directions if true.

@return (direction, distance) pan direction and distance
--]]
function Contact:getPath(simple, diagonal, initial_tev)
    initial_tev = initial_tev or self.initial_tev

    local x_diff = self.current_tev.x - initial_tev.x
    local y_diff = self.current_tev.y - initial_tev.y
    local direction = nil
    local distance = math.sqrt(x_diff*x_diff + y_diff*y_diff)
    if x_diff ~= 0 or y_diff ~= 0 then
        local v_direction = y_diff < 0 and "north" or "south"
        local h_direction = x_diff < 0 and "west" or "east"
        if (not simple
            and math.abs(y_diff) > 1.732*math.abs(x_diff)
            and math.abs(y_diff) < 3.732*math.abs(x_diff))
           or (simple and diagonal)
        then
            direction = v_direction .. h_direction
        elseif (math.abs(x_diff) > 0.577*math.abs(y_diff)) then
            direction = h_direction
        else
            direction = v_direction
        end
    end
    return direction, distance
end

[NiLuJe]

You'll have to ask someone actually fluent in trigonometry, that's not me .

[kaznelson]

Originally Posted by NiLuJe

You'll have to ask someone actually fluent in trigonometry, that's not me

Trigonometry? I understand her... a little
But I don't know how to make a user-patch...

...
        if (not simple
            and math.abs(y_diff) > 1.732*math.abs(x_diff)  <===
            and math.abs(y_diff) < 3.732*math.abs(x_diff)) <===
           or (simple and diagonal)
        then
            direction = v_direction .. h_direction
        elseif (math.abs(x_diff) > 0.577*math.abs(y_diff)) then <===
            direction = h_direction
...

[NiLuJe]

See https://github.com/koreader/koreader/wiki/User-patches

You'll basically just want to replace the whole function with your tweaked variant.

[NiLuJe]

I'd forgotten a key implementation detail that would have made a patch require some fun low-level Lua shenanigans, and @poire-z caught it and went the extra mile: https://github.com/koreader/koreader...ent-1509160619 .

[kaznelson]

NiLuJe
Thanks, it works!
https://github.com/koreader/koreader...ent-1509696330

[kaznelson]

Please tell me about paging: in which lua-file can I increase the minimum swipe distance?
When I hold the e-book by the bottom edge with my thumb and flip through the pages not with the tip, but with tap the entire phalanx of my finger - and such a tap is regularly perceived by KOReader as a back-swipe (or a call to bottom menu, also assigned to a swipe)...

[NiLuJe]

I'd first double-check how your input device is actually reporting that, as it's not uncommon for some to do completely wonky shit if they're not designed to deal with that properly (which, on Linux, would be reporting a single touch event with auxiliary info indicating a larger oval shape for the contact) .

But to answer your actual question: https://github.com/koreader/koreader...ector.lua#L117

[kaznelson]

Thanks, I'll try experimenting with this value!

Problem with PocketBook's is that when touch-screen goes to sleep, touches on the screen are not perceived well - gesture must be very explicit. Quick and "weightless" gestures are usually perceived as a simple tap; while a single, but "smeared" tap - like a swipe.
My finger touches the screen gradually, from left to right - this is probably what confuses the e-book...

[kaznelson]

Originally Posted by NiLuJe

But to answer your actual question: https://github.com/koreader/koreader...ector.lua#L117

And how to change the swipe distance with a user-patch? It doesn't work:

local GestureDetector = require("device/gesturedetector")

GestureDetector.init = function()
    self.PAN_THRESHOLD = self.screen:scaleByDPI(70)
end

[NiLuJe]

Don't overwrite `GestureDetector.init`, just `GestureDetector.PAN_THRESHOLD` .

(And if you need access to Screen, either go at it via Device, or via `GestureDetector.screen`. All the input classes are singletons).

(And in a patch with a prefix >= 2, IIRC).

[kaznelson]

Originally Posted by NiLuJe

Don't overwrite `GestureDetector.init`, just `GestureDetector.PAN_THRESHOLD`

Also doesn't work:

local GestureDetector = require("device/gesturedetector")
GestureDetector.PAN_THRESHOLD = GestureDetector.screen:scaleByDPI(70)

Thank you anyway.
It's too difficult for me, I'll edit `gesturedetector.lua` directly...

[Michal Jancik]

Wow! I am really surprised how reactive and fast my pocketbook is after the last update!

I don't know what changes have taken place, but after the last update I see a big acceleration both in menu navigation and in various settings.

Device on which I use Koreader: Pocketbook Inkapd 3 (V740)
The acceleration is so great that it has reached the level of reactivity on the same level as the significantly more powerful "Tolino Vision 6" device.

I thank the developers for the work done, really bravo guys..
thanks to this new version, using my Pocketbook (which is not exactly one of the fastest) will be more pleasant.

[conquerli]

My device is Pocketbook InkPad Color (PB742) with the OS is Android.
Should I follow this thread or thread for android?

Tks.

[pazos]

Originally Posted by conquerli

My device is Pocketbook InkPad Color (PB742) with the OS is Android.
Should I follow this thread or thread for android?

Tks.

The android thread and the android install instructions -> https://github.com/koreader/koreader...ndroid-devices