Attn plugin devs: porting to python 3 - Page 9

eschwartz · 05-21-2020, 10:33 AM

"if we have function inside the library"

No mention of templates there, so I did have to guess...

Terisa de morgan · 05-21-2020, 11:52 AM

Quote:

Originally Posted by eschwartz

"if we have function inside the library"

No mention of templates there, so I did have to guess...

Sorry, I'm not good explaining in my language, you can guess in another one

Yes, I define functions in the template section, as I feel more comfortable with them than template mode. In any case, it looks like some function has disappeared

(Yes, you can see them with calibre / python2 but not with calibre / python3)

Edit: Found the problem, python3 doesn't like "<>", it prefers "!=". In any case, the function has disappeared silently... No warning to the user...

kovidgoyal · 05-21-2020, 11:54 AM

Run calibre in debug mode and you will probably get a traceback telling you why the function could not be loaded.

eschwartz · 05-21-2020, 12:23 PM

Quote:

Originally Posted by Terisa de morgan

Edit: Found the problem, python3 doesn't like "<>", it prefers "!=". In any case, the function has disappeared silently... No warning to the user...

I feel mildly shocked to discover real use of <> in the wild, TBH.

Though you could fix this by using:

Code:

$ python3
>>> from __future__ import barry_as_FLUFL
>>> 2 != 3
  File "<stdin>", line 1
    2 != 3
       ^
SyntaxError: with Barry as BDFL, use '<>' instead of '!='

Terisa de morgan · 05-21-2020, 12:55 PM

Quote:

Originally Posted by kovidgoyal

Run calibre in debug mode and you will probably get a traceback telling you why the function could not be loaded.

No, it's not very informative. In any case, if you don't run it in debug mode, you'll only get the information when the column that uses it fails.

Quote:

Originally Posted by eschwartz

I feel mildly shocked to discover real use of <> in the wild, TBH.

Though you could fix this by using:

Code:

$ python3
>>> from __future__ import barry_as_FLUFL
>>> 2 != 3
  File "<stdin>", line 1
    2 != 3
       ^
SyntaxError: with Barry as BDFL, use '<>' instead of '!='

I've already done the change, python-modernize has done it, being honest. And why is "<>" so shocking?

chaley · 05-21-2020, 12:57 PM

Quote:

Originally Posted by kovidgoyal

Run calibre in debug mode and you will probably get a traceback telling you why the function could not be loaded.

Yes, you do, but it doesn't help much with finding the exact problem. I can't add a gui error box because the template function compiler is used in command line mode, but I can probably add a print that provides the name of the function with the error.

JSWolf · 05-21-2020, 01:08 PM

once Python Modify is run, is there any other changes that might have to be made or is that it done and the Python 2 code is now compatible with Python 2 and 3?

chaley · 05-21-2020, 01:15 PM

Quote:

Originally Posted by chaley

... but I can probably add a print that provides the name of the function with the error.

I committed changes to show the name of the function failing to compile and to eliminate the unneeded stack trace lines.

Note that you must run calibre in debug mode to see these messages. No way I know of to get around that.

Terisa de morgan · 05-21-2020, 01:32 PM

Thank you. I think that, if somebody defines python template functions, she will be able to run calibre in debug mode

kovidgoyal · 06-16-2020, 01:31 AM

Released 4.99.6 with all changes from mainline and also updated Qt to 14.2. Note that the windows code signing key was renewed, so you might get warnings from SmartScreen about unknown software.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Plugin Devs: Should we include a License or COPYING file?	KevinH	Plugins	3	08-15-2017 01:09 PM
Attn plugin developers: calibre moving to Qt 5	kovidgoyal	Plugins	157	01-01-2015 11:22 PM
Can I develop a plugin in a launguage other than Python?	jamawg	Development	2	06-13-2014 12:38 AM
Calibre in a Python 3.2 world, attn: Kovid	Kevin McAleavey	Calibre	8	01-09-2012 05:49 PM
How do I Create a Python Plugin?	Sydney's Mom	Plugins	25	01-27-2010 06:26 AM

05-21-2020, 10:33 AM	#121
eschwartz Ex-Helpdesk Junkie Posts: 19,422 Karma: 85397180 Join Date: Nov 2012 Location: The Beaten Path, USA, Roundworld, This Side of Infinity Device: Kindle Touch fw5.3.7 (Wifi only)	"if we have function inside the library" No mention of templates there, so I did have to guess...

05-21-2020, 11:54 AM	#123
kovidgoyal creator of calibre Posts: 43,850 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Run calibre in debug mode and you will probably get a traceback telling you why the function could not be loaded.

05-21-2020, 01:08 PM	#127
JSWolf Resident Curmudgeon Posts: 73,938 Karma: 128903250 Join Date: Nov 2006 Location: Roslindale, Massachusetts Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3	once Python Modify is run, is there any other changes that might have to be made or is that it done and the Python 2 code is now compatible with Python 2 and 3?

05-21-2020, 01:32 PM	#129
Terisa de morgan Grand Sorcerer Posts: 6,233 Karma: 11768331 Join Date: Jun 2009 Location: Madrid, Spain Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2	Thank you. I think that, if somebody defines python template functions, she will be able to run calibre in debug mode

06-16-2020, 01:31 AM	#130
kovidgoyal creator of calibre Posts: 43,850 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Released 4.99.6 with all changes from mainline and also updated Qt to 14.2. Note that the windows code signing key was renewed, so you might get warnings from SmartScreen about unknown software.

Advert

Advert