Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > KOReader

Notices

Reply
 
Thread Tools Search this Thread
Old 02-28-2020, 02:22 PM   #16
jbenwell
Member
jbenwell began at the beginning.
 
Posts: 11
Karma: 10
Join Date: Feb 2020
Device: Kobo Forma
Thanks very much again. How does this look:

if SDL_Linked_Version_AtLeast(2, 0, 4) then
screen_flags = bit.bor(full_screen and 1 or 0,
SDL.SDL_WINDOW_RESIZABLE,
SDL.SDL_WINDOW_ALLOW_HIGHDPI)
else
screen_flags = bit.bor(full_screen and 1 or 0,
SDL.SDL_WINDOW_RESIZABLE)
end

I added this to SDL2_0_decl.c

SDL2_0_decl.c:cdecl_const(SDL_WINDOW_ALLOW_HIGHDPI )
jbenwell is offline   Reply With Quote
Old 02-28-2020, 02:42 PM   #17
Frenzie
Guru
Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.
 
Posts: 946
Karma: 330000
Join Date: Oct 2014
Location: Antwerp
Device: Kobo Aura H2O
That'd be 2.0.1, not 2.0.4.

I was just saying that 2.0.4 is the implied minimum version, or at least the lowest tested version, so I'm not sure there's anything to be gained putting in anything lower than SDL_Linked_Version_AtLeast(2, 0, 5). Especially because it just makes the code more annoying to read.

You also need a post-2015 CMake, for example. And a post-2014 gcc.

Last edited by Frenzie; 02-28-2020 at 02:47 PM.
Frenzie is offline   Reply With Quote
Advert
Old 02-28-2020, 02:47 PM   #18
jbenwell
Member
jbenwell began at the beginning.
 
Posts: 11
Karma: 10
Join Date: Feb 2020
Device: Kobo Forma
If I use 2.0.4 I get the expected result here (content that fills the window).

Another question would be whether this check is required, or whether it would work on any platform. Does the SDL_WINDOW_ALLOW_HIGHDPI flag break anything if it's not supported?
jbenwell is offline   Reply With Quote
Old 02-28-2020, 02:51 PM   #19
jbenwell
Member
jbenwell began at the beginning.
 
Posts: 11
Karma: 10
Join Date: Feb 2020
Device: Kobo Forma
I'm running this on a Mac. gcc --version returns this

Apple clang version 11.0.0 (clang-1100.0.33.17)

cmake --version returns this

cmake version 3.16.4
jbenwell is offline   Reply With Quote
Old 02-28-2020, 02:58 PM   #20
Frenzie
Guru
Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.
 
Posts: 946
Karma: 330000
Join Date: Oct 2014
Location: Antwerp
Device: Kobo Aura H2O
That may be, but the only correct value is 2.0.1. Given that you presumably have SDL 2.0.10, of course anything lower works.

Quote:
Another question would be whether this check is required
It might crash SDL 2.0.0. It might not. I'm starting to acquire a morbid curiosity to find out.
Frenzie is offline   Reply With Quote
Advert
Old 02-28-2020, 03:04 PM   #21
jbenwell
Member
jbenwell began at the beginning.
 
Posts: 11
Karma: 10
Join Date: Feb 2020
Device: Kobo Forma
That's why I figured using either 2.0.1 and 2.0.4 wouldn't matter. 2.0.1 works fine too, BTW.

If I had something running SDL 2.0.0 I'd check it out, but (far as I know) I don't

I guess my next step is to punch in a PR on the Koreader github page and see if it goes in.
jbenwell is offline   Reply With Quote
Old 02-28-2020, 10:33 PM   #22
jbenwell
Member
jbenwell began at the beginning.
 
Posts: 11
Karma: 10
Join Date: Feb 2020
Device: Kobo Forma
I've raised

MacBook 2017 (retina display): window size does not match content size #5909

On the Koreader project
jbenwell is offline   Reply With Quote
Old 02-29-2020, 01:01 AM   #23
NiLuJe
BLAM!
NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.NiLuJe ought to be getting tired of karma fortunes by now.
 
NiLuJe's Avatar
 
Posts: 9,982
Karma: 17701002
Join Date: Jun 2010
Location: Paris, France
Device: Kindle 2i, 3g, 4, 5w, (PW) & PW2; Kobo H2O & Forma
Oh, good thing you crossposted, I'd managed to miss it thanks to GitHub's terrible new beta notifications system >_<".
NiLuJe is offline   Reply With Quote
Old 02-29-2020, 07:48 AM   #24
jbenwell
Member
jbenwell began at the beginning.
 
Posts: 11
Karma: 10
Join Date: Feb 2020
Device: Kobo Forma
Thanks for all your help. I see things moving on the github side too. Very exciting!
jbenwell is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
iBooks on Mavericks with non-retina display SamL Apple Devices 3 01-10-2014 05:25 AM
Is anyone using the MacBook Pro with Retina display as an eReader? pata Apple Devices 12 08-14-2012 11:29 AM
iPad Apple’s New Retina Display: Do All Those Pixels Matter? monkeyluis Apple Devices 0 03-15-2012 08:46 AM
Rumoured Retina Display on iPad 3 Skilgannon Apple Devices 16 03-07-2012 03:29 PM


All times are GMT -4. The time now is 04:37 PM.


MobileRead.com is a privately owned, operated and funded community.