Editing metadata - why is this so...? - content.opf - Page 2

KevinH · 01-27-2023, 03:32 PM

Okay it seems the old sigil_bs4 code used "sorted()" when accessing attribute key, value pairs to help keep stability of attribute order before python moved to dictionaries being ordered by default.

Now that python has made that move, removal of the "sorted()" method should help maintain input attribute order as long as the underlying parser (lxml) maintains that order.

I have pushed this change to master. It will appear in the next release.

That said, anything that relies on xml attribute order is very broken according to the spec. We only try to maintain the order so that Checkpoint diffs are not cluttered by meaningless changes.

01-27-2023, 03:32 PM	#16
KevinH Sigil Developer Posts: 7,633 Karma: 5433388 Join Date: Nov 2009 Device: many	Okay it seems the old sigil_bs4 code used "sorted()" when accessing attribute key, value pairs to help keep stability of attribute order before python moved to dictionaries being ordered by default. Now that python has made that move, removal of the "sorted()" method should help maintain input attribute order as long as the underlying parser (lxml) maintains that order. I have pushed this change to master. It will appear in the next release. That said, anything that relies on xml attribute order is very broken according to the spec. We only try to maintain the order so that Checkpoint diffs are not cluttered by meaningless changes. Last edited by KevinH; 01-27-2023 at 03:51 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Update CONTENT.OPF. Use metadata fr calibreDB	GOROW	Library Management	1	04-13-2021 11:57 AM
Problem with different metadata editing in opf	homura_no_ko	Library Management	3	03-10-2018 07:26 PM
Calibre changing metadata in content.opf?	ChipSuey	Editor	2	08-09-2016 02:16 PM
Editing content.opf with clips; Editing visibility	varlog	Sigil	45	04-24-2016 07:55 AM
Order of metadata in content.opf	SIRSteiner	Library Management	4	10-08-2013 06:11 PM