Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > KOReader

Notices

Reply
 
Thread Tools Search this Thread
Old 11-16-2020, 05:41 AM   #1
Norbi24
Connoisseur
Norbi24 doesn't litterNorbi24 doesn't litter
 
Posts: 62
Karma: 144
Join Date: Aug 2019
Device: Tolino Vision HD4, BOOX Poke2
Ext Dictionaries definition overload doesn't work anymore since 2020.09

I am using this excellent function implemented here by @Pazos:

https://github.com/koreader/koreader/pull/5664

which makes it possible to use virtually any installed external dictionary app on Android, given it supports curresponding intent.

It has been working fine until 2020.08.1 (I am using the app picker variant,
where the dictonary is selected by app picker dialogue on its first usage attempt) but after update to 2020.10 the dictionary isnt's started anymore.

I tried to isolate the problem and found out that it stopped working already in 2020.09, and can reproduce it on my Samsung mobile (Android 8) with this simple dictionaries.lua (taken from Pazos's example in github link above)

return {
{ "Generic", "App picker", true, nil, "send" },
{ "ColorDict", "ColorDict", false, "com.socialnmobile.colordict", "colordict" },


If I copy this dictionaries.lua to koreader folder, both entries are shown if you go to ex. dictionary selection dialogue, but:

If you select app picker option, nothing happens afterwards, it doesn't work.
On the other hand, you are not able to select ColorDict, although it is installed on the Android.
Only if I change the boolean flag in the ColorDict line from false to true
(as not to check whether the app is installed), the I can select it and it really works !

I see that there were some changes in dictonaries handling, the list of predefined dictonaries was moved from dedicated frontend\device\android\dictionaries.lua file to frontend\device\android\device.lua
and perhaps there soomething happend ... I tried to understand the changes but do not know the LUA syntax so good (:-( so am not able to recognize it at first glance

Thanks, Norbert
Norbi24 is offline   Reply With Quote
Old 11-16-2020, 07:54 AM   #2
Frenzie
Wizard
Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.Frenzie ought to be getting tired of karma fortunes by now.
 
Posts: 1,073
Karma: 425000
Join Date: Oct 2014
Location: Antwerp
Device: Kobo Aura H2O
Code:
return {
    { "Generic", "App picker", true, nil, "send" },
    { "ColorDict", "ColorDict", false, "com.socialnmobile.colordict", "colordict" },
If you copy pasted this in full without accidentally skipping anything, then you're missing a closing brace.

It should look like this:
Code:
return {
    { "Generic", "App picker", true, nil, "send" },
    { "ColorDict", "ColorDict", false, "com.socialnmobile.colordict", "colordict" },
}
Frenzie is offline   Reply With Quote
Old 11-16-2020, 08:34 AM   #3
Norbi24
Connoisseur
Norbi24 doesn't litterNorbi24 doesn't litter
 
Posts: 62
Karma: 144
Join Date: Aug 2019
Device: Tolino Vision HD4, BOOX Poke2
Hi Frenzie, you are right, but I only missed closing brace here, in the koreader folder it was copied correctly, sorry for this confusion
Norbi24 is offline   Reply With Quote
Old 11-16-2020, 08:48 AM   #4
pazos
cosiñeiro
pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.
 
Posts: 671
Karma: 815871
Join Date: Apr 2014
Device: BQ Cervantes 4
Thanks @Norbi24 for the report.

Indeed generic actions (actions without an associated package) didn't work.
https://github.com/koreader/koreader/pull/6887 should fix both your issues.
pazos is offline   Reply With Quote
Old 11-16-2020, 10:37 AM   #5
Norbi24
Connoisseur
Norbi24 doesn't litterNorbi24 doesn't litter
 
Posts: 62
Karma: 144
Join Date: Aug 2019
Device: Tolino Vision HD4, BOOX Poke2
Norbi24 is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Calibre 5.0: Copying HTML/rich text in ePub doesn't work anymore barro350 Viewer 3 09-25-2020 11:01 AM
PRS-T1 Recovery Mode doesn't work anymore bookp Sony Reader Dev Corner 2 07-13-2012 07:13 PM
Connect to itunes for Calibre doesn't work anymore Marquis Apple Devices 9 02-18-2012 08:21 PM
DIE ZEIT Premium recipe doesn't work anymore Moik Recipes 1 07-16-2011 02:46 PM
Downloading a cover doesn't work anymore? JGB Calibre 13 12-05-2008 02:40 PM


All times are GMT -4. The time now is 12:41 PM.


MobileRead.com is a privately owned, operated and funded community.