calibre 6 beta: Full text searching

[ownedbycats]

Yeah I figured it was something like that. Still a bit jarring how much disk space it ate up.

[ownedbycats]

UI thought: There ought to be a resizable divider between the search results and preview pane. Currently, the right preview pane is a little squished unless I maximize the window:



Also, the tooltip indicates that 'restrict searched books' should search all the books currently in view. Instead, it only searches currently selected books.

It might also make sense to have a menu option to manually reindex selected books.

[BetterRed]

That's odd, i get a splitter handle halfway down the panel, viz:



BR

[ownedbycats]

Oh, I found it now that it's mentioned. I miss my dark mode.

[BetterRed]

And the tool tip for the Restrict searched books checkbox text seems pretty clear to me:

Restrict search results to only the books currently showing in the main library screen. This means that any Virtual libraries or search results are applied.

But maybe something like: "Only search the text of the books that are currently shown - i.e. books in the current VL and within the current metadata search constraints." would be more explicit.

[ownedbycats]

In my case, it only searched the one book I currently had selected. I had several other books visible in the list that had 'mustang' in the text, but only the selected one showed up.

I'm running from source, if ifthat's any matter.

[BetterRed]

Gotcha - it's the same for me if I select a book or some books.

How can you unselect the current book… other than a library switch of some sort?

BR

[BetterRed]

I think I'd prefer 3 radio buttons - search selected books, search within current VL and metadata search criteria, and search the entire library.

BR

[thiago.eec]

Originally Posted by kovidgoyal

@thiago: I dont see why the portable and installed version would behave differently. There is no code difference in them as far as handling icons is concerned. Try cleaning out your calibre config folder temporarily and seeing if that changes things.

Thanks, that gave me hint. I did what you asked and everything worked fine again, so I decided to look at my config folder files and noticed this two files: "icons-any.rcc" and "icons-dark.rcc". The light icons were missing. Then, I selected the theme for light only on the UI and it worked again. Is that a bug? I mean, if the user chooses only a theme for dark mode, shouldn't the switch work as normal using the default light theme?

Also, I have one question: when the user changes from light to dark (or the other way around), does calibre emit any signal for the plugin to catch? My plugin has built-in themes but, without a signal, it only changes when calibre is restarted.

[kovidgoyal]

restrict books was not supposed to work on selected books, but rather all currently shown books, this was a bug, now fixed.

[kovidgoyal]

@thiago: QApplication.instance().palette_changed.connect(wh atever)

Not sure what you are saying about the themes. Are you saying that if you choose a theme for dark only and then calibre switches to light, the plugin icons dont work? Remind me what code you use for plugin icons?

[thiago.eec]

Originally Posted by kovidgoyal

@thiago: QApplication.instance().palette_changed.connect(wh atever)

Thanks! I will test it here.

Originally Posted by kovidgoyal

Not sure what you are saying about the themes. Are you saying that if you choose a theme for dark only and then calibre switches to light, the plugin icons dont work?

These are the steps to reproduce it:

1) Erase RCC files (icons-any, icons-light, icons-dark) to reset theme options.
2) Go to Preferences>Look and feel>Change icon theme and choose any theme for the "For light and dark" option. Don't choose anything for Light and Dark only options.
3) Now, I have no icons for my plugins.
4) Go to Preferences>Look and feel>Change icon theme and choose any theme for the "For dark only" option. Don't choose a Light only theme.
5) Now, I have icons for my plugins while my Windows is set to dark. If I change it to Light, then I have no icons again.
6) Choosing a Light and a Dark theme on calibre fix all the issues.

Originally Posted by kovidgoyal

Remind me what code you use for plugin icons?

def get_icon(icon_name):
    # Check to see whether the icon exists as a Calibre resource
    # This will enable skinning if the user stores icons within a folder like:
    # ...\AppData\Roaming\calibre\resources\images\Plugin Name\
    icon_path = os.path.join(config_dir, 'resources', 'images', PLUGIN_NAME,
                             icon_name.replace('images/', ''))
    if os.path.exists(icon_path):
        pixmap = QPixmap()
        pixmap.load(icon_path)
        return QIcon(pixmap)
    # As we did not find an icon elsewhere, look within our zip resources
    if numeric_version < (5, 99, 0):
        return get_icons(icon_name)
    else:
        return get_icons(icon_name, PLUGIN_NAME)

[kovidgoyal]

Released 5.99.11 which uses pdftotext for indexing pdfs which is much faster and also gives better results for PDFs that are scanned pages with a text layer. Also fixes the issue with restrict searched books restricting to selected instead of displayed books.

[kovidgoyal]

@thiago: Looking at utils.py in your Check Books plugin that's not the actual code its using. Are you using a non-published version of the plugin?

You need to:

1) First look for QIcon.ic(PLUGIN_NAME + '/' + themed_name)
2) Then look for QIcon.ic(PLUGIN_NAME + '/' + non_themed_name)
3) Then look for get_icons('images/' + themed_name)

And note that with this approach your icons wont automatically change when going from light to dark mode you will have to listen to the signal and reset them manually.

[thiago.eec]

Originally Posted by kovidgoyal

@thiago: Looking at utils.py in your Check Books plugin that's not the actual code its using. Are you using a non-published version of the plugin?

The code I provided was from the Skoob Sync plugin.

Originally Posted by kovidgoyal

And note that with this approach your icons wont automatically change when going from light to dark mode you will have to listen to the signal and reset them manually.

I'll PM you about this, cause I went off-topic here.