[GUI Plugin] Prettify Cover

[m1d1]

Thanks for reporting.
To which size did you set Prettify Cover? (Default is 758x1024)
I want to reproduce the error.

[m1d1]

Here is version 1.5.3 please test.
Install plug-in from file in calibre.

Originally Posted by FrederikNJS

I tried using this plugin, but hit an annoying TypeError. It would seem that in both line 347 and 423 in the "action.py" file, the "x" and "y" variables can be floats (or maybe they just are by default?)... Anyway, here's the stack trace:

calibre, version 5.34.0
ERROR: Unhandled exception: <b>TypeError</b>:arguments did not match any overloaded call:
  QRect(): too many arguments
  QRect(int, int, int, int): argument 1 has unexpected type 'float'
  QRect(QPoint, QPoint): argument 1 has unexpected type 'float'
  QRect(QPoint, QSize): argument 1 has unexpected type 'float'
  QRect(QRect): argument 1 has unexpected type 'float'

calibre 5.34  embedded-python: False is64bit: True
Linux-5.15.10-zen1-1-zen-x86_64-with-glibc2.33 Linux ('64bit', 'ELF')
('Linux', '5.15.10-zen1-1-zen', '#1 ZEN SMP PREEMPT Fri, 17 Dec 2021 11:17:39 +0000')
Python 3.10.1
Interface language: None
Successfully initialized third party plugins: Gather KFX-ZIP (from KFX Input) (1, 46, 0) && DeDRM (7, 2, 1) && Package KFX (from KFX Input) (1, 46, 0) && Count Pages (1, 11, 1) && Goodreads Sync (1, 15, 1) && KFX metadata reader (from KFX Input) (1, 46, 0) && KFX Input (1, 46, 0) && KePub Input (3, 4, 3) && KePub Metadata Reader (3, 4, 3) && KePub Metadata Writer (3, 4, 3) && KePub Output (3, 5, 3) && Kindle hi-res covers (0, 5, 0) && Kobo Books (1, 8, 3) && Kobo Utilities (2, 14, 1) && KoboTouchExtended (3, 5, 4) && Obok DeDRM (7, 2, 1) && Prettify Cover (1, 5, 0)
Traceback (most recent call last):
  File "calibre_plugins.prettify_cover.dialogs", line 132, in showEvent
    self.generate_thumbs()
  File "calibre_plugins.prettify_cover.dialogs", line 309, in generate_thumbs
    tmp = self.ia.prettify_cover_for_book(self.cover, self.nwidth,
  File "calibre_plugins.prettify_cover.action", line 347, in prettify_cover_for_book
    target_rect = QRect(x, int(y), int(new_width), int(new_height))
TypeError: arguments did not match any overloaded call:
  QRect(): too many arguments
  QRect(int, int, int, int): argument 1 has unexpected type 'float'
  QRect(QPoint, QPoint): argument 1 has unexpected type 'float'
  QRect(QPoint, QSize): argument 1 has unexpected type 'float'
  QRect(QRect): argument 1 has unexpected type 'float'

I decided to try tinkering with it, and simply wrapped the "x" and the "y" parameter in "int()", so line 347 for example changes from:

target_rect = QRect(x, y, new_width, new_height)

to:

target_rect = QRect(int(x), int(y), new_width, new_height)

This seems to have resolved my issue, and everything just works now.

This would of course be nice if it was properly resolved directly (and correctly) in the plugin, but for now I have been able to hack-fix it with the typecast.

[LWTBP]

Hi. When I press the 'set as default action' button for the resolution I want, the following is the error:

name 'unicode' is not defined.

calibre, version 5.38.0
ERROR: Unhandled exception: <b>NameError</b>:name 'unicode' is not defined

calibre 5.38 [64bit] embedded-python: True is64bit: True
Windows-10-10.0.19041 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19041')
Python 3.8.5
Windows: ('10', '10.0.19041', '', 'Multiprocessor Free')
Interface language: en_GB
Successfully initialized third party plugins: DeDRM (7, 2, 1) && Goodreads (1, 5, 3) && Goodreads_Rating (3, 1, 0) && Hyphenate This! (0, 1, 3) && Kindle hi-res covers (0, 5, 0) && Prettify Cover (1, 5, 0)
Traceback (most recent call last):
File "calibre_plugins.prettify_cover.config", line 170, in set_as_default
NameError: name 'unicode' is not defined

[DNSB]

Originally Posted by LWTBP

Hi. When I press the 'set as default action' button for the resolution I want, the following is the error:

name 'unicode' is not defined.

Successfully initialized third party plugins: DeDRM (7, 2, 1) && Goodreads (1, 5, 3) && Goodreads_Rating (3, 1, 0) && Hyphenate This! (0, 1, 3) && Kindle hi-res covers (0, 5, 0) && Prettify Cover (1, 5, 0)

Have you tried using the Prettify Cover 1.5.3 plugin posted in message #47 in this thread? It's the message immediately prior to your post.

[LWTBP]

Hey. Yes, I tried 1.5.3 and I'm getting the same error. Also tried to add the default resolution of 758x1024 and make it the default. Didn't work. Are you facing this error?

[DNSB]

Originally Posted by LWTBP

Hey. Yes, I tried 1.5.3 and I'm getting the same error. Also tried to add the default resolution of 758x1024 and make it the default. Didn't work. Are you facing this error?

I haven't used Prettify Cover in quite a while. I found that I prefer using GIMP directly for the individualized control over the images. I hadn't tried changing the default resolution from the 1000x1500 that I had set back then. I just tried now and get the unicode error.

Looking at the config.py file, line 170 reads:

        if unicode(self.item(row, 2).text()).strip() == 'Default':

and line 173 reads:

        for update_row in range(0, self.rowCount()):

I'm not the greatest programmer around but I do seem to remember that in Python 2, unicode was a specialized variant of the str function whereas Python 3 pretty much uses Unicode as it's default. There was also a use of xrange in line 173. Changing the unicode to str and the xrange to range allows me to add a new size and make it the default. Please note that this will break Python 2 compatibility so I bumped the minimum calibre version in __init__.py to 5.0.0.

I've attached the modified file to this message if anyone wants to give it a try.

[LWTBP]

Originally Posted by DNSB

I haven't used Prettify Cover in quite a while. I found that I prefer using GIMP directly for the individualized control over the images. I hadn't tried changing the default resolution from the 1000x1500 that I had set back then. I just tried now and get the unicode error.

Looking at the config.py file, line 170 reads:

        if unicode(self.item(row, 2).text()).strip() == 'Default':

and line 173 reads:

        for update_row in range(0, self.rowCount()):

I'm not the greatest programmer around but I do seem to remember that in Python 2, unicode was a specialized variant of the str function whereas Python 3 pretty much uses Unicode as it's default. There was also a use of xrange in line 173. Changing the unicode to str and the xrange to range allows me to add a new size and make it the default. Please note that this will break Python 2 compatibility so I bumped the minimum calibre version in __init__.py to 5.0.0.

I've attached the modified file to this message if anyone wants to give it a try.

That solved the problem. I really appreciate it. Thank you!

[DNSB]

Originally Posted by LWTBP

That solved the problem. I really appreciate it. Thank you!

Please post if you run into any issues. What I did was a quick hack job and while I didn't see any issues in my limited testing, there is no warranty.

Hopefully, m1d1 will be able to fix the issue without breaking Python 2 compatibility.

[Polipipianovic]

Any chance this plugin gets an update for Calibre 6?

[m1d1]

Originally Posted by Polipipianovic

Any chance this plugin gets an update for Calibre 6?

I'm working on it.

[Polipipianovic]

Originally Posted by m1d1

I'm working on it.

Great!

[m1d1]

- fixes for Calibre 6
- removed GIMP related features (content-aware fill, edit with gimp, etc.)

[emoana]

@m1d1

Thanks so much for your work on this plugin. I have been using it for a while and find it very useful. I had some troubles (similar to those issues posted above), however, prettify cover, version 1.6.0 has resolved them.

Just to confirm:
calibre, version 6.1.0
prettify cover, version 1.6.0
all features working.

[Polipipianovic]

Originally Posted by m1d1

- fixes for Calibre 6
- removed GIMP related features (content-aware fill, edit with gimp, etc.)

Thank you so much

[Roke97]

Is it possible to prettify multiple covers at once? same BG color for everyone? Or do I have to click and accept it for every single cover?