Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Sigil

Notices

Reply
 
Thread Tools Search this Thread
Old 12-24-2021, 11:16 AM   #61
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 24,784
Karma: 170291258
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by KevinH View Post
The problem is the main qApp->pallette() is not being changed only the macos theme standard pallette. So I need to ifdef some code in CV to not grab and set the pallette from qApp on macOS after a change.
Sounds somewhat similar. The dark theme for Windows won't change "on the fly" like it will with Qt for macOS, so I only have to do it once. It's in main.cpp. For Windows (and linux, too), it's a matter of calling or not calling:

Code:
app.setPalette(QApplication::style()->standardPalette());
depending on the Qt version used.
DiapDealer is offline   Reply With Quote
Old 12-24-2021, 02:25 PM   #62
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 6,010
Karma: 4217884
Join Date: Nov 2009
Device: many
Okay just pushed a bunch of Qt6 on macOS related fixes to Sigil master on my github site:

https://github.com/kevinhendricks/Sigil

These include:

- use absolute path on sys.prefix to get proper path when installing python3 into Sigil

- worked around TabManager and PreviewWindow dark to light and visa-versa change issue
- these were actually early dark mode bugs re-introduced into Qt6 that were long ago fixed in Qt 5.12.x
- probably because they forked for Qt6 before these changes went in and they have not added in these fixes for some reason

Hope this helps,

KevinH

Last edited by KevinH; 12-24-2021 at 02:34 PM.
KevinH is offline   Reply With Quote
Old 12-24-2021, 04:39 PM   #63
democrite
Addict
democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.
 
Posts: 338
Karma: 77002
Join Date: Sep 2011
Device: none
Thank you. Dark mode alternate row color works great and the python script change builds fine. I didn't test Qt 5. I saw a comment about for Qt 5 also so maybe such would be ok. As the dark mode alternate row color issue existed for me with Qt 5.15.2, and it seemed you didn't notice it, maybe it is specific to some combo of that Qt plus Monterey.

A quick look around other parts of the app to verify, I noticed maybe in Preferences, Keyboard Shortcuts could also use alternate row colors.

Testing switching between dark and light mode, doing such while Preferences is open, something else is sometimes the palette doesn't change correctly. It doesn't happen all the time; perhaps it is something new with Qt 6. Screenshot attached.

Since I was looking at Preferences (and other parts of the UI), the slider to set main menu icon size I think looks non-native. Compared to Qt 5, the slider now has hash marks. Screen shot attached plus one from System Preferences.

And unrelated to Qt6, maybe the find/replace panel could use some padding around controls. For example each of the options (DotAll, …) are almost cut off since the next control appears after w/o padding.
Attached Thumbnails
Click image for larger version

Name:	Screen Shot 2021-12-24 at 12.37.59.png
Views:	29
Size:	61.6 KB
ID:	190986   Click image for larger version

Name:	Screen Shot 2021-12-24 at 12.32.45.png
Views:	29
Size:	31.4 KB
ID:	190987   Click image for larger version

Name:	Capture d’écran 2021-12-24 à 12.29.36.png
Views:	28
Size:	247.6 KB
ID:	190988  

Last edited by democrite; 12-24-2021 at 04:41 PM. Reason: ed
democrite is offline   Reply With Quote
Old 12-24-2021, 05:12 PM   #64
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 6,010
Karma: 4217884
Join Date: Nov 2009
Device: many
The icon size slider, should show the tick marks as it is part of the code and has been. They should show under Qt5 as well, otherwise it is a Qt5 bug.

The Preferences Keyboard Shortcuts QTreeWidget can easily be set to setAlternatingRowColors true in either the code or its ui file. No one has asked for that yet so this is unchanged from Qt5.

I will play around with dynamic switching from dark to light and back in Preferences to see what breaks. But Qt 6.2.2 is actually a big step backward in this regard as Qt 5.12.9 has this working.

Last edited by KevinH; 12-24-2021 at 05:24 PM.
KevinH is offline   Reply With Quote
Old 12-24-2021, 05:39 PM   #65
democrite
Addict
democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.
 
Posts: 338
Karma: 77002
Join Date: Sep 2011
Device: none
Indeed very possible Qt 6 has a whole new set of issues.

Concerning the slider, I found this issue for Monterey yet I didn’t test yet if such happens for me.

https://bugreports.qt.io/plugins/ser...ue/QTBUG-98093

Of the look of the slider, I think you’re using TicksBothSides? I haven’t really looked yet I think on macOS, below might be the preferred choice. At least such seems to be the case from some screen shot from Apple’s Human Interface Guidelines.

From Apple’s API, below and above seem to be the only valid options and I am not sure what Qt does when set to both.

https://developer.apple.com/document...ckmarkposition
democrite is offline   Reply With Quote
Old 12-24-2021, 06:03 PM   #66
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 6,010
Karma: 4217884
Join Date: Nov 2009
Device: many
Thanks, for that Qt tick mark bug link. From reading it and the related Monterey specific bug we will have to wait for a fix from Qt for that as Qt 6.2.3 will not be released opensource as it is LTS.

As for making Sigil exactly match the Apple native guidelines for tick marks, that is a very low priority as Sigil is meant to be a cross-platform app first and foremost. And function must come before form. We also like to limit the number of platform specific ifdefs in our Sigil codebase as they make support harder because the flow is not easily apparent.

All that said, I will look into changing the tickmarks location on macOS Sigil for some future release.
KevinH is offline   Reply With Quote
Old 12-24-2021, 10:01 PM   #67
democrite
Addict
democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.democrite will give the Devil his due.
 
Posts: 338
Karma: 77002
Join Date: Sep 2011
Device: none
No prob. All is working well and the main goal of a native build has been achieve. Many thanks again for everything.
democrite is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Is Calibre compatible with Apple Silicon M1 Macs (using rosetta 2)? kirk8677 Calibre 29 01-22-2021 08:39 AM
Error on running Sigil via Qt-Creator nirosan Sigil 2 10-28-2017 09:51 AM
Trouble running Sigil 0.9.7 John2011 Sigil 11 12-29-2016 08:28 AM
UnicodeWarning when running Sigil plugin turbulent Plugins 9 12-17-2014 08:11 AM
Reporting an error when running Sigil 0.8.2 turbulent Sigil 2 12-13-2014 11:23 PM


All times are GMT -4. The time now is 06:49 PM.


MobileRead.com is a privately owned, operated and funded community.