Plugin devs: Upcoming migration to Qt 6 - Page 8

JimmXinu · 01-12-2022, 04:45 PM

Up to you. I only support the last version of the v2 series myself.

FYI, I added Remove call to setTabStopWidth from raw prefs viewer--changed in qt6 and not needed to my list above.

BeckyEbook · 01-20-2022, 07:12 AM

I don't know if this is a good place, but I noticed a problem with the dark mode that disappears and switches to the default (light), although nothing changes in the system (dark mode default).
I noticed this first in 5.99.2, and since the 5.99.3 beta, I see it almost every day.

Steps:
I run calibre and the program works all the time.
I do other things
I go back to calibre, and there is a light theme.

Windows 10 Pro 21H1, calibre 5.99.3 (beta)

kovidgoyal · 01-20-2022, 11:54 AM

colors get changed when qt sends a applicationplettechnged event to calibre. I would guess that event is snt by qt when it gets some event from the os notifying it of a changed color theme.

georgemk · 01-22-2022, 06:33 AM

When the Device is attached (Nook Glowlight), clicking on the Title column header in Device view causes this crash and afterwards you cannot change Library view (all options greyed out in that menu).
You can still eject the device but that also gives the same exception type on the same line in config_base.py. Afterwards the only action possible is to close Calibre via the Windows X close box. Again it issues the same exception.

Click Title to sort :

Code:

calibre, version 5.99.3
ERROR: Unhandled exception: <b>TypeError</b>:&lt;SortOrder.DescendingOrder: 1&gt; is not JSON serializable

calibre 5.99.3  embedded-python: True
Windows-10-10.0.19043 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19043')
Python 3.10.1
Windows: ('10', '10.0.19043', '', 'Multiprocessor Free')
Interface language: en_GB
Successfully initialized third party plugins: DeDRM (10, 0, 2) && Find Duplicates (1, 9, 2) && Kobo Books (1, 8, 3) && Obok DeDRM (10, 0, 0) && Quality Check (1, 12, 0) && Quick Preferences (1, 5, 0)
Traceback (most recent call last):
  File "calibre\gui2\library\views.py", line 557, in user_sort_requested
  File "calibre\gui2\library\views.py", line 574, in intelligent_sort
  File "calibre\utils\config.py", line 438, in __setitem__
  File "calibre\utils\config.py", line 401, in commit
  File "calibre\utils\config.py", line 422, in to_raw
  File "calibre\utils\config_base.py", line 100, in json_dumps
  File "json\__init__.py", line 238, in dumps
  File "json\encoder.py", line 201, in encode
  File "json\encoder.py", line 431, in _iterencode
  File "json\encoder.py", line 405, in _iterencode_dict
  File "json\encoder.py", line 405, in _iterencode_dict
  File "json\encoder.py", line 438, in _iterencode
  File "calibre\utils\config_base.py", line 53, in to_json
TypeError: <SortOrder.DescendingOrder: 1> is not JSON serializable

Click Eject Device

Code:

calibre, version 5.99.3
ERROR: Unhandled exception: <b>TypeError</b>:&lt;SortOrder.DescendingOrder: 1&gt; is not JSON serializable

calibre 5.99.3  embedded-python: True
Windows-10-10.0.19043 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19043')
Python 3.10.1
Windows: ('10', '10.0.19043', '', 'Multiprocessor Free')
Interface language: en_GB
Successfully initialized third party plugins: DeDRM (10, 0, 2) && Find Duplicates (1, 9, 2) && Kobo Books (1, 8, 3) && Obok DeDRM (10, 0, 0) && Quality Check (1, 12, 0) && Quick Preferences (1, 5, 0)
Traceback (most recent call last):
  File "calibre\gui2\device.py", line 352, in umount_device
  File "calibre\gui2\__init__.py", line 677, in __call__
  File "calibre\gui2\device.py", line 1098, in device_detected
  File "calibre\gui2\library\views.py", line 684, in save_state
  File "calibre\gui2\library\views.py", line 1441, in write_state
  File "calibre\utils\config.py", line 383, in set
  File "calibre\utils\config.py", line 438, in __setitem__
  File "calibre\utils\config.py", line 401, in commit
  File "calibre\utils\config.py", line 422, in to_raw
  File "calibre\utils\config_base.py", line 100, in json_dumps
  File "json\__init__.py", line 238, in dumps
  File "json\encoder.py", line 201, in encode
  File "json\encoder.py", line 431, in _iterencode
  File "json\encoder.py", line 405, in _iterencode_dict
  File "json\encoder.py", line 405, in _iterencode_dict
  File "json\encoder.py", line 438, in _iterencode
  File "calibre\utils\config_base.py", line 53, in to_json
TypeError: <SortOrder.DescendingOrder: 1> is not JSON serializable

Click X to close

Code:

calibre, version 5.99.3
ERROR: Unhandled exception: <b>TypeError</b>:&lt;SortOrder.DescendingOrder: 1&gt; is not JSON serializable

calibre 5.99.3  embedded-python: True
Windows-10-10.0.19043 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19043')
Python 3.10.1
Windows: ('10', '10.0.19043', '', 'Multiprocessor Free')
Interface language: en_GB
Successfully initialized third party plugins: DeDRM (10, 0, 2) && Find Duplicates (1, 9, 2) && Kobo Books (1, 8, 3) && Obok DeDRM (10, 0, 0) && Quality Check (1, 12, 0) && Quick Preferences (1, 5, 0)
Traceback (most recent call last):
  File "calibre\gui2\ui.py", line 1205, in closeEvent
  File "calibre\gui2\ui.py", line 1055, in write_settings
  File "calibre\utils\config.py", line 411, in __exit__
  File "calibre\utils\config.py", line 401, in commit
  File "calibre\utils\config.py", line 422, in to_raw
  File "calibre\utils\config_base.py", line 100, in json_dumps
  File "json\__init__.py", line 238, in dumps
  File "json\encoder.py", line 201, in encode
  File "json\encoder.py", line 431, in _iterencode
  File "json\encoder.py", line 405, in _iterencode_dict
  File "json\encoder.py", line 405, in _iterencode_dict
  File "json\encoder.py", line 438, in _iterencode
  File "calibre\utils\config_base.py", line 53, in to_json
TypeError: <SortOrder.DescendingOrder: 1> is not JSON serializable

kovidgoyal · 01-22-2022, 10:37 AM

@georgemk: Thanks, this should take care of it: https://github.com/kovidgoyal/calibr...e3474e3ddeea7c

georgemk · 01-22-2022, 11:38 AM

@kovid Thank you, that fixed worked here.

un_pogaz · 01-22-2022, 03:24 PM

message of the commit "More pyqt6 enum goodness"
Hum, I feel a certain emotion in this 'goodness', right?

This migration must have been a lot of fun.
Thank you for taking so much care to make this one as smooth and transparent as possible for small plugin developers like me, so much so that it would not have been seen.

kovidgoyal · 01-22-2022, 09:42 PM

You are most welcome!

Yeah the enum changes in PyQt6 alone needed hundreds of commits to port, many of them are actually in master rather than qt6 branch. Indeed, I created the whole "from qt.core import" machinery just to ease this transition and future ones like it.

On a personal note, I have to say that the last few years for me have been quite frustrating in calibre land as I have had to spend all my time and energy porting things first from Qt4 -> Qt5 which involved rewriting the entire viewer to use Qt WebEngine, then from python2 -> python3 and now for Qt5 -> Qt6 and the associated work getting calibre to build on ARM. I am really looking forward to all this busywork being done so I can get back to developing actual features.

ownedbycats · 01-22-2022, 10:28 PM

Quote:

Originally Posted by un_pogaz

message of the commit "More pyqt6 enum goodness"
Hum, I feel a certain emotion in this 'goodness', right?

As someone who runs from source sometimes, I get amusement by some of the commit messages. "More PyQt6 nonsense" or "Another PyQt enum waste of time" or just "oops"

un_pogaz · 01-23-2022, 05:13 AM

Quote:

Originally Posted by ownedbycats

As someone who runs from source sometimes, I get amusement by some of the commit messages. "More PyQt6 nonsense" or "Another PyQt enum waste of time" or just "oops"

Quote:

Originally Posted by kovidgoyal

On a personal note, I have to say that the last few years for me have been quite frustrating in calibre land as I have had to spend all my time and energy porting things [...] I am really looking forward to all this busywork being done so I can get back to developing actual features.

Ah. Well, let's hope that you are done with this race against the world of depreciating elements, and you could relax a bit after all this and develop the features of your choice at your own pace.

... but knowing the speed of evolution in the world of technology, there is... 50% for a new horror to fall on you.
So really literally: Good luck, my heart goes out to you.

In the best of all worlds: any ideas for the next Calibre direction?

un_pogaz · 01-24-2022, 03:31 PM

Okay, I'm posting here, because it concerns the very fresh development of Calibre, and I'm not sure if it's a bug (or at least, I lack explanation)

for a plugin I'm looking at the FieldMetadata from "calibre.library.field_metadata", and I discovered that the "custom_series_index" fields are not marked as custom fields.

Code:

{
    'table': None,
    'column': None,
    'datatype': 'float',
    'is_multiple': {},
    'kind': 'field',
    'name': '',
    'search_terms': ['#custom_series_index'],
    'label': 'custom_series_index',
    'colnum': None,
    'display': {},
    'is_custom': False,
    'is_category': False,
    'link_column': None,
    'category_sort': None,
    'is_editable': False,
    'is_csp': False,
    'rec_index': 37
}

If it's a bug, it's old, V4. It would be too weird that it went unnoticed all this time.

theducks · 01-24-2022, 03:50 PM

The field LABEL is just that, only for human consumption. It can be anything
The real field has the #fieldname. That is what you use.
Ther is no need for both to even be close.
Note: you can change the Label on existing custom columns. I'm not sure you can change the 'lookupname' (#fieldname)

chaley · 01-24-2022, 04:13 PM

Quote:

Originally Posted by un_pogaz

Okay, I'm posting here, because it concerns the very fresh development of Calibre, and I'm not sure if it's a bug (or at least, I lack explanation)

for a plugin I'm looking at the FieldMetadata from "calibre.library.field_metadata", and I discovered that the "custom_series_index" fields are not marked as custom fields.

Code:

{
    'table': None,
    'column': None,
    'datatype': 'float',
    'is_multiple': {},
    'kind': 'field',
    'name': '',
    'search_terms': ['#custom_series_index'],
    'label': 'custom_series_index',
    'colnum': None,
    'display': {},
    'is_custom': False,
    'is_category': False,
    'link_column': None,
    'category_sort': None,
    'is_editable': False,
    'is_csp': False,
    'rec_index': 37
}

If it's a bug, it's old, V4. It would be too weird that it went unnoticed all this time.

That is because series indices aren't real columns, custom or otherwise. Every series-type column 'lookup_name' has an associated virtual column 'lookup_name_index', added automatically when the series-type column is added to field metadata. The value of that virtual column comes either from the book record (series) or from the series link table (#series).

BetterRed · 01-24-2022, 04:22 PM

Quote:

Originally Posted by theducks

. . .
Note: you can change the Label on existing custom columns. I'm not sure you can change the 'lookupname' (#fieldname)

You can change the Lookup name, the only attribute of a custom column that can't be changed is the Column type.

If you change a Lookup name it will ripple through the metadata.opf files in the book folders.

BR

thiago.eec · 01-24-2022, 04:38 PM

Quote:

Originally Posted by theducks

The field LABEL is just that, only for human consumption. It can be anything
The real field has the #fieldname. That is what you use.
Ther is no need for both to even be close.
Note: you can change the Label on existing custom columns. I'm not sure you can change the 'lookupname' (#fieldname)

I think the post is about this key:
'is_custom' : False

01-20-2022, 07:12 AM	#107
BeckyEbook Guru Posts: 690 Karma: 2180740 Join Date: Jan 2017 Location: Poland Device: Misc	I don't know if this is a good place, but I noticed a problem with the dark mode that disappears and switches to the default (light), although nothing changes in the system (dark mode default). I noticed this first in 5.99.2, and since the 5.99.3 beta, I see it almost every day. Steps: I run calibre and the program works all the time. I do other things I go back to calibre, and there is a light theme. Windows 10 Pro 21H1, calibre 5.99.3 (beta) Attached Thumbnails

01-24-2022, 03:31 PM	#116
un_pogaz Chalut o/ Posts: 410 Karma: 145324 Join Date: Dec 2017 Device: Kobo	Okay, I'm posting here, because it concerns the very fresh development of Calibre, and I'm not sure if it's a bug (or at least, I lack explanation) for a plugin I'm looking at the FieldMetadata from "calibre.library.field_metadata", and I discovered that the "custom_series_index" fields are not marked as custom fields. Code: { 'table': None, 'column': None, 'datatype': 'float', 'is_multiple': {}, 'kind': 'field', 'name': '', 'search_terms': ['#custom_series_index'], 'label': 'custom_series_index', 'colnum': None, 'display': {}, 'is_custom': False, 'is_category': False, 'link_column': None, 'category_sort': None, 'is_editable': False, 'is_csp': False, 'rec_index': 37 } If it's a bug, it's old, V4. It would be too weird that it went unnoticed all this time. Last edited by un_pogaz; 01-24-2022 at 03:40 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Suggestion for PI Devs	BetterRed	Plugins	11	09-27-2020 06:18 PM
Attn plugin devs: porting to python 3	kovidgoyal	Plugins	129	06-16-2020 01:31 AM
Attention All Plugin Devs: Remove vestiges from python 2?	KevinH	Plugins	11	05-29-2020 03:16 PM
Plugin Devs: Should we include a License or COPYING file?	KevinH	Plugins	3	08-15-2017 01:09 PM
New Plugin Features in the upcoming Sigil 0.8.900	KevinH	Plugins	6	09-14-2015 02:48 PM

01-12-2022, 04:45 PM	#106
JimmXinu Plugin Developer Posts: 6,307 Karma: 3966249 Join Date: Dec 2011 Location: Midwest USA Device: Kindle Paperwhite(10th)	Up to you. I only support the last version of the v2 series myself. FYI, I added Remove call to setTabStopWidth* from raw prefs viewer--changed in qt6 and not needed* to my list above.

01-20-2022, 11:54 AM	#108
kovidgoyal creator of calibre Posts: 43,843 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	colors get changed when qt sends a applicationplettechnged event to calibre. I would guess that event is snt by qt when it gets some event from the os notifying it of a changed color theme.

01-22-2022, 10:37 AM	#110
kovidgoyal creator of calibre Posts: 43,843 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	@georgemk: Thanks, this should take care of it: https://github.com/kovidgoyal/calibr...e3474e3ddeea7c

01-22-2022, 11:38 AM	#111
georgemk Addict Posts: 234 Karma: 291844 Join Date: Oct 2019 Device: Kobo Nia	@kovid Thank you, that fixed worked here.

01-22-2022, 03:24 PM	#112
un_pogaz Chalut o/ Posts: 410 Karma: 145324 Join Date: Dec 2017 Device: Kobo	message of the commit "More pyqt6 enum goodness" Hum, I feel a certain emotion in this 'goodness', right? This migration must have been a lot of fun. Thank you for taking so much care to make this one as smooth and transparent as possible for small plugin developers like me, so much so that it would not have been seen.

01-22-2022, 09:42 PM	#113
kovidgoyal creator of calibre Posts: 43,843 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	You are most welcome! Yeah the enum changes in PyQt6 alone needed hundreds of commits to port, many of them are actually in master rather than qt6 branch. Indeed, I created the whole "from qt.core import" machinery just to ease this transition and future ones like it. On a personal note, I have to say that the last few years for me have been quite frustrating in calibre land as I have had to spend all my time and energy porting things first from Qt4 -> Qt5 which involved rewriting the entire viewer to use Qt WebEngine, then from python2 -> python3 and now for Qt5 -> Qt6 and the associated work getting calibre to build on ARM. I am really looking forward to all this busywork being done so I can get back to developing actual features.

01-24-2022, 03:50 PM	#117
theducks Well trained by Cats Posts: 29,780 Karma: 54830978 Join Date: Aug 2009 Location: The Central Coast of California Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A	The field LABEL is just that, only for human consumption. It can be anything The real field has the #fieldname. That is what you use. Ther is no need for both to even be close. Note: you can change the Label on existing custom columns. I'm not sure you can change the 'lookupname' (#fieldname)