11-13-2019, 11:03 AM | #91 |
Sigil Developer
Posts: 7,653
Karma: 5433388
Join Date: Nov 2009
Device: many
|
Yes that did the trick. I have pushed a fix to "too fast closing tabs" to master. With these changes, I can not get Sigil to crash anymore.
We should probably re-enable drag and drop of tabs full time again, and see if that is now stable enough. I would guess that is probably is now. KevinH |
11-13-2019, 11:38 AM | #92 |
Grand Sorcerer
Posts: 27,552
Karma: 193191846
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
I'm OK with that (Drag 'n Drop).
Thanks for the fix. And thanks @snarkophilus for putting the bug back on our radar TO fix! |
Advert | |
|
11-13-2019, 12:20 PM | #93 |
Sigil Developer
Posts: 7,653
Karma: 5433388
Join Date: Nov 2009
Device: many
|
FYI: just pushed re-enabling of drag and drop in master so we can test to see if the last commit "fixes" things there as well.
I have my fingers crossed! |
11-13-2019, 12:33 PM | #94 |
Wizard
Posts: 2,297
Karma: 12126329
Join Date: Jul 2012
Device: Kobo Forma, Nook
|
|
11-13-2019, 12:46 PM | #95 |
Grand Sorcerer
Posts: 27,552
Karma: 193191846
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
It was always available. One just had to set an environment variable in order to enable it "at your own risk". But hopefully we can leave it enabled by default now, if there's no reports of it crashing.
|
Advert | |
|
11-13-2019, 12:50 PM | #96 |
Wizard
Posts: 2,297
Karma: 12126329
Join Date: Jul 2012
Device: Kobo Forma, Nook
|
If an advanced user such as I—the greatest and best Sigil user of all time—hadn't gone out of his way to use that environment variable... I shudder to think how many typical users enabled that.
|
11-13-2019, 12:53 PM | #97 |
Grand Sorcerer
Posts: 27,552
Karma: 193191846
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
For as handy as many say that it is; we only ever had a handful of people ask about it the whole time it was disabled by default.
Last edited by DiapDealer; 11-13-2019 at 01:05 PM. |
11-13-2019, 05:22 PM | #98 | |
Wannabe Connoisseur
Posts: 425
Karma: 2516674
Join Date: Apr 2011
Location: Geelong, Australia
Device: Kobo Libra 2, Kobo Aura 2, Sony PRS-T1, Sony PRS-350, Palm TX
|
Quote:
I also forgot to mention that I'm on Windows 10. (I'm at work now, can post a screenshot when I get home if that helps.) EDIT: Yeah, yeah, I should have read the rest of this thread before replying to the first message after mine to realise the bug had both been discussed and fixed . Thanks guys! Last edited by snarkophilus; 11-13-2019 at 05:25 PM. |
|
11-13-2019, 05:24 PM | #99 | |
Grand Sorcerer
Posts: 27,552
Karma: 193191846
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Quote:
|
|
11-14-2019, 03:07 AM | #100 | |
Wannabe Connoisseur
Posts: 425
Karma: 2516674
Join Date: Apr 2011
Location: Geelong, Australia
Device: Kobo Libra 2, Kobo Aura 2, Sony PRS-T1, Sony PRS-350, Palm TX
|
Quote:
I can reproduce it sort of easily by edtting the attached epub, opening all 50 images (a "open all selected files in tabs" wishlist suggestion? ), then holding down ctrl-W to close windows. More often than not, when the last image is closed, a few seconds later Sigil crashes. I had a harder time getting it to crash with only 20 tabs open. |
|
11-14-2019, 03:36 AM | #101 | |
Grand Sorcerer
Posts: 5,584
Karma: 22735033
Join Date: Dec 2010
Device: Kindle PW2
|
Quote:
I've opened and closed all 50 images twice by pressing CTRL+W and didn't get a crash. Have you installed the Windows 10 1909 update? EDIT: I didn't get a crash with the latest version on my Linux machine either. However, I got the following warning in the terminal window: Code:
Warning: QObject::connect: No such signal ImageResource::Deleted(Resource) Last edited by Doitsu; 11-14-2019 at 04:13 AM. |
|
11-14-2019, 03:55 AM | #102 |
Guru
Posts: 692
Karma: 2180740
Join Date: Jan 2017
Location: Poland
Device: Misc
|
I have Windows 10 Pro 1909 and I confirm the problem.
Fresh build. But - I admit - this does not happen every time. Last edited by BeckyEbook; 11-14-2019 at 04:00 AM. |
11-14-2019, 05:03 AM | #103 | ||
Wannabe Connoisseur
Posts: 425
Karma: 2516674
Join Date: Apr 2011
Location: Geelong, Australia
Device: Kobo Libra 2, Kobo Aura 2, Sony PRS-T1, Sony PRS-350, Palm TX
|
Quote:
Quote:
Certainly Kevin's recent change made the problem a lot harder to trigger, but it seems that there's still some sort of timing or signal niggle in there somewhere. |
||
11-14-2019, 09:11 AM | #104 |
Sigil Developer
Posts: 7,653
Karma: 5433388
Join Date: Nov 2009
Device: many
|
Then the issue must be happening with some other qt signal someplace else in the code. The code sequence that caused the first crash can simply not happen anymore. So I will try once again using macOS but if I can not get it to happen the remaining bug must be Windows specific.
|
11-14-2019, 09:15 AM | #105 |
Sigil Developer
Posts: 7,653
Karma: 5433388
Join Date: Nov 2009
Device: many
|
BTW, closing the final tab should not be allowed as that will always cause the app to close in Windows and Linux but not on macOSX. The code should prevent the final tab from ever going away.
Are you sure you are actually closing the final tab before the crash, or is it the next to last tab? |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
5.8.11 Pre=release | knc1 | Kindle Developer's Corner | 21 | 04-17-2018 08:42 PM |
Overdrive - Search for Pre-Release | nynaevelan | General Discussions | 11 | 11-24-2013 02:27 PM |
Where are the pre-release purchase buttons? | Sydney's Mom | General Discussions | 8 | 09-06-2012 10:57 PM |
KF Android 4.0 Pre-Release Version | robertc88 | Kindle Fire | 22 | 01-22-2012 07:24 PM |
PDF Viewer 0.3.0 pre-release | pruss | Android Devices | 62 | 11-22-2011 11:18 AM |