Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Sigil

Notices

Reply
 
Thread Tools Search this Thread
Old 06-18-2017, 02:05 PM   #1
AlanHK
Addict
AlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheese
 
AlanHK's Avatar
 
Posts: 338
Karma: 1002
Join Date: Apr 2014
Device: PW-3, Android phone
"unused stylesheet class" is actually used

In this ePub I used this pair of style definitions:

Code:
.letter, .letter1 {
    display: block;
    margin-bottom: 0;
    margin-left: 2em;
    margin-right: 1em;
    margin-top: 0em;
    text-align: left;
    text-indent: 2em;
    }

 .letter1 {
    margin-top: 2em;
    text-indent: 0;
    }
And in the pages used them:

Code:
<p class="letter1">Dear Mr. Wells,</p>

  <p class="letter">Your attendance is requested in an investigation
of grave importance to the Royal Family of the Nederlands. Please
consult S. Holmes posthaste regarding your willingness to participate.</p>

  <p class="letter">Sec. to H.M. Emma of Waldeck-Pyrmont</p>

The idea being to have the first line of a letter with a top margin and no indent, otherwise the same as the "body" of the letter.

This looked as expected and validated with epubcheck.
But running Sigil's "Delete Unused Stylesheet Classes" and it includes "letter1" as unused.

Is this a bug in that function, or is this kind of CSS invalid?
AlanHK is offline   Reply With Quote
Advert
Old 06-18-2017, 02:18 PM   #2
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 2,593
Karma: 772404
Join Date: Nov 2009
Device: many
Which version of Sigil? There was a similar bug fixed in an earlier but recent version of Sigil but I am not sure which one.

If the latest version, 0.9.8 then most probably a bug in Sigil that I will track down and fix.

Last edited by KevinH; 06-18-2017 at 02:21 PM.
KevinH is online now   Reply With Quote
Old 06-18-2017, 02:42 PM   #3
Doitsu
Wizard
Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.
 
Doitsu's Avatar
 
Posts: 3,928
Karma: 11088364
Join Date: Dec 2010
Device: Kindle PW2
Quote:
Originally Posted by KevinH View Post
Which version of Sigil? There was a similar bug fixed in an earlier but recent version of Sigil but I am not sure which one.
Quote:
Originally Posted by AlanHK View Post
I'm using Sigil 0.91.
Quote:
Originally Posted by KevinH View Post
If the latest version, 0.9.8 then most probably a bug in Sigil that I will track down and fix.
I wasn't able to reproduce this issue with the 64bit 0.9.8 Windows version.

Last edited by Doitsu; 06-18-2017 at 02:49 PM.
Doitsu is offline   Reply With Quote
Old 06-18-2017, 02:49 PM   #4
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 2,593
Karma: 772404
Join Date: Nov 2009
Device: many
So it is most probably a css parsing bug already fixed.

Thanks for testing it!

Quote:
Originally Posted by Doitsu View Post
I wasn't able to reproduce this issue with 64bit 0.9.8 Windows version.
KevinH is online now   Reply With Quote
Old 06-18-2017, 04:30 PM   #5
Turtle91
A Hairy Wizard
Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.Turtle91 ought to be getting tired of karma fortunes by now.
 
Turtle91's Avatar
 
Posts: 1,519
Karma: 11627112
Join Date: Dec 2012
Location: Altus, Oklahoma today
Device: iPhone 6/5/iPad 1,2 & Air/Surface Pro/Kindle PW
The only consistent issue I've seen with the remove unused stylesheet classes tool is that it still doesn't recognize when pseudo-element selectors have been used in the document.

eg.
p.first:first-letter
p.first:first-line


Even when <p class="first"> is used in the document they are still tagged for deletion. It is easy enough to uncheck the box, but only if you know to look for it.
Turtle91 is offline   Reply With Quote
Advert
Old 06-20-2017, 05:37 PM   #6
wrCisco
Member
wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.wrCisco ought to be getting tired of karma fortunes by now.
 
Posts: 14
Karma: 282196
Join Date: Apr 2016
Device: none
Quote:
Originally Posted by Turtle91 View Post
The only consistent issue I've seen with the remove unused stylesheet classes tool is that it still doesn't recognize when pseudo-element selectors have been used in the document.
I'm just making a quick reappearance to do a shameless promotion of the plugin I published here at MobileRead last year, cssRemoveUnusedSelectors, that goes over that and other limitations of the standard Sigil tool.

Just in case new users lost it...

Quote:
Originally Posted by KevinH View Post
Which version of Sigil?
You fixed that bug before releasing v0.9.6 (I remember testing it...).

I don't use Sigil anymore as much as I'd like, but it's always a pleasure to read and see the great work that maintainers and active users do.
wrCisco is offline   Reply With Quote
Old 06-20-2017, 05:42 PM   #7
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 17,281
Karma: 89932658
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by wrCisco View Post
I'm just making a quick reappearance to do a shameless promotion of the plugin I published here at MobileRead last year, cssRemoveUnusedSelectors, that goes over that and other limitations of the standard Sigil tool.

Just in case new users lost it...
Ack! I should have remembered that. I use your plugin enough that you'd think that wouldn't happen.
DiapDealer is online now   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
SVG images marked as "unused media" AlanHK Sigil 5 09-02-2016 01:36 PM
Class action: "sale" royalties on "licensed" ebooks drjenkins News 2 06-02-2016 09:44 AM
Is it possible to reject some changes after using "Remove unused CSS tool"? bowlins Editor 7 09-02-2014 05:22 AM
New "remove unused css" tool BobC Editor 4 01-25-2014 10:06 PM
Ended "Unused" BN Nook Color. Waba Flea Market 3 01-14-2011 11:21 AM


All times are GMT -4. The time now is 11:53 AM.


MobileRead.com is a privately owned, operated and funded community.