[GUI Plugin] Find Duplicates

[komali_2]

Originally Posted by random733

Is there any working version with the auto merging feature? komali2s version (1.8.5) here unfortunately does not work with the latest Calibre version (linux and windows) - keeps requiring a reboot without the plugin being fully installed.

I understand the concerns about the dangers to the integrity of the library. But I think you can manage the risk with a backup. And in the end, everyone is responsible for actually using this function (which is also explicitly declared as dangerous).

Hey, sorry about that, I got caught up in some big work projects.

It's ok that kiwidude doesn't want to include a fork's functionality, that's very normal in the open source community for people to have strong opinions - such things are required for really cool projects like theirs to get created for free. I don't actually disagree with their logic either, combining duplicates carries high risk of screwing up your ebooks and metadata and losing copies! You have to be careful.

But, there's still usecases. I had one, so I made the tweak to the plugin. Others have usecases too. I'm working right now to get it working with up to date versions of calibre. There was someone else that kindly emailed me to mention another bug that I'm looking at.

As for @kiwidude, don't worry, I won't be making a PR, though i appreciate you linking https://github.com/kiwidude68/calibr...icates-v1.10.7 your github repo, there's lots of really good information there. The primary motivation for me to create my tweak was to try doing some open source work outside of web dev, thanks for creating resources to help people do that! As your code is GPL-3, I'm going to change my repo to be a fork of yours with the same license. I really like GPL-3 as well.

[komali_2]

Sorry to double reply, but it looks like there's a time limit on editing a post.

The fork of kiwidude's excellent repo for finding duplicates that I made a while back has been updated to (hopefully) work on newer versions of Calibre, and also includes the massive improvements kiwidude made to their code in the meantime. https://github.com/komali2/calibre-find-duplicates

Remember that this is only possible because of all of their hard work, credit goes to them!

[BetterRed]

Moderator Notice

@komali_2: See this regarding edits and PMs.

BR

[feuille]

Hello kiwidude,

when Calibre was running in debug mode today, I noticed that an key error is reported in the book_algorithms.py module:

File "calibre_plugins.find_duplicates.book_algorith ms", line 295, in _find_candidate_by_file_size
KeyError: 'mtime'

Statement 295 in version (1, 10, 7) is: mtime = stat_metadata['mtime'].

However, the plugin continued to run and returned a result.

Regards,

[kiwidude]

Originally Posted by feuille

Hello kiwidude,

when Calibre was running in debug mode today, I noticed that an key error is reported in the book_algorithms.py module:

File "calibre_plugins.find_duplicates.book_algorith ms", line 295, in _find_candidate_by_file_size
KeyError: 'mtime'

Statement 295 in version (1, 10, 7) is: mtime = stat_metadata['mtime'].

However, the plugin continued to run and returned a result.

Regards,

Hi fueille,

The only way I can see this happening is if you somehow have invalid metadata in your library for a book format. Perhaps you deleted a book format from disk, but calibre still thinks it exists.

I will tweak the code so the exception won't appear in future, but with the way it is written it would just skip that book format anyways which is what it should do, it is just extra noise in the log.

[kiwidude]

Release Notes
https://github.com/kiwidude68/calibr...icates-v1.10.8