Feature request: adjust warm light

Pjama · 04-30-2022, 07:54 AM

I love using KOReader in two page mode on my jb KOA3! Finally, I have it set up the way I want it.
I used to use it on Kobo, where it had the ability to adjust the warm light by sliding up and down the right hand side of the screen.

Can this be added to the Kindle version?

hius07 · 04-30-2022, 11:43 AM

Wait a little bit
https://github.com/koreader/koreader/pull/9054

Pjama · 04-30-2022, 03:15 PM

Quote:

Originally Posted by hius07

Wait a little bit
https://github.com/koreader/koreader/pull/9054

Oh wow, amazing!

LittleBiG · 05-07-2022, 06:45 AM

Would it be possible to add a Status bar refresh after closing the front light widget? Now the changes are not reflected on the status bar, a manual full refresh or a page turn is necessary.

NiLuJe · 05-07-2022, 06:49 PM

Any and all frontlight changes should immediately notify the footer (with a possible exception of a swipe in the brightness bar), so I'm unclear on what exactly you're doing and why you're talking about *closing* the widget

.

(Also, the exact device you're using would be helpful, as there may be platform-specific quirks involved, especially as far as refresh optimizations are concerned).

LittleBiG · 05-08-2022, 03:52 AM

I deliberately wrote this into this topic, because this is a KO3 with the latest nightly build (0057). The notification you mention doesn't happen at all. I set the frontlight using the Frontlight menu. Kindle Oasis 3 firmware is 5.14.3. but I am not sure if it matters.
The toggle button or the frontlight level change doesn't invoke the status bar refresh. But if I use a gesture for "toggle frontlight", the status bar is refreshed as expected.

pazos · 05-08-2022, 07:04 AM

Quote:

Originally Posted by LittleBiG

I deliberately wrote this into this topic, because this is a KO3 with the latest nightly build (0057). The notification you mention doesn't happen at all. I set the frontlight using the Frontlight menu. Kindle Oasis 3 firmware is 5.14.3. but I am not sure if it matters.
The toggle button or the frontlight level change doesn't invoke the status bar refresh. But if I use a gesture for "toggle frontlight", the status bar is refreshed as expected.

Yup. Currently gestures work (by default: vertical swipe on left to change frontlight, vertical swipe on right to change warmth), but the FL widget doesn't update values.

Patches welcome. In the mean time you can save a few seconds by using gestures directly

NiLuJe · 05-08-2022, 11:39 AM

Huh, so it did.

https://github.com/koreader/koreader/pull/9084

LittleBiG · 05-10-2022, 03:19 AM

Thank you, I can confirm that it works as expected in the today build (63).

04-30-2022, 07:54 AM	#1
Pjama Guru Posts: 667 Karma: 2345678 Join Date: Apr 2016 Location: USA Device: ✍️🏝️♎️ Kobo Clara 2E	Feature request: adjust warm light I love using KOReader in two page mode on my jb KOA3! Finally, I have it set up the way I want it. I used to use it on Kobo, where it had the ability to adjust the warm light by sliding up and down the right hand side of the screen. Can this be added to the Kindle version?

05-07-2022, 06:49 PM	#5
NiLuJe BLAM! Posts: 13,477 Karma: 26012494 Join Date: Jun 2010 Location: Paris, France Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E	Any and all frontlight changes should immediately notify the footer (with a possible exception of a swipe in the brightness bar), so I'm unclear on what exactly you're doing and why you're talking about closing the widget . (Also, the exact device you're using would be helpful, as there may be platform-specific quirks involved, especially as far as refresh optimizations are concerned). Last edited by NiLuJe; 05-07-2022 at 06:51 PM.

05-08-2022, 03:52 AM	#6
LittleBiG Zealot Posts: 122 Karma: 10 Join Date: Nov 2014 Device: Kindle Oasis 3, K4NT, Kobo Mini	I deliberately wrote this into this topic, because this is a KO3 with the latest nightly build (0057). The notification you mention doesn't happen at all. I set the frontlight using the Frontlight menu. Kindle Oasis 3 firmware is 5.14.3. but I am not sure if it matters. The toggle button or the frontlight level change doesn't invoke the status bar refresh. But if I use a gesture for "toggle frontlight", the status bar is refreshed as expected. Last edited by LittleBiG; 05-08-2022 at 04:26 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
to those of you with Oasis 3, question about warm light	Tanyun	Amazon Kindle	4	02-06-2020 08:30 PM
New Oasis with warm light	Deskisamess	News	109	07-30-2019 01:37 PM
Clara Is this the only reader with warm light?	BookCat	Kobo Reader	110	11-10-2018 02:59 PM
Warm or adjustable 'comfort' light	Dino84	Which one should I buy?	2	04-01-2017 03:28 PM
Feature Request - Adjust Gutter Width Between Columns	Noventer	Marvin	0	03-13-2014 07:13 PM

04-30-2022, 11:43 AM	#2
hius07 Wizard Posts: 1,058 Karma: 3581267 Join Date: Sep 2014 Location: Ukraine Device: Kindle PW2, PW3, PW4, Voyage	Wait a little bit https://github.com/koreader/koreader/pull/9054

05-07-2022, 06:45 AM	#4
LittleBiG Zealot Posts: 122 Karma: 10 Join Date: Nov 2014 Device: Kindle Oasis 3, K4NT, Kobo Mini	Would it be possible to add a Status bar refresh after closing the front light widget? Now the changes are not reflected on the status bar, a manual full refresh or a page turn is necessary.

05-08-2022, 11:39 AM	#8
NiLuJe BLAM! Posts: 13,477 Karma: 26012494 Join Date: Jun 2010 Location: Paris, France Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E	Huh, so it did. https://github.com/koreader/koreader/pull/9084

05-10-2022, 03:19 AM	#9
LittleBiG Zealot Posts: 122 Karma: 10 Join Date: Nov 2014 Device: Kindle Oasis 3, K4NT, Kobo Mini	Thank you, I can confirm that it works as expected in the today build (63).