Sigil-1.5.1 Released

[DNSB]

Originally Posted by Vanguard3000

Hi, folks! Overall I'm enjoying the enhancements for 1.5.1, but I'm having an issue with the "Delete Unused Stylesheet Selectors" not working as expected. I've got an ePub with multiple stylesheets (a global, and several file-specific), and have removed all instances of most of the styles contained therein, but the delete function does nothing, despite all unused selectors being checked.

I've confirmed the styles aren't in use by a search, through the reports screen, and by deleting all xhtml files except a blank one, and clicking the "Delete Marked Styles" button seems to fail silently (the dialog dismissed but nothing else).

Anyone else seeing this issue? Aside from that, when it worked, it was awesome. I like that it could also remove header-based style definitions.

I just tested this on a couple of epubs I was cleaning up. Using the Delete Unused Stylesheet Selectors tool selected the same unused selectors as shown in the CSS Selectors Reports and the cssRemoveUnusedSelectors plugin. After clicking on Delete Marked Styles, eyeballing the 3 stylesheets showed styles have been removed. Running cssRemoveUnusedSelectors again show on unused selectors.

Both the epubs had relatively simple stylesheets with no overly complex selectors. I really could see no reason for having 3 stylesheets.

[roger64]

Originally Posted by DiapDealer

... I'm sure he'll get around to it.

You must be right. These times, I'm paranoid...

[Vanguard3000]

Originally Posted by DNSB

I really could see no reason for having 3 stylesheets.

Neither can I. I always simplify retail ebooks I buy, and it's got about ten stylesheets.

[KevinH]

Please provide a working test case that shows this. The only known bug (already fixed in master) is that the removal will fail if after removing ALL unused selectors, it would leave a completely empty stylesheet.

BeckyEbook already reported that bug and it has already been fixed. To workaround it, simply add a css comment someplace at the top of the css stylesheet so that it would not end up completely empty.

If you are seeing a different bug, I could really use a testcase that shows the bug.

Thanks,

KevinH

Originally Posted by Vanguard3000

Hi, folks! Overall I'm enjoying the enhancements for 1.5.1, but I'm having an issue with the "Delete Unused Stylesheet Selectors" not working as expected. I've got an ePub with multiple stylesheets (a global, and several file-specific), and have removed all instances of most of the styles contained therein, but the delete function does nothing, despite all unused selectors being checked.

I've confirmed the styles aren't in use by a search, through the reports screen, and by deleting all xhtml files except a blank one, and clicking the "Delete Marked Styles" button seems to fail silently (the dialog dismissed but nothing else).

Because I had updates from 1.4.3, I tried uninstallling and reinstalling fresh, and restarting, and it worked briefly, but the issue seems to be back again.

Anyone else seeing this issue? Aside from that, when it worked, it was awesome. I like that it could also remove header-based style definitions.

[Vanguard3000]

Originally Posted by KevinH

Please provide a working test case that shows this.

Here you go - thanks for looking into this for me. I've again uninstalled and reinstalled Sigil, making sure to remove appData and program files folders and the issue persists for me.

[KevinH]

Sigil only searches the stylesheets for selectors that are actually linked to an xhtml file.

None of your stylesheets are linked to anything and therefore none of the selectors are tested (they can only be tested to be present in an xhtml file that links to them).

If you want to see which stylesheets are used or not, simply use the Reports CSS files, which will tell you none of your css files are actually used (linked into any xhtml file).

If I link them all in, running Remove Unused Selectors would remove all of the selectors inside each stylesheets leaving them all completely empty (except for your first one as @page is not a selector). This is exactly the bug I just explained that was already found and fixed in master.

So link all your stylesheets into the one xhtml file. Edit each stylesheet and add
/*css*/
to the top of each css file so that they are not left blank (to workaround the bug that has already been fixed in master) and give it a try. You will see all true selectors are now removed (leaving just the comment) and the first one still has @page since it is not a selector.

Hope this helps,

Kevin

[Vanguard3000]

Okay, I understand now. Adding the comment works as you describe. Thanks for your help.

[eschwartz]

Originally Posted by roger64

Hi

Sorry if this does not belong to this thread. Usually, Eli Schwartz publishes quite quickly a binary version of Sigil for Archlinux users. He informed this forum over a week ago that he would wait to provide a binary release of 1.5.1. (and Calibre btw) but, as of today, still failed to do so. A PageEdit version had been published earlier.

Has somebody more info about this?

https://lists.archlinux.org/pipermai...ch/030402.html

I'm back now, catching back up on updates. The new sigil release is currently in the process of building.

[roger64]

Thank you for your so helpful work.

"Un seul être vous manque et tout est dépeuplé"

[Skydancer]

While waiting for Arch/Manjaro Linux to release Sigil 1.5.1 to their repositories I compiled it form source myself. Everything seems to work OK, but later I noticed that there is some other stuff on the GitHub: sigil-query, cssparser, dulwich, sigil-gumbo etc. Is any significant functionality missing from Sigil without those modules?

[DiapDealer]

If you built Sigil and it works, then you built sogil-gumbo. It's integral and Sigil will not build or function at all without it. The only two pieces you would even have a say in whether or not you could build/use Sigil without them is css-parser and dulwich. Both provide functionality that would be missing from Sigil without them. The Arch package (which has already been updated to 1.5.1) includes all of the things you mentioned as required dependencies.

To be perfectly clear: only two of the items you mentioned are actually external modules (css-parser and dulwich are both python modules that Sigil requires for functionality). Everything else is integral C/C++ source code included with Sigil.

[Notjohn]

>No one is finally dead until the ripples they cause in the world die away... -- Reaper Man -- Terry Pratchett

Something of a theft from Sartre's "No Exit".

[DiapDealer]

Ummm...