[GUI Plugin] Quality Check

[kiwidude]

@loximuthal - are your false hits with the very latest version on this thread of 1.8.3? That had a fix specifically for issues to do with casing and this issue. If you are still having it, PM me or email me a link to an epub I can test on that is giving you incorrect results.

Don't believe the casing on the right-hand side of that log message btw. That is after I have already converted the whole content of the html page to lowercase for comparison purposes. So at the time I print that log message I don't have what the "actual" case of the link is, only the lowercase version of it if that makes sense.

[kiwidude]

@JayLaFunk - yeah I understand - you are effectively going direct to the library folders, and not using calibre's export capabilities so hence the logic to replace the cover is not getting an opportunity to run.

Incidentally I noticed that when I ran the Update Metadata feature of Modify ePub that it *did not* replace the cover with an SVG one so that is something to take a look at too. As once you have a QC check to tell you which books need SVG covers you will want an easy way to add them.

[DoctorOhh]

Originally Posted by kiwidude

Incidentally I noticed that when I ran the Update Metadata feature of Modify ePub that it *did not* replace the cover with an SVG one so that is something to take a look at too.

Are you saying you don't use Kovid's svg default wrap around the jpg when adding covers? JSWolf will be so happy.

[loximuthal]

@kiwidude - I am indeed running the latest plugin. I was getting the same results before I updated the plugin as well. I think I understand what you mean about the casing in the log file, but now I am even more perplexed.

I'm at work at the moment and have no access to my calibre. I'll drop you a line later today so you can follow up. Thanks.

[JayLaFunk]

Originally Posted by kiwidude

@JayLaFunk - As once you have a QC check to tell you which books need SVG covers you will want an easy way to add them.

Yes Please

[kiwidude]

loximuthal is reporting an issue with the "Check broken image links" which I am unable to replicate. There are only two explanations I can think of. The first is that there is some sort of OS specific issue to do with paths.

Can one user who has a Mac and one with a Linux box please do the following:

(1) Install the attached special debug version of Quality Check
(2) Put the attached test epub in your library
(3) Set your search scope to "Selection" (or set a search restriction) so you are only checking this book
(4) Run the "Check broken image links" feaure on this book
(5) Post the results of the log in a spoiler.

My test book has two image links in it, one valid and one invalid. So it should report it as invalid (regardless of OS), but it is the log output I am specifically interested in at this point.

Thanks.

[PeterT]

Linux; Calibre 0.8.51

Spoiler:

Test / kiwidude 
Resource: cover.jpeg with extension: .jpeg 
	Storing image for lookup as: cover.jpeg 
Resource: OEBPS/Text/book_content.html with extension: .html 
Resource: page_styles.css with extension: .css 
Resource: stylesheet.css with extension: .css 
Resource: titlepage.xhtml with extension: .xhtml 
Resource: toc.ncx with extension: .ncx 
Image map: {u'cover.jpeg': u'cover.jpeg'} 
Searching: OEBPS/Text/book_content.html 
	Image link found: ../images/nonexistent.jpeg - in - OEBPS/Text/book_content.html 
	  Relative path: oebps/images/nonexistent.jpeg 
	  Normalised name: oebps/images/nonexistent.jpeg 
	Broken image link in: OEBPS/Text/book_content.html  of  ../images/nonexistent.jpeg 
Searching: titlepage.xhtml 
	Image link found: cover.jpeg - in - titlepage.xhtml 
	  Relative path: cover.jpeg 
	  Normalised name: cover.jpeg

[kiwidude]

Thx Peter - that is exactly as I would expect, all fine. Now we just need a Mac user...

[GRiker]

Mac OSX: Calibre 0.8.52

Spoiler:

Test / kiwidude
Resource: cover.jpeg with extension: .jpeg
Storing image for lookup as: cover.jpeg
Resource: OEBPS/Text/book_content.html with extension: .html
Resource: page_styles.css with extension: .css
Resource: stylesheet.css with extension: .css
Resource: titlepage.xhtml with extension: .xhtml
Resource: toc.ncx with extension: .ncx
Image map: {u'cover.jpeg': u'cover.jpeg'}
Searching: OEBPS/Text/book_content.html
Image link found: ../images/nonexistent.jpeg - in - OEBPS/Text/book_content.html
Relative path: oebps/images/nonexistent.jpeg
Normalised name: oebps/images/nonexistent.jpeg
Broken image link in: OEBPS/Text/book_content.html of ../images/nonexistent.jpeg
Searching: titlepage.xhtml
Image link found: cover.jpeg - in - titlepage.xhtml
Relative path: cover.jpeg
Normalised name: cover.jpeg

G

[kiwidude]

Thanks Griker. That's exactly as I would expect too. Incidentally as a Mac user, have you had any concerns from using this check against your library of noticing books appearing on the list with links that are actually fine?

I mentioned in my post above that there were two possible reasons. The second reason being that loximuthal has done something funky . For instance the epub PM'd to me is *not* the same as the epub in the log he also sent to me - it is missing a whole load of content pages that are shown in the log. Why would that be - I suspect (guessing) loximuthal stripped a whole lot of content out of the ePub before sending to me out of copyright concerns or something (probably using Sigil) and that in itself would mean stuff got rewritten into the ePub/manifest changing it.

So... unless GRiker or anyone else reports there is definitely a problem - loximuthal the ball is back in your court. Does the output you get using the debug version above match the same as GRiker? And can you send me a link to an *untouched* version of one of those epubs that show in your log?

[JayLaFunk]

Originally Posted by kiwidude

Thanks Griker. That's exactly as I would expect too. Incidentally as a Mac user, have you had any concerns from using this check against your library of noticing books appearing on the list with links that are actually fine?

I mentioned in my post above that there were two possible reasons. The second reason being that JayLaFunk has done something funky . For instance the epub PM'd to me is *not* the same as the epub in the log he also sent to me - it is missing a whole load of content pages that are shown in the log. Why would that be - I suspect (guessing) JayLaFunk stripped a whole lot of content out of the ePub before sending to me out of copyright concerns or something (probably using Sigil) and that in itself would mean stuff got rewritten into the ePub/manifest changing it.

So... unless GRiker or anyone else reports there is definitely a problem - JayLaFunk the ball is back in your court. Does the output you get using the debug version above match the same as GRiker? And can you send me a link to an *untouched* version of one of those epubs that show in your log?

I'm confused here as I have not sent a epub to you

[kiwidude]

My sincere apologies JayLaFunk - I should have said "loximuthal" rather than your name... sorry for the confusion. My brain overflowed with two threads...

[JayLaFunk]

Originally Posted by kiwidude

My sincere apologies JayLaFunk - I should have said "loximuthal" rather than your name... sorry for the confusion. My brain overflowed with two threads...

No Probs , was thinking I had a bit too much of that 12 year old malt last night

[kiwidude]

I wish I could blame alcohol - sadly I think it is a combination of senility and juggling way too many things at once. All the while rushing to get them "done" so my whole weekend doesn't disappear yet again like they all have lately...

[GRiker]

Originally Posted by kiwidude

Thanks Griker. That's exactly as I would expect too. Incidentally as a Mac user, have you had any concerns from using this check against your library of noticing books appearing on the list with links that are actually fine?

I haven't been using the plugin actively - I just saw the request to test with the two files, and jumped in. If there are particular test you'd like me to run, detail them to me and I will do so.

G