[FileType Plugin] GetFileName

[Terisa de morgan]

Originally Posted by BetterRed

As I understand Terisa's latest post - the 'beta' version she attached will store the plugin preferences (the columns names) in a plugin specific json file in the configuration folder rather than the preferences table in the database - which means GFN will have no need to access the in-memory database.

BR

Aside of the places where it's allowed (as any other plugin), at postadd, when no copy is necessary.

[Immelmann67]

Originally Posted by Terisa de morgan

This is a beta option that:

• stores preference in json file (through library name, as getting library id is only for calibre 3)
• allegedly get the preferences changes without restart

As there is no database copy, I hope @Immelmann67 is solved. If I have no comments, I'll make it release version on Wednesday.

Hi Terisa,

Thank you for trying to fix the problem- I downloaded and installed the new version (0.0.13), restarted (as suggested by BR), and attempted to configure the plugin.
After a few seconds, I got the following error:

calibre, version 3.9.0
ERROR: Unhandled exception: <b>MemoryError</b>:

calibre 3.9 Portable embedded-python: True is64bit: False
Windows-7-6.1.7601-SP1 Windows ('32bit', 'WindowsPE')
32bit process running on 64bit windows
('Windows', '7', '6.1.7601')
Python 2.7.12+
Windows: ('7', '6.1.7601', 'SP1', u'Multiprocessor Free')
Interface language: en_GB
Successfully initialized third party plugins: Save To Format (0, 0, 6) && Clean Metadata (0, 0, 6) && Generate Cover (1, 5, 21) && KindleUnpack - The Plugin (0, 81, 5) && Audit Log (1, 0, 8) && Embed Comic Metadata (1, 3, 8) && Reading List (1, 6, 6) && Fantastic Fiction Adults (1, 0, 4) && Similar Stories (1, 0, 58) && Fantastic Fiction (1, 2, 0) && Quick Preferences (1, 4, 1) && Open With (1, 5, 10) && Goodreads (1, 1, 12) && Favourites Menu (1, 0, 4) && GetFileName (0, 0, 13) && Extract ISBN (1, 4, 4) && Job Spy (1, 0, 80) && FictionDB (1, 0, 10) && Kindle Collections (1, 7, 17) && Count Pages (1, 8, 0) && Manage Series (1, 2, 8) && Find Duplicates (1, 6, 3) && BOL_DE (0, 7, 5) && BOL_NL (3, 8, 16) && User Category (1, 5, 3) && Modify ePub (1, 3, 13) && Resize Cover (1, 0, 2) && Quality Check (1, 9, 11) && Barnes & Noble (1, 2, 14) && View Manager (1, 4, 3)
Traceback (most recent call last):
File "site-packages\calibre\gui2\dialogs\plugin_updater.py", line 804, in _configure_clicked
File "site-packages\calibre\customize\__init__.py", line 155, in do_user_config
File "calibre_plugins.getfilename.__init__", line 298, in config_widget
File "calibre_plugins.getfilename.config", line 153, in __init__
File "site-packages\calibre\library\__init__.py", line 11, in db
File "site-packages\calibre\db\legacy.py", line 83, in __init__
File "site-packages\calibre\db\cache.py", line 354, in init
File "site-packages\calibre\db\backend.py", line 1260, in read_tables
File "site-packages\calibre\db\tables.py", line 110, in read
MemoryError

Which probably means I won't be able to use the plugin.
Thank you again for trying, though.
I67

[Terisa de morgan]

I'll try to check it, but, at this moment, I'm not aware of any copy. I'll be back if I find something.

[Terisa de morgan]

Does this only happen with this plugin? Can you configure any other one?

[BetterRed]

Originally Posted by Terisa de morgan

If there is no json information for that library, they will be copied from library preferences to json (no removing, they don't hurt).

FYI - for those who don't like clutter, there's a Job Spy tool for removing 'redundant' plugin preferences from a library database.

BR

[Immelmann67]

Originally Posted by Terisa de morgan

Does this only happen with this plugin? Can you configure any other one?

Hi Terisa, this is the only one I'm having problems with!

[JSWolf]

Try the 64-bit version. It would be useful to know if it's Calibre or something else.

[BetterRed]

Originally Posted by Immelmann67

Hi Terisa,

Thank you for trying to fix the problem- I downloaded and installed the new version (0.0.13), restarted (as suggested by BR), and attempted to configure the plugin.
After a few seconds, I got the following error:

Which probably means I won't be able to use the plugin.
Thank you again for trying, though.

@Immelmann67 - I just added the new version of GFN into a fresh portable install, did a restart, configured GFN, and imported some books - no problems.

Try creating a fresh library, then add the columns you want GFN to use, configure GFN, and add a book or two. If that works then it suggests it's something to do with library, probably it's size and 32bit. If you created a 64bit portable as previously suggested and it works then that would be proof positive.

Perhaps a library with 149,000 books, some custom columns, and quite a few plugins is sailing close too the wind for 32 bit, and GFN is the puff that dismasted the good ship lollipop

BR

[Terisa de morgan]

Originally Posted by Immelmann67

Hi Terisa,

Thank you for trying to fix the problem- I downloaded and installed the new version (0.0.13), restarted (as suggested by BR), and attempted to configure the plugin.
After a few seconds, I got the following error:
Which probably means I won't be able to use the plugin.
Thank you again for trying, though.
I67

Problem is, that code is for recovering database prefs, if any, and it doesn't make any copy I'm aware of. The code is:

            from calibre.library import db

            self.prefs = get_library_config(db())

The code is crashing at second line. This is necessary for the use case where there is a possible migration. So, I don't know how to change it.

[kovidgoyal]

@Terisa: Not sure why you need to read preferences in the __init__ method. Instead read the preferences in the postadd/post_import callbacks using the provided db object. Calling db() will create a copy of the entire library in memory.

[Terisa de morgan]

Originally Posted by kovidgoyal

@Terisa: Not sure why you need to read preferences in the __init__ method. Instead read the preferences in the postadd/post_import callbacks using the provided db object. Calling db() will create a copy of the entire library in memory.

@Kovid: this call is used for configuring the plugin, so it cannot be at postadd/postimport but when the user requests the configuration. Is there any way that, in the config module, the database can be loaded?

[kovidgoyal]

Use the code I posted earlier, falling back to calling db() when get_gui() returns None (which means you are not in a GUI context).

[Terisa de morgan]

Originally Posted by kovidgoyal

Use the code I posted earlier, falling back to calling db() when get_gui() returns None (which means you are not in a GUI context).

OK, thank you very much, I'll do that. Sorry for my mistakes, but I don't know a lot about calibre code.

[kovidgoyal]

No worries, calibre is huge

[Terisa de morgan]

@Immelmann67, can you check this beta? I've included kovid's solution.