Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Sigil > Plugins

Notices

Reply
 
Thread Tools Search this Thread
Old 10-12-2017, 09:31 PM   #1
slowsmile
Witchman
slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.
 
Posts: 240
Karma: 563708
Join Date: May 2013
Location: Philippines
Device: Android S5
Easier access to plugin prefs

Would it be possible to have a button in the Sigil toolbar which, when clicked, allows selection and display -- via dialog + Sigil tab -- of the selected plugin prefs .json file for editing. Apps like Sublime already have this facility for setting their own prefs.

This change would make it much easier for Sigil users to access and set plugin prefs(where applicable). Is this possible?

Last edited by slowsmile; 10-12-2017 at 09:42 PM.
slowsmile is offline   Reply With Quote
Advert
Old 10-12-2017, 09:44 PM   #2
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 2,614
Karma: 780906
Join Date: Nov 2009
Device: many
The plugin code should be separate from the Sigil codebase to the extent possible. So I recommend plugin developers build a simple gui with pyqt or the built in python gui to handle editing their own prefs. We could create a canned generic module that should work the same for any plugin.

I do not think this role should be done by Sigil itself.

Last edited by KevinH; 10-12-2017 at 10:29 PM.
KevinH is offline   Reply With Quote
Old 10-12-2017, 09:56 PM   #3
slowsmile
Witchman
slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.
 
Posts: 240
Karma: 563708
Join Date: May 2013
Location: Philippines
Device: Android S5
duplicate

Last edited by slowsmile; 10-12-2017 at 10:06 PM.
slowsmile is offline   Reply With Quote
Old 10-12-2017, 10:02 PM   #4
slowsmile
Witchman
slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.
 
Posts: 240
Karma: 563708
Join Date: May 2013
Location: Philippines
Device: Android S5
duplicate

Last edited by slowsmile; 10-12-2017 at 10:07 PM.
slowsmile is offline   Reply With Quote
Old 10-12-2017, 10:09 PM   #5
slowsmile
Witchman
slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.
 
Posts: 240
Karma: 563708
Join Date: May 2013
Location: Philippines
Device: Android S5
Thanks Kevin. I'll look into writing a plugin for this when I'm up to speed on PyQT. Can it be done in Tkinter or is tk usage now discouraged for plugins?
slowsmile is offline   Reply With Quote
Old 10-12-2017, 10:31 PM   #6
KevinH
Wizard
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 2,614
Karma: 780906
Join Date: Nov 2009
Device: many
Both tkinter and pyqt are supported and should continue to be for the forseeable future.
KevinH is offline   Reply With Quote
Old 10-12-2017, 10:35 PM   #7
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 17,443
Karma: 90388224
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
I've no plans to remove tkinter at this time.

Many of my plugins include gui code (both tkinter and pyqt) to allow the user to edit the plugin's preferences if you're looking for examples.
DiapDealer is online now   Reply With Quote
Old 10-13-2017, 02:01 AM   #8
slowsmile
Witchman
slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.
 
Posts: 240
Karma: 563708
Join Date: May 2013
Location: Philippines
Device: Android S5
Thanks for that, and I will have a peek at DiapDealer's pyqt examples for sure. I already have Winpython 3.4(with PyQT5 and Qt Designer) installed on my computer.
slowsmile is offline   Reply With Quote
Old 10-13-2017, 03:52 AM   #9
Doitsu
Wizard
Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.
 
Doitsu's Avatar
 
Posts: 3,950
Karma: 11600000
Join Date: Dec 2010
Device: Kindle PW2
Quote:
Originally Posted by slowsmile View Post
Would it be possible to have a button in the Sigil toolbar which, when clicked, allows selection and display -- via dialog + Sigil tab -- of the selected plugin prefs .json file for editing.
Ideally, plugin preferences should be updated via a GUI, unless they're advanced settings that rarely need to be changed.

BTW, users can easily access the plugin_prefs folder via:

Edit > Preferences > Open Preferences Location > plugins_prefs

Windows users can also access a specific preferences folder via the Windows Run dialog box. For example:
  1. Presss WIN+R.
  2. Copy and paste %LOCALAPPDATA%\sigil-ebook\sigil\plugins_prefs\OpenDocHTMLImport and hit Return.
This'll display the preferences folder for your OpenDocHTMLImport plugin.
Doitsu is offline   Reply With Quote
Old 10-19-2017, 12:02 PM   #10
AlanHK
Addict
AlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheese
 
AlanHK's Avatar
 
Posts: 348
Karma: 1002
Join Date: Apr 2014
Device: PW-3, Android phone
Quote:
Originally Posted by Doitsu View Post
Ideally, plugin preferences should be updated via a GUI, unless they're advanced settings that rarely need to be changed.
No even then. If you edit the json, changes will be lost if you upgrade the plugin; the new json just overwrites it.
AlanHK is offline   Reply With Quote
Old 10-19-2017, 12:14 PM   #11
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 17,443
Karma: 90388224
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by AlanHK View Post
No even then. If you edit the json, changes will be lost if you upgrade the plugin; the new json just overwrites it.
No it doesn't. The plugin framework only creates the json file if one isn't already present. If individual settings within the json are being changed/reset when a plugin is updated, then that's on the plugin dev. My plugins' preferences will certainly persist through a plugin update--no matter how the json file gets edited. If they don't, then I need to know.
DiapDealer is online now   Reply With Quote
Old 10-19-2017, 08:47 PM   #12
slowsmile
Witchman
slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.
 
Posts: 240
Karma: 563708
Join Date: May 2013
Location: Philippines
Device: Android S5
As DiapDealer says, the json file is not deleted when you update a plugin -- it is preserved in a separate plugin_prefs directory. If you want to reset plugin prefs to its default or initial settings then all you have to do is just delete the json file or delete its directory from plugin_prefs.
slowsmile is offline   Reply With Quote
Old 10-20-2017, 01:38 AM   #13
AlanHK
Addict
AlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheese
 
AlanHK's Avatar
 
Posts: 348
Karma: 1002
Join Date: Apr 2014
Device: PW-3, Android phone
Quote:
Originally Posted by DiapDealer View Post
No it doesn't. The plugin framework only creates the json file if one isn't already present.
I lost my settings when I updated the Kindlegen plugin.
Had to re-edit the json to change the default thumbnail size.
Unless I screwed up removing the older version first.

Last edited by AlanHK; 10-20-2017 at 01:42 AM.
AlanHK is offline   Reply With Quote
Old 10-20-2017, 02:43 AM   #14
Doitsu
Wizard
Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.Doitsu ought to be getting tired of karma fortunes by now.
 
Doitsu's Avatar
 
Posts: 3,950
Karma: 11600000
Join Date: Dec 2010
Device: Kindle PW2
Quote:
Originally Posted by AlanHK View Post
I lost my settings when I updated the Kindlegen plugin.
Older KindleGen versions used an .ini file whose settings were indeed lost when I switched to json-based preferences.

Quote:
Originally Posted by AlanHK View Post
Had to re-edit the json to change the default thumbnail size.
The default thumbnail size was never a preference setting; changing it always required modifying plugin.py.
Doitsu is offline   Reply With Quote
Old 10-22-2017, 02:42 PM   #15
AlanHK
Addict
AlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheeseAlanHK can extract oil from cheese
 
AlanHK's Avatar
 
Posts: 348
Karma: 1002
Join Date: Apr 2014
Device: PW-3, Android phone
Quote:
Originally Posted by Doitsu View Post
The default thumbnail size was never a preference setting; changing it always required modifying plugin.py.
Sorry; yes it was in plugin.py, not the json.
AlanHK is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Prefs Error MrKonan Calibre 2 10-07-2017 03:39 AM
Sync Calibre Prefs between Win 10 and macOS Sierra saluli Library Management 0 06-05-2017 09:33 PM
Can I access the database from a metadata source plugin? Jellby Development 7 02-03-2015 04:29 AM
PW2 Change Search Prefs stevejoung Kindle Developer's Corner 12 10-10-2014 08:30 AM
Where are toolbar prefs saved? copyrite Calibre 2 05-01-2014 01:44 PM


All times are GMT -4. The time now is 06:15 AM.


MobileRead.com is a privately owned, operated and funded community.