Sigil-1.6.0 Released - Page 5

DiapDealer · 06-10-2021, 12:07 PM

Quote:

Originally Posted by Tex2002ans

It even happens back in Sigil 0.9.14, so it has existed for a while.

Thanks for checking. I suspected it wasn't new at all. Might be something in my refactored Heading QToolButton code to eliminate the deprecated QSignalMapper. But the very similarly reworked Case QToolButton code still works as it should, sooooo. Gotta dig deeper.

DiapDealer · 06-10-2021, 01:08 PM

Got an idea what it is, but I'm limited to looking at code on github at the moment. Once a new tag pair has been encountered after an hr tag, the problem is eliminated again.

KevinH · 06-10-2021, 01:57 PM

You have to be on bare text with no tag , a heading tag, or a paragraph tag for the heading tool to work. It will not replace a hr tag if that is what you are trying.

KevinH · 06-10-2021, 01:59 PM

Still not exactly sure what is going on? Check out those actions being enabled or disabled?

Okay, I can recreate this as well. The enable code seems to falter because hr is a self closing tag.

If I replace <hr/> with <hr></hr> (legal in xhtml) then it all functions just fine.

I tried with other normally self closed tags like <img/> and it functioned just fine.

The problem only seems to happen with hr tags that are single. I wonder if the code is seeing a two character tag starting with h and getting confused with it and headers?

Edit: After more tests it only does not work with hr that is self closed. It works after a self-closed br and even made up self-closed tags like hrr or vhr or h or even hv.

The problem seems to be specific to self-closed hr tags only.

That is very strange!

DiapDealer · 06-10-2021, 02:17 PM

Quote:

Originally Posted by KevinH

The problem only seems to happen with hr tags that are single. I wonder if the code is seeing a two character tag starting with h and getting confused with it and headers?

That's exactly what's happening.

https://github.com/Sigil-Ebook/Sigil...ndow.cpp#L3701

https://github.com/Sigil-Ebook/Sigil...ndow.cpp#L5073

I'm just not certain why tab->GetCaretElementName() seems to be returning hr when the cursor is clearly outside of the hr tag.

KevinH · 06-10-2021, 02:35 PM

I think I have fixed this. The actual problem is that BLOCK_LEVEL_TAGS defined in XhtmlDoc.cpp includes "hr" as a block level stopping point but the code in CodeView FormatBlock did not handle the possibly of a BLOCK_LEVEL_TAGS being self-closed. None of the others are self-closing.

I just pushed a fix for this to master which seems to work.

Please give this a try.

DiapDealer · 06-10-2021, 05:45 PM

Quote:

Originally Posted by KevinH

Please give this a try.

Seems to do the trick in my testing.

KevinH · 06-10-2021, 06:07 PM

That is good to know. Especially since that bug has existed for so long!

BetterRed · 06-19-2021, 08:58 PM

Yesterday I bit the bullet and upgraded from 1.0 to 1.6.

Well done to K & D, and thanks to everyone else for testing changes and making suggestions etc.

Couple of trivial UI questions. As can be seen from the attachment I don't use toolbars.

Would it be possible to add Preview to the main menu, with Inspect, Select All, Copy and Refresh as actions, and make the Preview toolbar optional via another checkbox in View->Toolbars - then I can get rid of it 🙃

There's a black bar alongside the Preview toolbar, looks a bit like a text input widget, does it have any purpose or am I right in guessing it's a Qt toolbar artefact.

BR

KevinH · 06-19-2021, 09:08 PM

No, it is a loading progress bar. You can generally only see it work when loading a huge xhtml file (think an entire ebook in one xhtml). For most normal xhtml files it goes so fast you do not see it work. But when people load larger files they need feedback on Previews progress just like a browser would have.

That toolbar is specific to the Preview Dock widget and not to Sigil in general.

How are those icons any different than the buttons and check boxes and things in other dockwidgets like F&R, or the BookBrowser? Or any other button in any of the dialogs? They take up very little room and are typically only used for very specific puposes in that DockWidget where menu's are not typically used.

BetterRed · 06-20-2021, 12:51 AM

Can you give me a direct link to the .rcc file indicated in the attachment; not sure what 'this repo's releases' means - pretty sure its nothing to do with a repurchase agreement for US Treasury bonds

Thanks BR

BeckyEbook · 06-20-2021, 05:25 AM

https://github.com/Sigil-Ebook/IconThemes/releases

Use material-gray.rcc

EDIT.
You can "hidden" these icons –> use color for icons == color of background toolbar (attached file)
1. Resize icons to minimal
2. Enable custom icons
3. Download and extract file custom_icon_theme.rcc and place it in Sigil Preferences Folder

KevinH · 06-20-2021, 08:44 AM

If you decide to follow BeckyEbook's method above, we may be able to register the Preview actions for Inspect, Refresh, Copy, Select All so that keyboard shortcuts could be assigned to them, would that help?

BetterRed · 06-20-2021, 07:37 PM

Thanks Becky, Kevin

The material gray theme is fine*, particularly since I found the icon size slider

@Kevin - only add shortcuts if it is easy, but don't assign any sequences.

BR

* should be renamed to grey-flannel and be the default theme

06-10-2021, 01:08 PM	#62
DiapDealer Grand Sorcerer Posts: 27,550 Karma: 193191846 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Got an idea what it is, but I'm limited to looking at code on github at the moment. Once a new tag pair has been encountered after an hr tag, the problem is eliminated again. Last edited by DiapDealer; 06-10-2021 at 01:35 PM.

06-10-2021, 01:59 PM	#64
KevinH Sigil Developer Posts: 7,645 Karma: 5433388 Join Date: Nov 2009 Device: many	Still not exactly sure what is going on? Check out those actions being enabled or disabled? Okay, I can recreate this as well. The enable code seems to falter because hr is a self closing tag. If I replace <hr/> with <hr></hr> (legal in xhtml) then it all functions just fine. I tried with other normally self closed tags like <img/> and it functioned just fine. The problem only seems to happen with hr tags that are single. I wonder if the code is seeing a two character tag starting with h and getting confused with it and headers? Edit: After more tests it only does not work with hr that is self closed. It works after a self-closed br and even made up self-closed tags like hrr or vhr or h or even hv. The problem seems to be specific to self-closed hr tags only. That is very strange! Last edited by KevinH; 06-10-2021 at 02:17 PM.

06-19-2021, 08:58 PM	#69
BetterRed null operator (he/him) Posts: 20,572 Karma: 26954694 Join Date: Mar 2012 Location: Sydney Australia Device: none	Yesterday I bit the bullet and upgraded from 1.0 to 1.6. Well done to K & D, and thanks to everyone else for testing changes and making suggestions etc. Couple of trivial UI questions. As can be seen from the attachment I don't use toolbars. Would it be possible to add Preview to the main menu, with Inspect, Select All, Copy and Refresh as actions, and make the Preview toolbar optional via another checkbox in View->Toolbars - then I can get rid of it 🙃 There's a black bar alongside the Preview toolbar, looks a bit like a text input widget, does it have any purpose or am I right in guessing it's a Qt toolbar artefact. BR Attached Thumbnails

06-19-2021, 09:08 PM	#70
KevinH Sigil Developer Posts: 7,645 Karma: 5433388 Join Date: Nov 2009 Device: many	No, it is a loading progress bar. You can generally only see it work when loading a huge xhtml file (think an entire ebook in one xhtml). For most normal xhtml files it goes so fast you do not see it work. But when people load larger files they need feedback on Previews progress just like a browser would have. That toolbar is specific to the Preview Dock widget and not to Sigil in general. How are those icons any different than the buttons and check boxes and things in other dockwidgets like F&R, or the BookBrowser? Or any other button in any of the dialogs? They take up very little room and are typically only used for very specific puposes in that DockWidget where menu's are not typically used. Last edited by KevinH; 06-19-2021 at 10:56 PM.

06-20-2021, 12:51 AM	#71
BetterRed null operator (he/him) Posts: 20,572 Karma: 26954694 Join Date: Mar 2012 Location: Sydney Australia Device: none	Can you give me a direct link to the .rcc file indicated in the attachment; not sure what 'this repo's releases' means - pretty sure its nothing to do with a repurchase agreement for US Treasury bonds Thanks BR Attached Thumbnails

06-10-2021, 01:57 PM	#63
KevinH Sigil Developer Posts: 7,645 Karma: 5433388 Join Date: Nov 2009 Device: many	You have to be on bare text with no tag , a heading tag, or a paragraph tag for the heading tool to work. It will not replace a hr tag if that is what you are trying.

06-10-2021, 02:35 PM	#66
KevinH Sigil Developer Posts: 7,645 Karma: 5433388 Join Date: Nov 2009 Device: many	I think I have fixed this. The actual problem is that BLOCK_LEVEL_TAGS defined in XhtmlDoc.cpp includes "hr" as a block level stopping point but the code in CodeView FormatBlock did not handle the possibly of a BLOCK_LEVEL_TAGS being self-closed. None of the others are self-closing. I just pushed a fix for this to master which seems to work. Please give this a try.

06-10-2021, 06:07 PM	#68
KevinH Sigil Developer Posts: 7,645 Karma: 5433388 Join Date: Nov 2009 Device: many	That is good to know. Especially since that bug has existed for so long!

06-20-2021, 08:44 AM	#73
KevinH Sigil Developer Posts: 7,645 Karma: 5433388 Join Date: Nov 2009 Device: many	If you decide to follow BeckyEbook's method above, we may be able to register the Preview actions for Inspect, Refresh, Copy, Select All so that keyboard shortcuts could be assigned to them, would that help?

06-20-2021, 07:37 PM	#74
BetterRed null operator (he/him) Posts: 20,572 Karma: 26954694 Join Date: Mar 2012 Location: Sydney Australia Device: none	Thanks Becky, Kevin The material gray theme is fine, particularly since I found the icon size slider @Kevin - only add shortcuts if it is easy, but don't assign any sequences. BR should be renamed to grey-flannel and be the default theme

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Sigil-0.9.5 Released	KevinH	Sigil	68	04-09-2016 06:30 AM
Sigil-0.9.4 Released	KevinH	Sigil	40	03-26-2016 10:15 AM
Sigil-0.9.3 Released	KevinH	Sigil	56	03-03-2016 06:46 PM
Sigil-0.9.1 Released	KevinH	Sigil	36	12-04-2015 03:00 PM
Sigil-0.8.900 released for testing - Wait for Sigil-0.8.901	KevinH	Sigil	106	10-04-2015 10:41 AM