[GUI Plugin] Reading Goal

[ownedbycats]

Is a 100% rereading book supposed to stay in the rereading section? The statistics show the correct numbers.

[thiago.eec]

This is how it works for now. @Comfy.n also asked me about this.
I was thinking maybe keep on the 'Rereading' shelf while reading, and then migrate to the 'Read' shelf, keeping the counter.

[ownedbycats]

Moving it to the 'read' shelf (perhaps keeping the colour to differentiate) would make sense to me, too.

[ownedbycats]

New bug in the latest stable version: I have two books with two 100% entries that can't be deleted. This results in them to appear as rereading (x1). These are books that I finished in the version before.

Spoiler:

    "8276": {
      "authors": [
        "Marjorie Wilkins Campbell"
      ],
      "date": {
        "__class__": "datetime.datetime",
        "__value__": "2023-08-29T06:49:55+00:00"
      },
      "genre": "Canada, History",
      "last_year_pages": 0,
      "page_count": 176,
      "read_pages": 176,
      "records": {
        "2": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2023-08-28T00:53:20+00:00"
          },
          "read_pages": 146,
          "status": 83
        },
        "3": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2023-08-28T11:55:16.687177+00:00"
          },
          "read_pages": 162,
          "status": 92
        },
        "5": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2023-08-29T06:49:55.789943+00:00"
          },
          "read_pages": 176,
          "status": 100
        },
        "6": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2023-08-29T06:49:55+00:00"
          },
          "read_pages": 176,
          "status": 100
        }
      },
      "reread_count": 1,
      "shelf": "Rereading",
      "status": 100,
      "title": "The Nor'westers",
      "title_sort": "Nor'westers, The"
    },

I think this may be caused by my 'mark as read/abandoned' Action Chain:



I did notice some duplicate entries - my 'set percent read' chain also changes #lastread and #percentread. It hasn't happened in this release though. (I deleted a few - I think that's why 1 and 4 are missing from the records in the json.)

[autolo]

I suspect my Action Chain for finishing a book are the cause of my similar error (books seen as re-reading instead of finished). Posting a screenshot of that one as well to help with troubleshooting.

[Springbok]

I experience the same issue with book appearing in the rereading section.

The problem is rather easy to recreate - it happens every time when you modify the completion date (after the previous edit). Any modification inceases the read book counter of the Reading goal plugin. After playing with this field the shelf shows that I read the book 4 times. It just happens that Action Chain completion action also deals with this field.

Personally I don't care that much about the separate shelf "ReReading" and it seems that there is more hussle with it then the real value coming out of it. It is difficult to differantiate whether the book is read for first time or the second, third etc.

But obviously Terisa may have different view on this subject and I respect that.

[thiago.eec]

Hi, Guys.

Looks like your chains are changing the reading progress (or date) twice.

But this should not be a problem. There is indeed a bug in my code. When adding new records it checks if it isn't the same as before, but there is a catch: it compares the record as whole (date and percentage). Since the date changes (even a few milliseconds, as happened to @ownedbycats), then it looks like a new record. I'll fix this.

About the rereading, I like being able to differentiate and keep a record of rereadings. This is something I always missed when syncing my readings.

Sorry for the mess, but it will be fixed.

[ownedbycats]

Maybe separate 'Rereading' and 'Reread' sections? If this is done, I'd prefer to group Reading/Rereading and Read/Reread together; it's a lbit annoying scrolling down past all my read books to get to the re-readings.

[Springbok]

Thiago
Wouldn't be safer to add an extra user action allowing him/her to mark the record as the book reread? This way the user controls the situation rather than the system.
The design based on assumption that every change to completion date means that the book has been read again may lead to some unexpected results.

[thiago.eec]

Originally Posted by ownedbycats

Maybe separate 'Rereading' and 'Reread' sections? If this is done, I'd prefer to group Reading/Rereading and Read/Reread together; it's a lbit annoying scrolling down past all my read books to get to the re-readings.

Sorry, I didn't understand. Could you elaborate that?

This is how I was planning to do:

1) Position the 'Rereading' shelf just after the 'Reading' shelf
2) Keep the book there just while the reading progress is less than 100%
3) Move the finished books to the 'Read' shelf keeping the reread count

[thiago.eec]

Originally Posted by Springbok

Thiago
Wouldn't be safer to add an extra user action allowing him/her to mark the record as the book reread? This way the user controls the situation rather than the system.

I'd rather have it automated, really.

Originally Posted by Springbok

The design based on assumption that every change to completion date means that the book has been read again may lead to some unexpected results.

The change to the date bumping up the reread count is a bug. It will be fixed.

The trigger for the reread are only two:
- When the book is added in two different years
- When the book has another record past 100%

The last one has a bug right now, like I explained. But I'll fix it.

[Terisa de morgan]

Originally Posted by Springbok

But obviously Terisa may have different view on this subject and I respect that.

About rereading, what I care is that I can add the same books to different years. If it's marked as reread (not rereading ) or in the same list than read, is the same for me.

[Terisa de morgan]

Originally Posted by Springbok

Thiago
Wouldn't be safer to add an extra user action allowing him/her to mark the record as the book reread? This way the user controls the situation rather than the system.
The design based on assumption that every change to completion date means that the book has been read again may lead to some unexpected results.

I prefer automatic mark... specially because I'll mainly be reading it in different years.

[Terisa de morgan]

Originally Posted by thiago.eec

1) Position the 'Rereading' shelf just after the 'Reading' shelf
2) Keep the book there just while the reading progress is less than 100%
3) Move the finished books to the 'Read' shelf keeping the reread count

I like it.

[autolo]

Originally Posted by Terisa de morgan

I like it.

Seems like a good way to do it for me as well.