Windows installer changes in 0.8.3

Manichean · 05-28-2011, 05:07 AM

I saw a note in the changelog saying that the installer will now remember the installation folder for future installations. Does this mean that it will also remember the user-selected installation options, like not having a desktop icon created?

atjnjk · 05-28-2011, 09:50 AM

For now, the windows installer only remembers the installation folder (it only stores this registry key info).

CRussel · 05-28-2011, 09:53 AM

too bad. I would definitely prefer that it not keep adding an icon to my desktop!

PeterT · 05-28-2011, 10:23 AM

Its strange; I have NEVER had any issues with the Calibre installer asking me for install info on upgrades OR creating new icons on the desktop!

theducks · 05-28-2011, 10:35 AM

Quote:

Originally Posted by PeterT

Its strange; I have NEVER had any issues with the Calibre installer asking me for install info on upgrades OR creating new icons on the desktop!

That is because you use a default install

The problem arises when the user uses a Advanced Install'. Nothing was remembered from session to session.
Now, the Calibre program location will be remembered, preventing the accidental alternate location install. The next phase is to remember the other preferences, like no desktop Icon... (I move mine to the Quick Launch or pin to the Menubar in Ubuntu)

kovidgoyal · 05-28-2011, 11:47 AM

Quote:

Originally Posted by Manichean

I saw a note in the changelog saying that the installer will now remember the installation folder for future installations. Does this mean that it will also remember the user-selected installation options, like not having a desktop icon created?

No only the install path. I found some code floating around on the net that showed how to do it for the IP, which enabled me to implement it in a couple of hours.

Manichean · 05-28-2011, 12:55 PM

Okay, thanks.

dwig · 05-29-2011, 10:32 AM

Quote:

Originally Posted by kovidgoyal

No only the install path. I found some code floating around on the net that showed how to do it for the IP, which enabled me to implement it in a couple of hours.

Thanks for the improvement.

Feature Request: Only create a Desktop shortcut when doing an initial install or a custom install to a new location.

Set a flag when the installer encounters a pre-existing install location recorded in the Registry and it is installing to that location. Then later when it gets to the point of creating the Desktop icon test the state of the flag. If the flag has been set, skip creating the icon on the assumption that either one already exists or the user doesn't want one and has deleted the one from the original install.

itimpi · 05-29-2011, 10:46 AM

I disagree - that seems over-complicated. A much better improvement will be to simply remember all the settings from the last install and make these the new default settings.

alansplace · 05-29-2011, 12:29 PM

Quote:

Originally Posted by dwig

Thanks for the improvement.

Feature Request: Only create a Desktop shortcut when doing an initial install or a custom install to a new location.

Set a flag when the installer encounters a pre-existing install location recorded in the Registry and it is installing to that location. Then later when it gets to the point of creating the Desktop icon test the state of the flag. If the flag has been set, skip creating the icon on the assumption that either one already exists or the user doesn't want one and has deleted the one from the original install.

Quote:

Originally Posted by itimpi

I disagree - that seems over-complicated. A much better improvement will be to simply remember all the settings from the last install and make these the new default settings.

how about a checkbox on the install applet for 'install a deskop icon'?

kovidgoyal · 05-29-2011, 01:07 PM

I added code to remember all the remaining user controlled settings. Of course, that means that the stupid microsoft installer waits even longer at the start of the install saying its "Migrating features from related products". Sigh.

alansplace · 05-29-2011, 02:27 PM

Quote:

Originally Posted by kovidgoyal

I added code to remember all the remaining user controlled settings. Of course, that means that the stupid microsoft installer waits even longer at the start of the install saying its "Migrating features from related products". Sigh.

thanks for that, wow, i'm impressed (and grateful)!

itimpi · 05-29-2011, 03:31 PM

Quote:

Originally Posted by alansplace

how about a checkbox on the install applet for 'install a deskop icon'?

There is already (and always has been as far as I can remember) the option to control this on the Advanced install option.

Manichean · 05-29-2011, 03:42 PM

Quote:

Originally Posted by kovidgoyal

I added code to remember all the remaining user controlled settings. Of course, that means that the stupid microsoft installer waits even longer at the start of the install saying its "Migrating features from related products". Sigh.

Personally, if it saves me the time to click through the advanced install settings to avoid having a desktop icon installed every time, I'm happy

kovidgoyal · 05-29-2011, 04:18 PM

Quote:

Originally Posted by Manichean

Personally, if it saves me the time to click through the advanced install settings to avoid having a desktop icon installed every time, I'm happy

It isn't you I'm worried about, it's the annoying people that keep opening duplicate tickets telling me how the installer takes too long calculating free space.

05-28-2011, 05:07 AM	#1
Manichean Wizard Posts: 3,130 Karma: 91256 Join Date: Feb 2008 Location: Germany Device: Cybook Gen3	Windows installer changes in 0.8.3 I saw a note in the changelog saying that the installer will now remember the installation folder for future installations. Does this mean that it will also remember the user-selected installation options, like not having a desktop icon created?

05-29-2011, 01:07 PM	#11
kovidgoyal creator of calibre Posts: 43,930 Karma: 22669822 Join Date: Oct 2006 Location: Mumbai, India Device: Various	I added code to remember all the remaining user controlled settings. Of course, that means that the stupid microsoft installer waits even longer at the start of the install saying its "Migrating features from related products". Sigh. Last edited by kovidgoyal; 05-29-2011 at 01:09 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Invalid Windows Installer Package (7.4)	Sydney's Mom	Calibre	4	01-15-2011 01:28 PM
Problem with Windows installer	AprilHare	Calibre	6	12-29-2009 07:47 PM
Windows Installer?	radamo	Calibre	4	12-27-2009 08:09 AM
New windows build and installer	kovidgoyal	Calibre	17	10-11-2009 09:44 AM
Installer doesn't run on Windows 7	drogo	Calibre	5	02-09-2009 08:13 PM

05-28-2011, 09:50 AM	#2
atjnjk Zealot Posts: 107 Karma: 554 Join Date: Oct 2008 Device: none	For now, the windows installer only remembers the installation folder (it only stores this registry key info).

05-28-2011, 09:53 AM	#3
CRussel (he/him/his) Posts: 12,163 Karma: 79742714 Join Date: Jul 2010 Location: Sunshine Coast, BC Device: Oasis (Gen3),Paperwhite (Gen10), Voyage, Paperwhite(orig), Fire HD 8	too bad. I would definitely prefer that it not keep adding an icon to my desktop!

05-28-2011, 10:23 AM	#4
PeterT Grand Sorcerer Posts: 12,223 Karma: 74000000 Join Date: Nov 2007 Location: Toronto Device: Nexus 7, Clara, Touch, Tolino EPOS	Its strange; I have NEVER had any issues with the Calibre installer asking me for install info on upgrades OR creating new icons on the desktop!

05-28-2011, 12:55 PM	#7
Manichean Wizard Posts: 3,130 Karma: 91256 Join Date: Feb 2008 Location: Germany Device: Cybook Gen3	Okay, thanks.

05-29-2011, 10:46 AM	#9
itimpi Wizard Posts: 4,552 Karma: 950151 Join Date: Nov 2008 Device: Sony PRS-950, iphone/ipad (Marvin/iBooks/QuickReader)	I disagree - that seems over-complicated. A much better improvement will be to simply remember all the settings from the last install and make these the new default settings.

Advert

Advert