Tag browser: custom icons per category value?

[correoparaappzz]

Originally Posted by chaley

An implementation of per-value icons is in calibre source. It works in the GUI and in the content server.

Here is the documentation from the manual, with some formatting changed:

so if i wanted the series that only have 1 book to have a specific icon it won't work?

[chaley]

Originally Posted by correoparaappzz

so if i wanted the series that only have 1 book to have a specific icon it won't work?

That might be possible because the tag browser already has a count of books for a value. I'll see if this can be passed to the template as a variable. Average rating is also probably available.

I'm less sure about whether a value has notes or links. I'll check.

[chaley]

These changes are in calibre source:

• Make the book count available to an icon template as the variable 'count'. This is the same number one sees in the tag browser.
• Make the average rating available as 'avg_rating'. This is also the same number one sees in the tag browser.
• Add a menu action to remove all value icons from a category.
• Add an "icon rules viewer" tab to Look & feel / Tag browser. You can see all the rules. Rules can be deleted. They can't be edited.
• The same tab has two new checkboxes: "Show icons on categories in the tag browser" and "Show icons on values in the tag browser". Unchecking the box removes the icon.

There are still some potential problems with using database functions(has_note(), book_count(), etc.) in value icon templates in both the GUI and the content server. I hope to fix these in the next day or so.

This is the new "Value icons rules viewer" tab.

[correoparaappzz]

Originally Posted by chaley

These changes are in calibre source:

• Make the book count available to an icon template as the variable 'count'. This is the same number one sees in the tag browser.
• Make the average rating available as 'avg_rating'. This is also the same number one sees in the tag browser.
• Add a menu action to remove all value icons from a category.
• Add an "icon rules viewer" tab to Look & feel / Tag browser. You can see all the rules. Rules can be deleted. They can't be edited.
• The same tab has two new checkboxes: "Show icons on categories in the tag browser" and "Show icons on values in the tag browser". Unchecking the box removes the icon.

There are still some potential problems with using database functions(has_note(), book_count(), etc.) in value icon templates in both the GUI and the content server. I hope to fix these in the next day or so.

This is the new "Value icons rules viewer" tab.

so, this is for the next preview or release?

[Comfy.n]

Originally Posted by correoparaappzz

so, this is for the next preview or release?

We can't know for sure but when I want to take a peek at latest features, here's what i do:

download this:

https://github.com/kovidgoyal/calibr...ads/master.zip

or...

https://github.com/cbhaley/calibre/a...ads/master.zip

then extract that to some folder and run the attached script.

(in this case I've set path to C: just for simplifying purpose)

edit: make sure there are no calibre instances running before running from source.

[un_pogaz]

When I first saw the icon rule viewer, displaying the internal value assosiated to template bothered me a little because it wasn't {template} and so is wasn't consistent with other locations when a template is used to generate value. It really stuck in my mind for a while, but I couldn't find a way to write a good code to proposal.
Here my suggestion: Since the column "Use for children", write then a text {template}.

...
And now that I think about it, maybe it would be better than the internal value TEMPLATE_ICON_INDICATOR use " {template} " has value directly rather than " template " as is currently the case. Hm, it broke a bit if the user and test the feature on preview, but it's the risk of using preview and it will better display the fact that this icon rule is a template generator (instead that my suggestion above).

[chaley]

Originally Posted by correoparaappzz

so, this is for the next preview or release?

Saying "These changes are in calibre source" means that they are available now to people who run calibre from source and the changes will be in the next release (preview or release). Of course there is no guarantee that nothing will change between the commit to source and the release. This happens frequently because of problems found by people who run from source.

[chaley]

Originally Posted by un_pogaz

When I first saw the icon rule viewer, displaying the internal value assosiated to template bothered me a little because it wasn't {template} and so is wasn't consistent with other locations when a template is used to generate value. It really stuck in my mind for a while, but I couldn't find a way to write a good code to proposal.
Here my suggestion: Since the column "Use for children", write then a text {template}.

...
And now that I think about it, maybe it would be better than the internal value TEMPLATE_ICON_INDICATOR use " {template} " has value directly rather than " template " as is currently the case. Hm, it broke a bit if the user and test the feature on preview, but it's the risk of using preview and it will better display the fact that this icon rule is a template generator (instead that my suggestion above).

I originally did something like your first proposal but ran into problems with using the text as the dict key. I decided to make things easy and use the key directly, which meant using TEMPLATE_ICON_INDICATOR. Now that all the infrastructure changes are done I will go back to the browser. What I am looking at is adding icons saying what the value is using a different value for templates by using custom QTableWidgetItems.

[chaley]

The following changes are now in source. Most were provoked by ensuring that displaying composite columns and icons in the content server works.

• In the GUI:
  • GPM templates work as before. Note that in icon rule templates there is no book data so field-based functions such as format_date_field(), list_count_field(), and check_yes_no() won't work.
  • Python templates have full access to the calibre database.
• In the content server:
  • Templates have access to the new API but not the old API (LibraryDatabase).
  • Because of the above, the following formatter functions are not guaranteed to work in GPM templates (composite columns, icon rules, etc) and should be avoided if you use the content server.
    • connected_device_name()
    • connected_device_uuid()
    • current_virtual_library_name()
    • is_marked()
    • virtual_libraries()

[chaley]

@un_pogaz: Here is a capture of the dialog that I submitted to Kovid

[ownedbycats]

That looks good.

[chaley]

The dialog changes are now in source.

[un_pogaz]

Fancy, neat. Thanks.

[ownedbycats]

I tried it and ran into a strange behavior: If I select mulitple entries and then delete them, only one (the last selected) gets deleted. Intended?

Also, can access the template dialog from preferences?

[chaley]

Originally Posted by ownedbycats

I tried it and ran into a strange behavior: If I select mulitple entries and then delete them, only one (the last selected) gets deleted. Intended?

Multiple selection wasn't supposed to be implemented. I pushed a change to turn it off.

Also, can access the template dialog from preferences?

What do you mean?