Is select and drag supported in the HTML editor?

[jwes]

I select text and then click and drag it to where I want it. Sometimes it works, sometimes it switches to my stylesheet and makes changes, and sometimes it crashes Sigil. This is on Windows 10 and Sigil 1.9.30.

[DiapDealer]

Never tried it. It's certainly not intended to be supported. But crashes are bad. We have to eliminate any reproduce-able crashes.

[KevinH]

No it is not supported anyplace outside of Reordering Spine files in the BookBrowser.

For all other editors setAcceptDrops defaults to false.

This is something Windows must be doing which might explain any crashing.

[KevinH]

Of course, I just tried dragging a piece of previously selected text between paragraphs and it dropping it and it appeared to work. And this was in macOS.

We may have to take more steps to figure out why this is even allowed.

[KevinH]

Update:

It appears that QPlainTextEdit (CodeView) seems to default to setAcceptDrops(true) instead of the previously default false.

I literally had to add a setAcceptDrops(false); to the CodeViewEditor constructor to disable it.

Strange ....

From the Qt 6.5 and Qt 5.15 docs:

acceptDrops : bool

This property holds whether drop events are enabled for this widget

Setting this property to true announces to the system that this widget may be able to accept drop events.

If the widget is the desktop (windowType() == Qt::Desktop), this may fail if another application is using the desktop; you can call acceptDrops() to test if this occurs.

Warning: Do not modify this property in a drag and drop event handler.
By default, this property is false.

Access functions:

bool acceptDrops() const
void setAcceptDrops(bool on)
See also Drag and Drop.

Kevin

[KevinH]

And of course if you look at Qt's source code for qplaintextedit.cpp you can see the following in its private constructor:

    viewport->setBackgroundRole(QPalette::Base);
    q->setAcceptDrops(true);
    q->setFocusPolicy(Qt::StrongFocus);
    q->setAttribute(Qt::WA_KeyCompression);
    q->setAttribute(Qt::WA_InputMethodEnabled);
    q->setInputMethodHints(Qt::ImhMultiLine);

So much for the docs being correct!

I have pushed a fix to master for this. Drops from Drag and Drop will no longer be accepted in CodeView when editing.

This should prevent your random crashes on Windows.