Giving users menu/toolbars option when adding plugin

[kiwidude]

Have a look at the gui.json file, and if necessary edit the dictionary values in there if you cannot do it through the gui itself.

The dialog will only appear if it does not find that plugin name already on a menu/toolbar. The idea being that when you upgrade you don't get nagged. So if you want to test with the gui box part make sure the plugin is not on any of the four menus/toolbars, and then do Add plugin.

[meme]

Ok, that makes sense. On my main system I definitely added it to both toolbars before while testing (removing the dont_add_to line). So on this system, if I remove the plugin, everything looks gone. But when I add it I don't get prompted and it appears on both toolbars.

After editing the gui.json to remove all traces of the new/old version, I get the expected behaviour - I get prompted only on the initial install and it goes where I tell it.

I see that I also need to add 'context-menu-device' to the dont_add_to set since I only want users to be able to select the main toolbar when device is connected. And I'll update my instructions after doing that since users won't have to select it manually.

Thanks again.

[kiwidude]

Originally Posted by kiwidude

Your other question about the icons for the Preferences->Customize the toolbar is something that has been bugging me for a while. I did look at the code once and found the reason why it would not display them - there is nothing we as plugin developers can do, it needs Calibre code changes.

I just took another look at this to remind myself what the issue is. The way the code is written currently (in gui2\preferences\toolbar.py line 50), it uses the action_spec of the InterfaceAction to get a name of the icon.

Unfortunately in our plugins we have to set the icon name in that action spec to None, because our icons are coming from the plugin zip file. Your plugin used to have an icon appear for it because you used to set that action_spec value to the name of an icon that was in Calibre.

One workaround for this that comes to mind is if the Calibre code was to support grabbing the icon from the .qaction of the InterfaceAction. I added these lines of code at line 58:

            if hasattr(self._data[row], 'qaction'):
                icon = self._data[row].qaction.icon()
                if not icon.isNull():
                    return QVariant(icon)

And as per the screenshot icons magically appear

[kovidgoyal]

Committed.

[meme]

I'll look forward to the release